From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B381B4B28A for ; Sun, 23 Nov 2025 23:40:55 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'UdeF5YaoGJDYwJcuoEpQl7bA0Muncx2hlel8gmC5Bqg=', expected b'YR76GwY/sJTBpRmdcfDgeZamcLMRJClOgKtBheQlPXo=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763941246; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=UdeF5YaoGJDYwJcuoEpQl7bA0Muncx2hlel8gmC5Bqg=; b=dN8QDc4VyY+qbIcvI2xqd7PBpbc+A774eacBE5YqrcqgZ7HIDbJrZn/9l8Hoi5nh6s6ql q1NFTJXNYs/qPCPK03FGaVl7nBhwv89GxutKdn0sYcW2lgJNjwRgjWN6IVNMbKfqnQUFMRQ FSQwJkA6XlZemwFAQ5UE+u0wyS90YsnR/+ltIPhow0qL66WnqspZ3kpdRDSQBH0GRaS2zdj E2q/faTJuiokFUEfZMtDffCbKr7wjcr9Vwcw1/yyrpjh+jD2XZvhoulWG0IcUtTadPMEmrW iqX5QZRWj7M4tU+bkKH5VByJ74GLkHji96SIY0R2hRW7UlD/rHyM7IFoiDqA== Received: from [172.19.0.3] (unknown [172.19.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1D4ED6900BA; Mon, 24 Nov 2025 01:40:46 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763941231; b=IlHMu9IjSxdyQU3kM/CXYbZwfML/1WpMsdqE6JMRxLj8GpDlPaiNSoGtCwqKaAxplDes4 kNTYEnJjMkvRUtpMs4J/kS/gcR98OIXQJsSF90TTS8+lD/e7bh9sR0fUuDTbNIOCfky6n7L LOas6QVm6uYEsv5WClAvHSkIYbO2pHd6dO5wwf2OWjBkoxsR4DZCSsRV9vpIrtseNsJd7CW MGf14gU6KoFchRn06ukYiFBWmevpq+KTj9/3ECDtfXc9RfWIVvrKJfhehkLJ2VWCrrJfGAH GiF3eouqZ4OD0jeQg1L2y9y/AQ3g4AdBdxLp0Mm8oGfoziSUfbFtMUr1Aabw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763941231; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=xPruoRH1ehGaGy+dolhOit8QcGCLrKhS4WpIuty4kVQ=; b=itO+Kp4r5ds86QyYelS23o7nlWN93ac/y2wGShW9sZWW3YZqrDtEQsU7Mtz1oCwzecaOr Dyw5cDku9do4IUGXwPd8KwjywPNBEW3TIzzvezJTCg2dPxdZNeXX0UQJXhJGMQjSuW2TPs8 fUy/FFe6XW5Rdl2j3++wKWHXGh5ukugWDdOKgW6Bt6PpXdwiIq3MR5kKxhQYeDt3gKm4uY7 CwSfbKKT4Q1JI/e1q8bZcUpgkHLuw8aAvUpNdaLekvqnyPd9bjl5zBkRgEJZfg3Rhs8roO5 Fh40OUWBPSVLJJPMn0fXqa2ROCey/pXTGTgGvGByFryhqfTB8xPhR785tKMQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763941224; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=YR76GwY/sJTBpRmdcfDgeZamcLMRJClOgKtBheQlPXo=; b=x/JMt+ZC+yUdHduZP270w/uvTmU/7kjhrc+PuJXdgEnyYLC0T3RRR51GkANpHB/ORUWSt YjWUFtLIjJdGvPcVOi0VUHUud1sOZBVHBFZNISS8zqqxw8iJmOzIwOKC57J9qJ8k3o2aJwi LYd0G5BkpdPBYNm7S6ZgdYe7i5wLOg7Nftu0ZdOI+NSutTd6ZlNjNe/zCr2mZag3cyxwnzN RyWr1i6a77q9UCnoiVG1HtppdKUbyIzGvksOxE01DmTbxI9n3rbZGXyuMTCAJWqqsvjudYp IqmukLsOjB0QG23skCS98D9yNpbdEi3Tc/lcEiPS4gleeZstfVQnRPFbofow== Received: from 55ca25703178 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 57C08690040 for ; Mon, 24 Nov 2025 01:40:24 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Sun, 23 Nov 2025 23:40:24 -0000 Message-ID: <176394122451.39.3127059390218144420@2cb04c0e5124> Message-ID-Hash: SYTPVZTSROXDSAA2GMRE4NKNUS77DX6P X-Message-ID-Hash: SYTPVZTSROXDSAA2GMRE4NKNUS77DX6P X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] libavdevice/decklink: Implement QueryInterface to support newer driver (PR #21002) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Thomas Gritzan via ffmpeg-devel Cc: Thomas Gritzan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #21002 opened by Thomas Gritzan (Phygon) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21002 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21002.patch Playback to a decklink device with a newer version of the DeckLink SDK (14.3) stalls because the driver code calls IDeckLinkVideoFrame::QueryInterface, which is not implemented by ffmpeg. This patch implements decklink_frame::QueryInterface, so that playback works with both older (12.x) and newer (>= 14.3) drivers. Note: The patch still does not allow the code to compile with DeckLink SDK 14.3 or newer, as the API has changed. >>From 22f08f1d0158d5064fa121d03b8330aa29ae8e28 Mon Sep 17 00:00:00 2001 From: Thomas Gritzan Date: Mon, 24 Nov 2025 00:26:33 +0100 Subject: [PATCH] libavdevice/decklink: Implement QueryInterface to support newer driver Playback to a decklink device with a newer version of the DeckLink SDK (14.3) stalls because the driver code calls IDeckLinkVideoFrame::QueryInterface, which is not implemented by ffmpeg. This patch implements decklink_frame::QueryInterface, so that playback works with both older (12.x) and newer (>= 14.3) drivers. Note: The patch still does not allow the code to compile with DeckLink SDK 14.3 or newer, as the API has changed. --- libavdevice/decklink_enc.cpp | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp index cb8f91730e..0e743348c6 100644 --- a/libavdevice/decklink_enc.cpp +++ b/libavdevice/decklink_enc.cpp @@ -47,6 +47,11 @@ extern "C" { #include "libklvanc/pixels.h" #endif +static bool IsEqualGUID(const REFIID &iid1, const REFIID &iid2) +{ + return memcmp(&iid1, &iid2, sizeof(REFIID)) == 0; +} + /* DeckLink callback class declaration */ class decklink_frame : public IDeckLinkVideoFrame { @@ -111,7 +116,19 @@ public: _ancillary->AddRef(); return S_OK; } - virtual HRESULT STDMETHODCALLTYPE QueryInterface(REFIID iid, LPVOID *ppv) { return E_NOINTERFACE; } + virtual HRESULT STDMETHODCALLTYPE QueryInterface(REFIID iid, LPVOID *ppv) + { + if (IsEqualGUID(iid, IID_IUnknown) || IsEqualGUID(iid, IID_IDeckLinkVideoFrame)) { + *ppv = static_cast(this); + } else { + *ppv = NULL; + return E_NOINTERFACE; + } + + AddRef(); + return S_OK; + } + virtual ULONG STDMETHODCALLTYPE AddRef(void) { return ++_refs; } virtual ULONG STDMETHODCALLTYPE Release(void) { -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org