Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: GXTX via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: GXTX <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH] avformat/xmv: Handle zero sized packet at end of file (PR #20985)
Date: Thu, 20 Nov 2025 21:26:25 -0000
Message-ID: <176367398579.59.5387326870003812966@2cb04c0e5124> (raw)

PR #20985 opened by GXTX
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20985
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20985.patch

Fixes: #20982

This doesn't appear with every XMV.


>From 797d63a4d77ab06dafedb4d76a8393481bcc7b2f Mon Sep 17 00:00:00 2001
From: wutno <aaron@installgentoo.net>
Date: Thu, 20 Nov 2025 16:19:49 -0500
Subject: [PATCH] avformat/xmv: Handle zero sized packet at end of file

---
 libavformat/xmv.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libavformat/xmv.c b/libavformat/xmv.c
index ed59f7b85b..63ae4a05a7 100644
--- a/libavformat/xmv.c
+++ b/libavformat/xmv.c
@@ -417,6 +417,12 @@ static int xmv_fetch_new_packet(AVFormatContext *s)
     /* Seek to it */
     xmv->this_packet_offset = xmv->next_packet_offset;
     if (avio_seek(pb, xmv->this_packet_offset, SEEK_SET) != xmv->this_packet_offset)
+        /* It's possible the packet we're about to work on has no size. This can
+         * happen when it's the last packet of the XMV. So, let's check if we're
+         * at the end of the file again and gracefully close out.
+         */
+        if (xmv->this_packet_offset == xmv->next_packet_offset)
+            return AVERROR_EOF;
         return AVERROR(EIO);
 
     /* Update the size */
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2025-11-20 21:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176367398579.59.5387326870003812966@2cb04c0e5124 \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git