From: James Almer via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: James Almer <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH] swscale/x86/ops: fix signed integer related UB in normalize_clear() (PR #20984)
Date: Thu, 20 Nov 2025 21:16:08 -0000
Message-ID: <176367336907.59.4750658574025999031@2cb04c0e5124> (raw)
PR #20984 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20984
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20984.patch
>From 1c311c52834b125a9af4637b04df33194565450c Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Thu, 20 Nov 2025 18:15:23 -0300
Subject: [PATCH] swscale/x86/ops: fix signed integer related UB in
normalize_clear()
Signed-off-by: James Almer <jamrial@gmail.com>
---
libswscale/x86/ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libswscale/x86/ops.c b/libswscale/x86/ops.c
index 26f49582ae..97bee93f5b 100644
--- a/libswscale/x86/ops.c
+++ b/libswscale/x86/ops.c
@@ -616,8 +616,8 @@ static void normalize_clear(SwsOp *op)
if (!op->c.q4[i].den)
continue;
switch (ff_sws_pixel_type_size(op->type)) {
- case 1: c.u32 = 0x1010101 * priv.u8[i]; break;
- case 2: c.u32 = priv.u16[i] << 16 | priv.u16[i]; break;
+ case 1: c.u32 = 0x1010101U * priv.u8[i]; break;
+ case 2: c.u32 = (uint32_t)priv.u16[i] << 16 | priv.u16[i]; break;
case 4: c.u32 = priv.u32[i]; break;
}
--
2.49.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
reply other threads:[~2025-11-20 21:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176367336907.59.4750658574025999031@2cb04c0e5124 \
--to=ffmpeg-devel@ffmpeg.org \
--cc=code@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git