From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5D32E4D366 for ; Mon, 17 Nov 2025 16:06:50 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'2AeAx3gFsGEfJ5lY3Gv3wAqDsMtl1Y1gAKTZ7tYS8hc=', expected b'YAwxbX9p8e8sKN32zTn8fz3OEK16HOWDQGvqpY6DrJQ=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763395600; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=2AeAx3gFsGEfJ5lY3Gv3wAqDsMtl1Y1gAKTZ7tYS8hc=; b=Ygjmr6aGKXgjInMtDc8/6M0i+4FtCsTbZQOxglkd/owIkcdsMiUE9+oRUkkT2U3ULmjq4 a21ZTEsXtItXLJI9Tvj5TZVYQ/S/+Q+ki1+y9hMIR9ZHTO0ffvWi2jWfbqvOKY1mPanevzo rqfCL3IVMu4ddUj5aEnfqP6xKStMZWe2PKK/k5bWFzCS1C2nwbFgrC046HlWG9bDKP43Lv+ GwA2nyc+XRR6WxVuV55sNvz7Ci5YmaILqWNDoCF2vnFjYsgn545MgablX5Brop8QhRcrWIv Yb8amI8n06wkqKycZ4ZLEz9xOmc0ioc5GwtOz8ciOxgsqDsyopDAX3Zh9lDw== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D861668FF06; Mon, 17 Nov 2025 18:06:40 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763395585; b=nmXvkCXsmqXPjyf0xS3vQkf4vb2nMhZBsdL5Ravfz2mcwuaozxlrNwmXJVTETE99yWQ6K AR3zWyGvXFe/SNMA+rNugrMAacVnuIkfshOft1TMghDyEned1Sd2o3tfys7a3trJaVd7s/u uXnpNHEkXESKeeLBBRBG58EySop+rt0Y//iSoiCWSoMDRhRud5GiI252e4ZRujGjmYYIXZ1 GoceMHEcEi18kO9VzLvvR6t92uCKK817Gtvj3DmI/xZUDLSvo7WMaGWAcqgtCfWnQQxCCMb +je1aDFSS1wT6crvPTCEvftElj7a0/agzjbYm4mEk3W39ABijzhQH0hXuQDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763395585; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=kmS1EvOc11ZLslu7fYV1LGgdOgyjnBpRrmf/LV1fQUk=; b=jLoghOfAzMQ+BNrhdz+nx+BBxbEbj28meUATZZ1mt618CX3wLHMb0vFh3kCQGmxLWMKo5 lcoikKSZDMh4uCbOdlYZgOX9MpSxZ2o92idZY6JMqg2za8acuCX9QJY3X32DZznuuQHVBg5 JJvS6Pm/DYJwaT/Ge2tDArWRqvO+VxVbrBM0/vIvy/R5hayuZGb5KV36vOHeo8473POtC61 iApWvUtXzAYDt3WcifeiBALTLIoKikOmZSXRHlS2pPAqAv7smj/ZFYruMw+I/E6fX1YkF+g u1Z2LJInB7cSJiMfAj5J4CyR4yHotxpCecemNjYL4/rSH/ZaJoxYxsqQZM2Q== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763395578; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=YAwxbX9p8e8sKN32zTn8fz3OEK16HOWDQGvqpY6DrJQ=; b=I5upYG6oL5vnQ2eVu2zd6WpMQsCeXgJ7po0Usq2X8pKn4mzk0UnYL0NHklMUTMNULzzkH vuSPxbNw80QOfpEvW3bQ3Ph1tYpAzy91yDFcxpqPufkewTBnGDrcI+rAP3SqhJN+N4msZO8 RPSq4K0mlfuZubwv3ZbKHk+CftY8Jcp/O4ZpnZL4UhSkyNZSx5AI51s0wEfCgYxv5L9X4hS cqQ41KO3bx/Y8WdLiuj7+2NMoGdmyaXz7Nbpc7iB8p8mEPE5i9bcBPKqYmTNcupNO1E1Eqg a9+ATBrzMkL4lx7PCnBmKFAWO1utynf69HNCsHOOlIbKaY/YADFHK+ukD9AQ== Received: from 188d6d40ca7a (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 66F3C68FE99 for ; Mon, 17 Nov 2025 18:06:18 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Mon, 17 Nov 2025 16:06:18 -0000 Message-ID: <176339557853.25.7196239267873298644@2cb04c0e5124> Message-ID-Hash: OLVNJLYACWGP7MZUCYWA7OWCGLAO6WF4 X-Message-ID-Hash: OLVNJLYACWGP7MZUCYWA7OWCGLAO6WF4 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] Revert " avfilter/avfilter: always forward request frame in filter_activate_default" (PR #20944) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jack Lau via ffmpeg-devel Cc: Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20944 opened by Jack Lau (JackLau) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20944 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20944.patch Fix #20940 This reverts commit 4440e499ba It breaks some filters like feedback, and make li->frame_blocked_in check invaild. Signed-off-by: Jack Lau >>From 9862f4a16c5f36f263a8677fb17b2d68766a969a Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Mon, 17 Nov 2025 23:55:53 +0800 Subject: [PATCH] Revert " avfilter/avfilter: always forward request frame in filter_activate_default" Fix #20940 This reverts commit 4440e499ba It breaks some filters like feedback, and make li->frame_blocked_in check invaild. Signed-off-by: Jack Lau --- libavfilter/avfilter.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 169c2baa42..cea2c442f2 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -1290,11 +1290,6 @@ static int filter_activate_default(AVFilterContext *filter) return request_frame_to_filter(filter->outputs[i]); } } - for (i = 0; i < filter->nb_outputs; i++) { - FilterLinkInternal * const li = ff_link_internal(filter->outputs[i]); - if (li->frame_wanted_out) - return request_frame_to_filter(filter->outputs[i]); - } if (!filter->nb_outputs) { ff_inlink_request_frame(filter->inputs[0]); return 0; @@ -1433,12 +1428,6 @@ static int filter_activate_default(AVFilterContext *filter) repeatedly on a blocked input if another is not blocked (example: [buffersrc1][testsrc1][buffersrc2][testsrc2]concat=v=2). - - If an output has frame_wanted_out > 0 call request_frame(). - - Rationale: even if all inputs are blocked an activate callback should - request a frame on some if its inputs if a frame is requested on any of - its output. - - Request a frame on the input for sinks. Rationale: sinks using the old api have no way to request a frame on their -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org