From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2FFCE4D266 for ; Fri, 14 Nov 2025 21:26:56 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'eKY6uXoRvSphavddXUJoFL9LtYaSoDC8V4o6c+/caeU=', expected b'w01uE9RMmclfU1GeaHA6pgcZhFrhW4eek4knzbRts0M=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763155607; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=eKY6uXoRvSphavddXUJoFL9LtYaSoDC8V4o6c+/caeU=; b=A77XDyREJV/PfGHKjMFladKV1EXBiDPO/WBVPKj2O6iXqW9HTk0tZdzxxzwVCHKZZDnPh WI1IGWKaUTz+CqZwgoTkqSSTI5CqHEUJBakcEmjIa+xoaBY3X9Akbum6L5vQya/jtaBH1p7 /GonCP4kRjrxjaWFqC60QILVqpK+SZ0XwzVPcpqOwsP2rr7+v/Dbf4np4oTvS6ekCkFP1KK H/TZGVeFCN3yRJREc7SANOxDMridMMgXSB1ewmkudmfa8pjowYWT3CxocsvCRcXBP5Se8V9 iKbsVJqENp0BTIkldt4Y+1+kR5VKpLA60GgxdQx5GHiwEKTG3cQb6IBBwGxw== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 63BEC68FDE9; Fri, 14 Nov 2025 23:26:47 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1763155590; b=E8vkrr4iOMVZKMQSkHNEQNrc3DATW8EPDkdFrHW08ZnAbPlWpOWXEuwwuWX6F1SEvpyUd lkMvzJqzTsF7/AJs627R7ZPvnVEOXpma25RkxEuFDIh2lygobD63MhRp+Rc2ucp6wyD5QTS /W3gH3BvvpKs87LyycV5N98flV86XRZoHr3vGuw00PdLPY1pp4OINukLMyLry6q64jG5b0R u0ItYTwrUtpecxzFBsmMzT+dNIq6hQpbq1QADzEku2PaUZmc35pu9PacYZI3WT2gsGKz8Ws nrD5CularqmhMOhvAkj2KMm6p+unKkJbh74Tyl09FdrVGrPqaY7YenrhiPUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1763155590; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=yO0gfmZ82pNt3zEoSh64+VRHFd/FOUvh/fvqnhCC65w=; b=gwOQo9l6IXGkHCRJiJQU3NeNUTIFwFt0CWzQgHXvuHpw8aosk7smeANHbnvGqhDfwlURe pu4f6T7naFSjGkji/piZ8AdkYh7Qb/LqMXElL6Cvn944CM5eZI6KSJSQB/asLL1kgDJ58/e /rrTqe7BkaQt7sF/v9sRawoP+E1/U6AvvEHkRlTxKANcTN8pSU2LGdIO7T7wwYJ9plAMk09 Z4jgoRpoLM5ff0jacvSZJivdyCFH+PW2NFqMAQDP+4uDa6M7S+sfWRroTUTPE+YrJgBBBqg rFxdYHRjYjo8pFVtqE5hpG1+mt1Ukn9hs5dyb9BImQnIxqnzdBRov8GoO/BA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1763155582; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=w01uE9RMmclfU1GeaHA6pgcZhFrhW4eek4knzbRts0M=; b=vG4vMjdZdSwm8oJIaG5bPmHIX4MuZPlOfoEESCS3ZwoVnaBI70X4qXyO6VTQ5gyU/dqpE GR/6LtrNgNgYoOliiF0Jd28axsOL2Ms5rfEy1hBQFskNXhTYq5Sk8TfdIBZjIqA6PiiJvyQ rW7wymLkR5MtOeEqbN01RZKNxu+L2y5J1JLINh+6pYqaDAnKdXGIp9xGm8Zprgb8Gk/PPO5 uhDy7FzmaALM9kiGf/m5DUftPmpUKVeHOKRFZbuSTLmwOZEe6AgJlgMZlHK8mMNyvw8L0O+ VNtjc0krGmciyxKc2a9us/ASKV4nYsE7vGHGkfuWueiJqWrqemFZdC35J9XA== Received: from 188d6d40ca7a (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 8905F68FDAE for ; Fri, 14 Nov 2025 23:26:22 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 14 Nov 2025 21:26:22 -0000 Message-ID: <176315558270.25.16091753524288211488@2cb04c0e5124> Message-ID-Hash: ONB22QSBWOEFNATZAQ3L7GLHRAQYN3LS X-Message-ID-Hash: ONB22QSBWOEFNATZAQ3L7GLHRAQYN3LS X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] Update libavformat/segafilmenc.c (PR #20922) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Shubin123 via ffmpeg-devel Cc: Shubin123 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20922 opened by Shubin123 URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20922 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20922.patch The film_write_packet() function reads encoded_buf_size from packet data via AV_RB24() and uses it in a modulo operation without validation. When the data contains zeros at this position, it causes division by zero. Add validation to return AVERROR_INVALIDDATA when encoded_buf_size is zero. >>From 27c5051a7a659f8723bb5fc6afe754988a9c2c4e Mon Sep 17 00:00:00 2001 From: Shubin123 Date: Fri, 14 Nov 2025 21:09:50 +0000 Subject: [PATCH] Update libavformat/segafilmenc.c The film_write_packet() function reads encoded_buf_size from packet data via AV_RB24() and uses it in a modulo operation without validation. When the data contains zeros at this position, it causes division by zero. Add validation to return AVERROR_INVALIDDATA when encoded_buf_size is zero. --- libavformat/segafilmenc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavformat/segafilmenc.c b/libavformat/segafilmenc.c index 88a5b9f972..2206ff9033 100644 --- a/libavformat/segafilmenc.c +++ b/libavformat/segafilmenc.c @@ -58,6 +58,10 @@ static int film_write_packet(AVFormatContext *format_context, AVPacket *pkt) if (codec_id == AV_CODEC_ID_CINEPAK) { encoded_buf_size = AV_RB24(&pkt->data[1]); /* Already Sega Cinepak, so no need to reformat the packets */ + if (encoded_buf_size == 0) { + av_log(format_context, AV_LOG_ERROR, "Invalid encoded_buf_size 0\n"); + return AVERROR_INVALIDDATA; + } if (encoded_buf_size != pkt->size && (pkt->size % encoded_buf_size) != 0) { avio_write(pb, pkt->data, pkt->size); } else { -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org