Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avcodec/prores_raw: Reuse permutation (PR #20918)
@ 2025-11-14 11:36 mkver via ffmpeg-devel
  0 siblings, 0 replies; only message in thread
From: mkver via ffmpeg-devel @ 2025-11-14 11:36 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: mkver

PR #20918 opened by mkver
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20918
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20918.patch

The ProresDSPContext already contains the idct_permutation.

Seems like the raw code has been branched of before February (before deee2fb52d4ae0fe2a0cf1698a200ab02e3a9741).


>From 9ef362489266e92c8d14bca2f0b9c9b40737bf30 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Fri, 14 Nov 2025 12:31:11 +0100
Subject: [PATCH] avcodec/prores_raw: Reuse permutation

The ProresDSPContext already contains the idct_permutation.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/prores_raw.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/libavcodec/prores_raw.c b/libavcodec/prores_raw.c
index 65e0576619..9bc76da698 100644
--- a/libavcodec/prores_raw.c
+++ b/libavcodec/prores_raw.c
@@ -43,7 +43,6 @@
 static av_cold int decode_init(AVCodecContext *avctx)
 {
     ProResRAWContext *s = avctx->priv_data;
-    uint8_t idct_permutation[64];
 
     avctx->bits_per_raw_sample = 12;
     avctx->color_primaries = AVCOL_PRI_UNSPECIFIED;
@@ -55,10 +54,7 @@ static av_cold int decode_init(AVCodecContext *avctx)
     ff_blockdsp_init(&s->bdsp);
     ff_proresdsp_init(&s->prodsp, avctx->bits_per_raw_sample);
 
-    ff_init_scantable_permutation(idct_permutation,
-                                  s->prodsp.idct_permutation_type);
-
-    ff_permute_scantable(s->scan, ff_prores_interlaced_scan, idct_permutation);
+    ff_permute_scantable(s->scan, ff_prores_interlaced_scan, s->prodsp.idct_permutation);
 
     return 0;
 }
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-11-14 11:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-14 11:36 [FFmpeg-devel] [PATCH] avcodec/prores_raw: Reuse permutation (PR #20918) mkver via ffmpeg-devel

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git