* [FFmpeg-devel] [PATCH] avdevice/lavfi: stop setting deprecated buffersink options (PR #20913)
@ 2025-11-13 17:57 James Almer via ffmpeg-devel
2025-11-14 7:56 ` [FFmpeg-devel] " Nicolas George via ffmpeg-devel
0 siblings, 1 reply; 2+ messages in thread
From: James Almer via ffmpeg-devel @ 2025-11-13 17:57 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: James Almer
PR #20913 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20913
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20913.patch
>From 66244bab100270f689a07237f09f55a1245fdc26 Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Thu, 13 Nov 2025 14:55:23 -0300
Subject: [PATCH] avdevice/lavfi: stop setting deprecated buffersink options
Signed-off-by: James Almer <jamrial@gmail.com>
---
libavdevice/lavfi.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c
index 548183d633..0de2bbdcf8 100644
--- a/libavdevice/lavfi.c
+++ b/libavdevice/lavfi.c
@@ -255,12 +255,9 @@ av_cold static int lavfi_read_header(AVFormatContext *avctx)
goto end;
}
- ret = av_opt_set_bin(sink, "sample_fmts", (const uint8_t*)sample_fmts,
- sizeof(sample_fmts), AV_OPT_SEARCH_CHILDREN);
- if (ret < 0)
- goto end;
- ret = av_opt_set_int(sink, "all_channel_counts", 1,
- AV_OPT_SEARCH_CHILDREN);
+ ret = av_opt_set_array(sink, "sample_formats", AV_OPT_SEARCH_CHILDREN, 0,
+ FF_ARRAY_ELEMS(sample_fmts), AV_OPT_TYPE_SAMPLE_FMT,
+ sample_fmts);
if (ret < 0)
goto end;
--
2.49.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 2+ messages in thread
* [FFmpeg-devel] Re: [PATCH] avdevice/lavfi: stop setting deprecated buffersink options (PR #20913)
2025-11-13 17:57 [FFmpeg-devel] [PATCH] avdevice/lavfi: stop setting deprecated buffersink options (PR #20913) James Almer via ffmpeg-devel
@ 2025-11-14 7:56 ` Nicolas George via ffmpeg-devel
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas George via ffmpeg-devel @ 2025-11-14 7:56 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Nicolas George
James Almer via ffmpeg-devel (HE12025-11-13):
> PR #20913 opened by James Almer (jamrial)
> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20913
> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20913.patch
I intended to review that. I see no review on the web monster either.
Not cool.
--
Nicolas George
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-14 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-13 17:57 [FFmpeg-devel] [PATCH] avdevice/lavfi: stop setting deprecated buffersink options (PR #20913) James Almer via ffmpeg-devel
2025-11-14 7:56 ` [FFmpeg-devel] " Nicolas George via ffmpeg-devel
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git