From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 608E54C468 for ; Wed, 12 Nov 2025 19:45:24 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'eLGFtP7ZboWSmzEEz6BP0t08ZAeSodgVyA4/7k1O6zw=', expected b'wZl6jRF50ph13QhwXR9BMvnDZFO/wzRQ+yHFeIZlJTE=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762976705; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=eLGFtP7ZboWSmzEEz6BP0t08ZAeSodgVyA4/7k1O6zw=; b=whr62yE6xQixhsz7rO+V3D362KUvd/mqeWr7G6Sxvuh/RglPv4gf6HxnpKNa+k2MZ8SgO g7hGavUtvhOM7/Kncjs6p7QTkQJ1lXTbKKUy9yCTrrrAcRmrjMTJmlJW5A3nYBVRzVkFao5 BdGnxMq7r6hv3JsEgT0hUGJnQ6OPGKj9E5XHFugHwSQIPMph4vuWFcnkl67k5Nm3Cjt6inm YNEKdv7tQtsAxBHsze9jZTPq9ki+dc3CdFD7kgmrQatcpqtEpzPngjXf4CUsH8xCWADJWMF L88buH+n50sKGZ9EF+cV8uuZpLRwfPGnUYHKA49E2OLJ4G8YMB3PlBOws2oQ== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id A5AB268FDE3; Wed, 12 Nov 2025 21:45:05 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1762976675; b=Pn9QaxvOwfALzSBL3R8SCWZNNBbquh8sk7Spfr2+Yuo/0l+ce0XIBp3YUfqpcoMUHtmc2 mOR4SgiNVfRrKGEBvYn0llrAEotyUfJJXk5259VgdUSVUptHHfnd6fPji09RqJKtrEFoCp1 9B5r76iUq7Q/Rko3mM+JBrdMHW3IXVcKyjKyIgM/coYXg7yegkGu6XWWGad0pLnKY2Rn8OY s2YYtz6MKSsfZW5tfejFM9WkqzY8EZP7u/QOgVJP8OtCoU45xAwYH9K01yS3kYlQghhN7F/ qNAGrfkItPIxGHu+RfJj2oVZlVeDT9t2Z1JHwwjSl13eZcWeLWP1d1cDyibA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1762976675; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=/yFrPz8Shy+SUcVd0qeNduhA10iZTBc+UQIfsSC/XAU=; b=XlliQ8O3hlmLN4OAsfaByjBztvvaNjChpSLAAqQDVciuNgHJlKtxs//2a2kl/JLw/Fasr zVHiBSc+/84mbKGzDVnqtmFmfSzNqmwsbdLhF4A5OyzVywQfowkwHG6iaD0WSlqt3DHnKij 9ahZlF26GQyr5mHcL0qcgwf5T6fQltMdu0ql7oublYs4G/Up0nfih67edfCnjMeBbjS8vq2 xtbF7FQlUWquKIynDlxeIfsR7hjKNmopiDGAjk8xbZcSGsZAFZk0XrVET6wX7eU3BGo1whW gsBRXQ7la1LgHac49rr1wA4n9Vv18/ISQu17M33r/WCjdg0n3B0nNdSB0cQw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762976666; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=wZl6jRF50ph13QhwXR9BMvnDZFO/wzRQ+yHFeIZlJTE=; b=XHSKcTUkLpFZP/kWH0WgztmVSyx9Ku0miU0rtaXK1+MrCfckYqDA8iTP+HAyXFM5uBEIR ZPAxqWAMVbMdw9lsAOYzOnlCfWMTuIvij3tgyzIEa7RuAuwRp0h4T5qUOGYc/VuNZzKu02u DXOiwzw3PK9vYQaNeP9Rk37cDyKfV0bSx3Pn0njmdgE1cdCVQu2s6ZyFSOJ3CdmmS5w3/12 EDgJYSO2v64Djn0QgWMnQCtj6KtruOF9zf4lw9NmfNsrjY9rmUjhr1QJ+xURuXL75yPQcTD FiCryhgZYwEr5+KR7uO+CBWkk6ACOQuXKSzvQ+eHGwFTgus9NMSbVa69YJag== Received: from 188d6d40ca7a (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id CCA1E6801B0 for ; Wed, 12 Nov 2025 21:44:26 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 12 Nov 2025 19:44:26 -0000 Message-ID: <176297666702.25.7483307740798350697@2cb04c0e5124> Message-ID-Hash: RO5ZQ5VYPEHWUK7GYW5AT7LNVRZW3XE6 X-Message-ID-Hash: RO5ZQ5VYPEHWUK7GYW5AT7LNVRZW3XE6 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] libavcodec/ppc: remove broken AltiVec acceleration for lossless audio (PR #20901) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Sean McGovern via ffmpeg-devel Cc: Sean McGovern Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20901 opened by Sean McGovern (sean_mcg) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20901 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20901.patch It fails sporadically on big- or little-endian POWER/PPC, as well as triggers the undefined-behaviour & address scanners in GCC. refs: #20832 >>From 35464ad9ebe1f0502775748e680dc0167ddc57cc Mon Sep 17 00:00:00 2001 From: Sean McGovern Date: Wed, 12 Nov 2025 14:22:44 -0500 Subject: [PATCH] libavcodec/ppc: remove broken AltiVec acceleration for lossless audio It fails sporadically on big- or little-endian POWER/PPC, as well as triggers the undefined-behaviour & address scanners in GCC. --- libavcodec/lossless_audiodsp.c | 2 - libavcodec/lossless_audiodsp.h | 1 - libavcodec/ppc/Makefile | 1 - libavcodec/ppc/lossless_audiodsp_altivec.c | 91 ---------------------- 4 files changed, 95 deletions(-) delete mode 100644 libavcodec/ppc/lossless_audiodsp_altivec.c diff --git a/libavcodec/lossless_audiodsp.c b/libavcodec/lossless_audiodsp.c index b0d64cf5b3..94e6ce0989 100644 --- a/libavcodec/lossless_audiodsp.c +++ b/libavcodec/lossless_audiodsp.c @@ -61,8 +61,6 @@ av_cold void ff_llauddsp_init(LLAudDSPContext *c) #if ARCH_ARM ff_llauddsp_init_arm(c); -#elif ARCH_PPC - ff_llauddsp_init_ppc(c); #elif ARCH_RISCV ff_llauddsp_init_riscv(c); #elif ARCH_X86 diff --git a/libavcodec/lossless_audiodsp.h b/libavcodec/lossless_audiodsp.h index cf2d43d7c9..e89e27fef0 100644 --- a/libavcodec/lossless_audiodsp.h +++ b/libavcodec/lossless_audiodsp.h @@ -45,7 +45,6 @@ typedef struct LLAudDSPContext { void ff_llauddsp_init(LLAudDSPContext *c); void ff_llauddsp_init_arm(LLAudDSPContext *c); -void ff_llauddsp_init_ppc(LLAudDSPContext *c); void ff_llauddsp_init_riscv(LLAudDSPContext *c); void ff_llauddsp_init_x86(LLAudDSPContext *c); diff --git a/libavcodec/ppc/Makefile b/libavcodec/ppc/Makefile index cbd9621e05..bddba27727 100644 --- a/libavcodec/ppc/Makefile +++ b/libavcodec/ppc/Makefile @@ -21,7 +21,6 @@ OBJS-$(CONFIG_VP8DSP) += ppc/vp8dsp_altivec.o # decoders/encoders OBJS-$(CONFIG_HEVC_DECODER) += ppc/hevcdsp.o -OBJS-$(CONFIG_LLAUDDSP) += ppc/lossless_audiodsp_altivec.o OBJS-$(CONFIG_MPEG4_DECODER) += ppc/mpeg4videodsp.o OBJS-$(CONFIG_SVQ1_ENCODER) += ppc/svq1enc_altivec.o OBJS-$(CONFIG_VORBIS_DECODER) += ppc/vorbisdsp_altivec.o diff --git a/libavcodec/ppc/lossless_audiodsp_altivec.c b/libavcodec/ppc/lossless_audiodsp_altivec.c deleted file mode 100644 index 298e6c38a0..0000000000 --- a/libavcodec/ppc/lossless_audiodsp_altivec.c +++ /dev/null @@ -1,91 +0,0 @@ -/* - * Copyright (c) 2007 Luca Barbato - * - * This file is part of FFmpeg. - * - * FFmpeg is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * FFmpeg is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with FFmpeg; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA - */ - -#include "config.h" - -#include "libavutil/attributes.h" -#include "libavutil/cpu.h" -#include "libavutil/ppc/cpu.h" -#include "libavutil/ppc/util_altivec.h" - -#include "libavcodec/lossless_audiodsp.h" - -#if HAVE_BIGENDIAN -#define GET_T(tt0,tt1,src,a,b){ \ - a = vec_ld(16, src); \ - tt0 = vec_perm(b, a, align); \ - b = vec_ld(32, src); \ - tt1 = vec_perm(a, b, align); \ - } -#else -#define GET_T(tt0,tt1,src,a,b){ \ - tt0 = vec_vsx_ld(0, src); \ - tt1 = vec_vsx_ld(16, src); \ - } -#endif - -#if HAVE_ALTIVEC -static int32_t scalarproduct_and_madd_int16_altivec(int16_t *v1, - const int16_t *v2, - const int16_t *v3, - int order, int mul) -{ - LOAD_ZERO; - vec_s16 *pv1 = (vec_s16 *) v1; - register vec_s16 muls = { mul, mul, mul, mul, mul, mul, mul, mul }; - register vec_s16 t0, t1, i0, i1, i4, i2, i3; - register vec_s32 res = zero_s32v; -#if HAVE_BIGENDIAN - register vec_u8 align = vec_lvsl(0, v2); - i2 = vec_ld(0, v2); - i3 = vec_ld(0, v3); -#endif - int32_t ires; - - order >>= 4; - do { - GET_T(t0,t1,v2,i1,i2); - i0 = pv1[0]; - i1 = pv1[1]; - res = vec_msum(t0, i0, res); - res = vec_msum(t1, i1, res); - GET_T(t0,t1,v3,i4,i3); - pv1[0] = vec_mladd(t0, muls, i0); - pv1[1] = vec_mladd(t1, muls, i1); - pv1 += 2; - v2 += 16; - v3 += 16; - } while (--order); - res = vec_splat(vec_sums(res, zero_s32v), 3); - vec_ste(res, 0, &ires); - - return ires; -} -#endif /* HAVE_ALTIVEC */ - -av_cold void ff_llauddsp_init_ppc(LLAudDSPContext *c) -{ -#if HAVE_ALTIVEC - if (!PPC_ALTIVEC(av_get_cpu_flags())) - return; - - c->scalarproduct_and_madd_int16 = scalarproduct_and_madd_int16_altivec; -#endif /* HAVE_ALTIVEC */ -} -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org