From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9737D4D1AE for ; Wed, 12 Nov 2025 04:23:18 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'QzPH118ScSspH0ZzbbpN9yp4FCYvK6/wnDAYawDRk9Q=', expected b'onI4Wt0W5VBTGJXuM28aaT1Nyp74UBT8lMQxadnpKHc=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762921391; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=QzPH118ScSspH0ZzbbpN9yp4FCYvK6/wnDAYawDRk9Q=; b=klwjMpeXEzn/1gnN2lZiqgN2/kRdDuroRfuBzwTW1XMgUoHiVOpKsmr5KIbaXJ7WLPDDT jOxKy5Bf1XHHMcBGjXLchiSqK0v2H6mGXdvI0lAuem7EPTuifikODrEjy2IRpj7eYn49gQn mnFWTUqp9pSBjnaut3swfqPEWOsYwVMUQousylR4DRYeoppEgnmd3XxaZ6v7Ci7JFDnyrJW 6kjWmLkIgslr0OG2dkHnQaUhdBz9m0kr2VQIQ/lajjjqyaBsZbt2frHN5bG62kA/hWSxcgt UzudcYiW/O7Dnrm/Hnud7r+m4LwL3htdE+zVVhRWdQDn8XcsY56E13wb4EuA== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 28D8268FD51; Wed, 12 Nov 2025 06:23:11 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1762921376; b=TSfuLxKxzjAH5ibx07tBS1t08BDJhx7XEVdTBDCy3cL7NxfptGRN72duVmdwT0pSiCOjN 7KxOCmJZjfis9HdpUVDe9liPnYoi+6B0OS1eaDP3xL4xoq7Oyb+9Z6oDjZ0jiZm3FucirXv WDNEEw3SV8E0PYg+okZd+0J08+6jY1ulLDSKfDMQB7MfsYJNSolnM3o9nr+68NeOlmy7R1M aG+mSZk5Jdk7uhpYtuK45aH58iQI9Y0MsSWZWkMdq+UdCKlyO+plCEOzx7c/KPKHm8CZIFV shMsh48Qbj3tlTEn/JosuGRPBQSURXBseUcEELQWpDSqLYNPAMlW+tYOuiYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1762921376; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=vIV+8HU59wv+DkG+oibKtO3faplGasT2H4Sp3BfgMzk=; b=qzBluJSJkGYFQfeYMVMyHFo1vWPDy733Fs3D46W6iGOanBAgrrPF+84vmsn13qYle4vZ/ bblbIo49JlyErWa6pkhefm7nTco523gMGidtE0DMqzzT1DVrvxfT9ol+jyZ/XEX/Lfs7u2j w3maRQg2vnJsBf3o+ILeR7teDIzPskW8yr3uSfneaC0uTrv+ZTuNTCBBmFPByW+PYkqTTxq 0LKctclMWIwNJiSabvHcLiDdakDhUxB4eECcPVlwb+i2MaO9eCnc3NYspixUPOj8irxHlpn SMcv6PY9Bt0VNmSe22ov7loDPwNQ3yLncRXka59JG3z05+ATM9WCiqLL6uxg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762921368; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=onI4Wt0W5VBTGJXuM28aaT1Nyp74UBT8lMQxadnpKHc=; b=APIzc0FL44pFDZqzTQNbRXjtXRyfpMI0ra7NOMhuset/7aZF99BYDbYanE2vjz/ZH3dUl ZI8eLJrQK6zxDQ/sQIa7aTIkwFYFleA8xV/bJadVDdK85+1aQDvylma7H1KbwNsr2R1SWBG sA29NADaoKD1DsfzSkJZwIZffZnFiXft/PBfOIXOIcFxdIWWx19UBTDOQdCttXnxXTbkunm Pw9M9EkVZwTDi2sAiLNyQD+yuNQWcu8J84M5Ne3sUZR2GANKDXRNEYkoHCCMs7lPWoj1nEP BrMxpqyzt94JHkNwySk/FiPgcRrhOMuNe/OxXjBbr5Crf1Nsk6FYJlfa3Irg== Received: from 188d6d40ca7a (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 298AF68FCE5 for ; Wed, 12 Nov 2025 06:22:48 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 12 Nov 2025 04:22:47 -0000 Message-ID: <176292136828.25.16859164984409181479@2cb04c0e5124> Message-ID-Hash: HZN55C4ORVLTM7VENODKQOPT45EOYPZK X-Message-ID-Hash: HZN55C4ORVLTM7VENODKQOPT45EOYPZK X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/gifenc: avoid redundant local color table when global palette is used (PR #20897) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: damitha via ffmpeg-devel Cc: damitha Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20897 opened by damitha URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20897 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20897.patch Addressing the fact that first frame has a LCT when global palette is used for pal8. issue: [#20896](https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/20896) >>From 66ba0e8c08668f1796469058024db4cd182289ec Mon Sep 17 00:00:00 2001 From: Damitha Gunawardena Date: Wed, 12 Nov 2025 15:12:07 +1100 Subject: [PATCH] avcodec/gifenc: avoid redundant local color table when global palette is used Addressing the fact that first frame has a LCT when global pallette is used for pal8. issue: #20896 --- libavcodec/gif.c | 2 ++ tests/ref/fate/gifenc-pal8 | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index c11cad8d38..132ce07e6c 100644 --- a/libavcodec/gif.c +++ b/libavcodec/gif.c @@ -492,6 +492,8 @@ static int gif_encode_frame(AVCodecContext *avctx, AVPacket *pkt, memcpy(s->palette, palette, AVPALETTE_SIZE); s->transparent_index = get_palette_transparency_index(palette); s->palette_loaded = 1; + if (s->use_global_palette) + palette = NULL; } else if (!memcmp(s->palette, palette, AVPALETTE_SIZE)) { palette = NULL; } diff --git a/tests/ref/fate/gifenc-pal8 b/tests/ref/fate/gifenc-pal8 index 1a074b8fd8..d4a42b03b2 100644 --- a/tests/ref/fate/gifenc-pal8 +++ b/tests/ref/fate/gifenc-pal8 @@ -3,7 +3,7 @@ #codec_id 0: gif #dimensions 0: 217x217 #sar 0: 0/1 -0, 0, 0, 1, 2109, 0x39642b3d +0, 0, 0, 1, 1341, 0xe4e2af18 0, 1, 1, 1, 236, 0x332769fd, F=0x0 0, 2, 2, 1, 186, 0x770d5061, F=0x0 0, 3, 3, 1, 208, 0x55784c8f, F=0x0 -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org