From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 89F6C4BE5A for ; Sun, 2 Nov 2025 21:25:11 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'2RCdT1aSu7P8enUT3mjfVVovY+E95H+CuEH58OzHw+Y=', expected b'00zEmVfX51/TUVmn0PFUe8ceG+iZ0grUCpfyAfbNUvo=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762118704; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=2RCdT1aSu7P8enUT3mjfVVovY+E95H+CuEH58OzHw+Y=; b=4ZwXd7nnU852dQOiMmem+Lhrc6hS02cULrHNop7D0LjZFYwcOpVA8DgA56RDnjxreQ1MJ dA+tvdFmP6tecNiK6KFd5ZWz1yKdHdlS1EWSkyogQ6JsY0x7MBSxi720yg9uJyDP9QxkSjH lLJicckHld5qYhGYGI4UGf3z9xEx/hYrAf3b/0aQ8uVktMa04Wl4RTG/rbALpyiL5eAIXr0 ELBAeJUdw6o038zfaGIFfxMONpKCUcKf+LZha9d4hMInRFguuZFFNUzfB2iyb4yLE1DTpNX tXdOSHotMy+lLft8ONatWOqSJUlJL5VKwiV96QvNuIsxzRjmKaXHHwTK98PQ== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 46B0868F8E3; Sun, 2 Nov 2025 23:25:04 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1762118688; b=B1nJbR2e/5Thl3W+XHC179haOfT1DVHi95MV9JEdVm578UYUjylDYndpauxxDnUI1h6JJ eZGH5ePxrcmEI3jYLIkHuGcTPYfXeo4IFvj2BFEt7zcEplwBLZu0Y58OEmvIvl3oeLjD5AD T4VkxFGCYOO2j5XH8p4BsE5WaMoManc7Vhctynt3BeUyujIRTQk3lHIDZvshkcZ9OjVxyQK kssmAwyyGWxk+47jy7DZYcJ57DuS+xZ5tBZiDYZ5QKrw90YXKAkrP6vRMmnhyQCvM7fcScB eIri3IZaLCot8sZlb3ljRCU6CWucri794JumZv9Waosp6gkP9QVJDQQitKqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1762118688; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=DpEbx12+CG7TtWnwuQgthPMOSLD/u7oCt+Up6bZYZsQ=; b=rrbg1/HLXYeUY5wCU4ya5SY1B0TsAnF/yRtzSaROpct15hKad8Ono9k1yrevAsbe2Ejkf fDX6OFxXh/ia6HDTp1/4RtJhonYeThup/yQ3SucTPOmKe+hjKQqjzjRmlhSL3LCbD+rf5iA /A1NqkSNV8NV1Z1smqjF44wrNya2BbQuWrqTiDnSwA7i5GCISq5715UetWO1mdyEj4qfLzk d55cT1Vka2Q+kKmbtWDpojuAvxeyJ4wagakVoM9aZfQ1/sHdrXMqFFQvrAsFXxrRyA6k2bk R4iy5v0IgjidqAsz+9S1bUVaSURuNlqG4AB/kAj4/S7CUM4uBXvwV5kEM4bA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1762118680; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=00zEmVfX51/TUVmn0PFUe8ceG+iZ0grUCpfyAfbNUvo=; b=RBUid+iAxRHuvu1Ajf49tUHS7s6zk58zfZkViRcX51pjegn4hMwB0aS2NPeKKc3lxrK2c 71anK9VoDd65YISxNsL8EGxKAu64/4KA+o1OcO5NG4CFU9pde3a3nyrSQqXQl9uQSWHTLXW e0hZwzMyALSKDfMvYv7rDQjV72/9zyvGfvVvdE0aupbvV6kz89y2JsCQkQBLf8+UU61Zer0 fSgujx2bHA0iGOUR/CWGqGD6UXAN+dRHjvwkiSHpAUUDGszZmKU7iIrCHRhcLG008c/E4WK 9lGrhCL1hPLOmO9eU8oCVJjN0r1a1r4csPp68RhVVRac9JTCz9MkzrLdh/XA== Received: from 02c22a36bd31 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0C1BB68F8C4 for ; Sun, 2 Nov 2025 23:24:40 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Sun, 02 Nov 2025 21:24:39 -0000 Message-ID: <176211868017.25.6189078689818336239@2cb04c0e5124> Message-ID-Hash: JJGFBDKXULVKWV63BMSAKBQ3AXLC6GTG X-Message-ID-Hash: JJGFBDKXULVKWV63BMSAKBQ3AXLC6GTG X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/exr: use tile dimensions in pxr24 UINT case (PR #20821) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: michaelni via ffmpeg-devel Cc: michaelni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20821 opened by michaelni URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20821 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20821.patch update the switch statement for EXR_UINT in pxr24_uncompress to correctly use the tile width td->xsize instead of using the full window width s->xdelta. s->delta is larger than td->xsize which lead to two buffer overflows when interacting with the ptr variable in the same switch statement. Fixes: out of bounds read and write Found-by: veygax's insomnia network (INSOMNIA-1) Signed-off-by: veygax >>From 60657f201e11532457863a9ce90b2198937fb96c Mon Sep 17 00:00:00 2001 From: veygax Date: Sun, 2 Nov 2025 02:35:40 +0000 Subject: [PATCH] avcodec/exr: use tile dimensions in pxr24 UINT case update the switch statement for EXR_UINT in pxr24_uncompress to correctly use the tile width td->xsize instead of using the full window width s->xdelta. s->delta is larger than td->xsize which lead to two buffer overflows when interacting with the ptr variable in the same switch statement. Fixes: out of bounds read and write Found-by: veygax's insomnia network (INSOMNIA-1) Signed-off-by: veygax --- libavcodec/exr.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index c83325aa52..733ad76316 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -745,12 +745,12 @@ static int pxr24_uncompress(const EXRContext *s, const uint8_t *src, break; case EXR_UINT: ptr[0] = in; - ptr[1] = ptr[0] + s->xdelta; - ptr[2] = ptr[1] + s->xdelta; - ptr[3] = ptr[2] + s->xdelta; - in = ptr[3] + s->xdelta; + ptr[1] = ptr[0] + td->xsize; + ptr[2] = ptr[1] + td->xsize; + ptr[3] = ptr[2] + td->xsize; + in = ptr[3] + td->xsize; - for (j = 0; j < s->xdelta; ++j) { + for (j = 0; j < td->xsize; ++j) { uint32_t diff = ((uint32_t)*(ptr[0]++) << 24) | (*(ptr[1]++) << 16) | (*(ptr[2]++) << 8 ) | -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org