[FFmpeg-devel] [PATCH] avformat/http: Fix off by 1 error (PR #20804)

[michaelni via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

PR #20804 opened by michaelni
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20804
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20804.patch

Fixes: out of array access
Fixes: zeropath/off-by-one-one-byte

Found-by: Joshua Rogers <joshua@joshua.hu>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>


>From 6f8c0708d86ff376ee1bfc2be811579e58a44491 Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <michael@niedermayer.cc>
Date: Fri, 31 Oct 2025 17:32:56 +0100
Subject: [PATCH] avformat/http: Fix off by 1 error

Fixes: out of array access
Fixes: zeropath/off-by-one-one-byte

Found-by: Joshua Rogers <joshua@joshua.hu>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/http.c b/libavformat/http.c
index 49d750b512..c4e6292a95 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -1875,7 +1875,7 @@ static int store_icy(URLContext *h, int size)
             ret = http_read_stream_all(h, data, len);
             if (ret < 0)
                 return ret;
-            data[len + 1] = 0;
+            data[len] = 0;
             if ((ret = av_opt_set(s, "icy_metadata_packet", data, 0)) < 0)
                 return ret;
             update_metadata(h, data);
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org