From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 920664C9C8 for ; Mon, 27 Oct 2025 18:03:55 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'bHwAhgg8pR3s5y2OpRinbX2DYGEFSTMEU6X0UKYDVQM=', expected b'Qf1WQC89lFBlHS67tWLPizhtW3r2e617o/M294w8U34=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1761588227; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=bHwAhgg8pR3s5y2OpRinbX2DYGEFSTMEU6X0UKYDVQM=; b=m3MZ2z5oQyI8jXe/2h71LHztdZL3XdWpBy7UjPw8J7DTOStOY6O5fkG0imdlcpq9g25o6 6mQ0GgXPWAtnRor/JEADney+2fbPnqfr0nRuzb3YqYQlWqWPgL+LBXHQKiCjyJEKONMS5eg GSYI1XkRtxaW8JlvbU9uS5qTFrzmsme8yWiPtK9dXQx/q10Qzzj1Spib1+yOV5ClaNJHBy5 bqh1Z8cYkZiVsUFiVI1HDEdmUdCPripptW/SZW5HUeM2aMYCXYX8xNLyTR4EFqpW2NtgkA/ 1m9MLhhmhoEZ4EHVe6D66PMzUB3orQtyLzNjqsJoZ+GOuic4zHd8TaJw3PJw== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4F80268F730; Mon, 27 Oct 2025 20:03:47 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1761588212; b=AxlE3i0NkzioAfNCtR9T6RthDN3b9dUEYyc5Po6xcuhz6rStDMCAdoxwb+RjOcPCxoa4o PuR0sMx0/9s9gjiK7wingoZ3KY+v7YzJLXpzHei+d2DqymekkRSAByYOMPoT9LG/99bHPCO MPhjR4C21VtEyUsNEg3lYiKjIK0AG0AT05g7ZG40B7zEtJC7g+Jc85CfDKkXSo+h+S7bSg+ 0LPQurQZRUJS6ore5WzPFGXMgvy/5kA9B6a9h4759R3TGW3S/Z16thcLL6NIo/mbaEGpqFO H++ZBh8rxYypFpj1JsYbCYKKSzcjJlVHACaoeY0VFMIl7vNhQGGMAo8a4P/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1761588212; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=8geyHodSouVeC2LWOhdrZqvXVaGTrV8f3xN7vkdWFNM=; b=G2UpFqYrS/vO0D2eeQ+ND0z9CgIuJ0ysWacSY8oQIV99fu/hNj4/xqwTbAIufteJRK7/s LBTirh0DOK8zRoI+Dm2Zvq8WGINfUOsU7oZVs5Oqqmd7cixHe9I7XuXE+Qque7EL6NFCTvI j4g7FCOz+mijU8H4f526DnVZj7r9HmzgQGMbCCrapqJgpRUKQaNQz6SasQPurFojj1j5tQ6 T4Oa9Ld6i5TuSpZl6XExRC/dBBwRU4Pf6XnoajOMjanKe/MJkskUfHRqsespU/6WbtqG01E hZKaXeHyhBiRnBU/vG7Mb7ioiB3tnr7AVWOtWF0AnHtLn22FQtDR6JwpMDhg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1761588205; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=Qf1WQC89lFBlHS67tWLPizhtW3r2e617o/M294w8U34=; b=YzT6Yq6KIFZjHEkgo6vyydmGHbf3xDNCJcxiOtdE6iBT+JDb3e5+9uMfRwUTTPV4Mf+Yb s6J1/kM9FGZqVti2hkIAz2WqakBwzetUjQ9IbN5WVAXsjcK+d4NEeCrYsxela2Kv+b4+ZEq WdWpwRUMn0aUB3DnEyCfMsCRnLdWKqg4tfdtyCO22vyJV9zZwBEq9pX237V8Sz7l/UoSTCa YIb4XyyzMaMkE7Cs+2cMr7/2DfgJaoYQW7/xuflV/lETPv3Y+3wH4IPY4UBa7IdmfcOkhDB ivYy1xt53pXqagupoi32W1f8+Y8Yl7s7BD873fJjSX0d0zNDGpA0uCgfA0lQ== Received: from 02c22a36bd31 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 04AC268F714 for ; Mon, 27 Oct 2025 20:03:24 +0200 (EET) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Mon, 27 Oct 2025 18:03:24 -0000 Message-ID: <176158820515.81.5552662637264189436@7d278768979e> Message-ID-Hash: WYUPCNTBS67JOOQMPORWQTZNP2DWU5GJ X-Message-ID-Hash: WYUPCNTBS67JOOQMPORWQTZNP2DWU5GJ X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] master (PR #20769) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: death via ffmpeg-devel Cc: death Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20769 opened by death URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20769 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20769.patch Remove dependency on dead code elimination + use correct cflags for debug build in MSVC See https://code.ffmpeg.org/FFmpeg/FFmpeg/issues/20763 >>From 3150ac96e2437164fb3adcdbbc6bf118a6abd5e4 Mon Sep 17 00:00:00 2001 From: Piotr Pawlowski Date: Mon, 27 Oct 2025 18:40:20 +0100 Subject: [PATCH 1/2] avcodec: Fix dependency on compiler performing dead code elimination --- libavcodec/avcodec.c | 5 +++-- libavcodec/encode.c | 18 +++++++++++------- libavcodec/x86/idctdsp_init.c | 9 ++++++--- libavcodec/x86/mlpdsp_init.c | 6 ++++-- 4 files changed, 24 insertions(+), 14 deletions(-) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c index 0355b7c338..6ef506a4fc 100644 --- a/libavcodec/avcodec.c +++ b/libavcodec/avcodec.c @@ -438,10 +438,11 @@ av_cold void ff_codec_close(AVCodecContext *avctx) if (avcodec_is_open(avctx)) { AVCodecInternal *avci = avctx->internal; - if (CONFIG_FRAME_THREAD_ENCODER && - avci->frame_thread_encoder && avctx->thread_count > 1) { +#if CONFIG_FRAME_THREAD_ENCODER + if (avci->frame_thread_encoder && avctx->thread_count > 1) { ff_frame_thread_encoder_free(avctx); } +#endif if (HAVE_THREADS && avci->thread_ctx) ff_thread_free(avctx); if (avci->needs_close && ffcodec(avctx->codec)->close) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 1eca5e38c1..060e63a3d5 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -316,12 +316,16 @@ static int encode_simple_internal(AVCodecContext *avctx, AVPacket *avpkt) av_assert0(codec->cb_type == FF_CODEC_CB_TYPE_ENCODE); - if (CONFIG_FRAME_THREAD_ENCODER && avci->frame_thread_encoder) +#if CONFIG_FRAME_THREAD_ENCODER + if (avci->frame_thread_encoder) { /* This will unref frame. */ ret = ff_thread_video_encode_frame(avctx, avpkt, frame, &got_packet); - else { + } else { ret = ff_encode_encode_cb(avctx, avpkt, frame, &got_packet); } +#else + ret = ff_encode_encode_cb(avctx, avpkt, frame, &got_packet); +#endif if (avci->draining && !got_packet) avci->draining_done = 1; @@ -824,11 +828,11 @@ int ff_encode_preinit(AVCodecContext *avctx) memcpy(sd_packet->data, sd_frame->data, sd_frame->size); } - if (CONFIG_FRAME_THREAD_ENCODER) { - ret = ff_frame_thread_encoder_init(avctx); - if (ret < 0) - return ret; - } +#if CONFIG_FRAME_THREAD_ENCODER + ret = ff_frame_thread_encoder_init(avctx); + if (ret < 0) + return ret; +#endif return 0; } diff --git a/libavcodec/x86/idctdsp_init.c b/libavcodec/x86/idctdsp_init.c index 2d165b975b..d58056ef29 100644 --- a/libavcodec/x86/idctdsp_init.c +++ b/libavcodec/x86/idctdsp_init.c @@ -94,8 +94,8 @@ av_cold void ff_idctdsp_init_x86(IDCTDSPContext *c, AVCodecContext *avctx, } #endif - if (ARCH_X86_64 && - !high_bit_depth && +#if ARCH_X86_64 + if (!high_bit_depth && avctx->lowres == 0 && (avctx->idct_algo == FF_IDCT_AUTO || avctx->idct_algo == FF_IDCT_SIMPLEAUTO || @@ -106,9 +106,11 @@ av_cold void ff_idctdsp_init_x86(IDCTDSPContext *c, AVCodecContext *avctx, c->idct_add = ff_simple_idct8_add_sse2; c->perm_type = FF_IDCT_PERM_TRANSPOSE; } +#endif } - if (ARCH_X86_64 && avctx->lowres == 0) { +#if ARCH_X86_64 + if (avctx->lowres == 0) { if (EXTERNAL_AVX(cpu_flags) && !high_bit_depth && (avctx->idct_algo == FF_IDCT_AUTO || @@ -158,4 +160,5 @@ av_cold void ff_idctdsp_init_x86(IDCTDSPContext *c, AVCodecContext *avctx, } } } +#endif } diff --git a/libavcodec/x86/mlpdsp_init.c b/libavcodec/x86/mlpdsp_init.c index 950f996832..21a0e38143 100644 --- a/libavcodec/x86/mlpdsp_init.c +++ b/libavcodec/x86/mlpdsp_init.c @@ -200,8 +200,10 @@ av_cold void ff_mlpdsp_init_x86(MLPDSPContext *c) if (INLINE_MMX(cpu_flags)) c->mlp_filter_channel = mlp_filter_channel_x86; #endif - if (ARCH_X86_64 && EXTERNAL_SSE4(cpu_flags)) +#if ARCH_X86_64 + if (EXTERNAL_SSE4(cpu_flags)) c->mlp_rematrix_channel = ff_mlp_rematrix_channel_sse4; - if (ARCH_X86_64 && EXTERNAL_AVX2_FAST(cpu_flags) && cpu_flags & AV_CPU_FLAG_BMI2) + if (EXTERNAL_AVX2_FAST(cpu_flags) && cpu_flags & AV_CPU_FLAG_BMI2) c->mlp_rematrix_channel = ff_mlp_rematrix_channel_avx2_bmi2; +#endif // ARCH_X86_64 } -- 2.49.1 >>From 8b38b61a5764f0903cec6db8931dd431b14c3976 Mon Sep 17 00:00:00 2001 From: Piotr Pawlowski Date: Mon, 27 Oct 2025 18:40:55 +0100 Subject: [PATCH 2/2] configure: Use -Od for debug build in MSVC --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3b132d07c9..62bcc30ef8 100755 --- a/configure +++ b/configure @@ -5263,7 +5263,7 @@ probe_cc(){ _DEPCXXFLAGS='$(CXXFLAGS)' _cflags_speed="-O2" _cflags_size="-O1" - _cflags_noopt="-O1" + _cflags_noopt="-Od" if $_cc -nologo- 2>&1 | grep -q Linker; then _ld_o='-out:$@' _flags_filter=msvc_flags_link -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org