Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: mkver via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: mkver <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH] avcodec/proresdec: Remove unused hwaccel_last_picture_private (PR #20753)
Date: Sat, 25 Oct 2025 20:40:41 -0000
Message-ID: <176142484212.25.2997517567846384313@7d278768979e> (raw)

PR #20753 opened by mkver
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20753
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20753.patch

ProRes is an intra-only codec.

Copied from FFV1?


>From d01608e0222a04b5743446f200284d486524b355 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Sat, 25 Oct 2025 22:27:36 +0200
Subject: [PATCH] avcodec/proresdec: Remove unused hwaccel_last_picture_private

ProRes is an intra-only codec.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/proresdec.c | 6 ++----
 libavcodec/proresdec.h | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/libavcodec/proresdec.c b/libavcodec/proresdec.c
index 814074f9d7..40c15a0c85 100644
--- a/libavcodec/proresdec.c
+++ b/libavcodec/proresdec.c
@@ -788,8 +788,7 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *frame,
     if ((ret = ff_thread_get_buffer(avctx, frame, 0)) < 0)
         return ret;
 
-    av_refstruct_unref(&ctx->hwaccel_last_picture_private);
-    FFSWAP(void *, ctx->hwaccel_picture_private, ctx->hwaccel_last_picture_private);
+    av_refstruct_unref(&ctx->hwaccel_picture_private);
 
     if ((ret = ff_hwaccel_frame_priv_alloc(avctx, &ctx->hwaccel_picture_private)) < 0)
         return ret;
@@ -832,7 +831,7 @@ static int decode_frame(AVCodecContext *avctx, AVFrame *frame,
         goto decode_picture;
     }
 
-    av_refstruct_unref(&ctx->hwaccel_last_picture_private);
+    av_refstruct_unref(&ctx->hwaccel_picture_private);
 
     *got_frame      = 1;
 
@@ -845,7 +844,6 @@ static av_cold int decode_close(AVCodecContext *avctx)
 
     av_freep(&ctx->slices);
     av_refstruct_unref(&ctx->hwaccel_picture_private);
-    av_refstruct_unref(&ctx->hwaccel_last_picture_private);
 
     return 0;
 }
diff --git a/libavcodec/proresdec.h b/libavcodec/proresdec.h
index d33eab149b..965fc85b7a 100644
--- a/libavcodec/proresdec.h
+++ b/libavcodec/proresdec.h
@@ -44,7 +44,7 @@ typedef struct {
     BlockDSPContext bdsp;
     ProresDSPContext prodsp;
     AVFrame *frame;
-    void *hwaccel_picture_private, *hwaccel_last_picture_private;
+    void *hwaccel_picture_private;
     int frame_type;              ///< 0 = progressive, 1 = tff, 2 = bff
     uint8_t qmat_luma[64];
     uint8_t qmat_chroma[64];
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2025-10-25 20:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176142484212.25.2997517567846384313@7d278768979e \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git