From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 263494B3F9 for ; Fri, 24 Oct 2025 08:34:25 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'zY7vHHyNjwhdHAcZn/WFMTkBv2kC5M8HcagLpbGhVgE=', expected b'c+/HCobATLCG3XNget3RhLZvE0BFz2aWxbwMRPsl4tE=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1761294849; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=zY7vHHyNjwhdHAcZn/WFMTkBv2kC5M8HcagLpbGhVgE=; b=Vmym4gEXkxkw5qEc1jdBL/HOhDtwwHIiDr8kLoTBCETK5Vkvt8AcJJT4wqRXE93yth+sI In4FDVm1lU4hN7ZNmWKK6i4D4Pp6wOcFzlLz08C6eGNXFqPhtO5Duks4PxNZLdIktHGmil0 edAtzHHapFz4VKMyGH110gSOgItkvR+F0IPLJ79jBFu870NPKL8tc2gGmeCr52CCfC19obo 5l6GQLfcKnwv3CYg2RGrzTj/I4RtRjLugWacZv8glJren85AC296rU7TIyhXu6IYHuvYSmh L+zgvYZqlGW9O8DW9qAW1k2mC4NoPltIeHEhLAbec4Wmvla49i48d3cyG/iQ== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BB58D68F50E; Fri, 24 Oct 2025 11:34:09 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1761294847; b=PvkyiJpcOxeSZbKPC5ENYY6wFs2nSLRk/HAcZpzml5O6Cz05gouoBsKZuOm0Nv7UnJpJp B7usb5LDzLISI3UQ8FnQpo2okAaPJ40mZCxagqrVZkO2skAwkdukuBr6EczejDyU6XfNb8X pu2mg4R5yyi56h4V+2kRvYijvBBzUxoCY//FyzsP56sZl2d4jkTvKREBI+2dQy3ZXrpb4Or 2dFJUefupJm90AnI6haB/t0sf0qNK7BBoqwtdNz5ixSGv29wlH1r8pQaxg0AOP8rWClDm/B /yjhjT2WK2um51IsZW9fqW/Zt9fFYbuCtbCNNcXFO3k0M1W2zRbSlVUIb/hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1761294847; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=6v1n6VbOR5QVuecLwoyUhl+DuuH7McB5O2144T9LtHc=; b=LcqnG0/YrimhKNMPXSWqfJQfqVZqOukn0AXMdVaml9SN+muFKxntZTW/vOQs5LV/ahBKj InhU8yUVLDvspoJXQcEuD0qiOFIG4uKcz4BIl9Fs/btC4fsgLYpnSuHLLWUKEHsWrbI4PTV 3DwVqTe4EKB7XDmokoum1gW5kK7sFB+je+CxZsay0Ra9TcwrfGc0XFdvgVMvS5+B9mP+ng9 xmdxVW9uyEgCiSfiRnG1vSErVyK497KKYu5k40e8SetlR82wmLGOXLXmcGWP3dMqs6s5rMa mBkvhInrv0MvWYcNDytTwQgvQ2Cb45U3ND1cXYgC81jrg/hDzISZP88nF0vw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1761294840; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=c+/HCobATLCG3XNget3RhLZvE0BFz2aWxbwMRPsl4tE=; b=IEx3Zyk19FdS1asvCGLTWffZYSCOz1aPA9kUlYYQdGbIapwYQHKD2f2BsLiqCH/7nANmn KbI5jvxbAjzpB+K0JhEA/l/tqH1GOJtkG0iHWt4SpCvW1jlAMX5oq+TMhsjkfIVtN1yw+74 w1GDs3EZ5tbNIMKLY/UbgH/lC0tJc8Z02oMk/GEbcsQ999Yt054b580+A4QQmXQg4hkKSr9 t5lbt+RdW2/Zkf0ntqQhVcL/c7F8GG0U26e4pXHZucmdv+4FwC7lpagD6k7mEJ41e6TBOaH +g8nNjmswWYvY5vLIOLJXvGKmONXCZmEED1nKNQ153pKpt6JrwTYLEUKwXGA== Received: from 547bf0a948a1 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id EB51268F4B4 for ; Fri, 24 Oct 2025 11:33:59 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 24 Oct 2025 08:33:59 -0000 Message-ID: <176129484013.25.3819016533711931821@7d278768979e> Message-ID-Hash: SL4EF26F5FO7SIKO6VM3CHP25BG4NU2E X-Message-ID-Hash: SL4EF26F5FO7SIKO6VM3CHP25BG4NU2E X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] lavc/aarch64: Fix addp overflow in ff_pred16x16_plane_neon_10 (PR #20744) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: pengbin via ffmpeg-devel Cc: pengbin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20744 opened by pengbin URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20744 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20744.patch The mismatch between neon and C functions can be reproduced using the following bitstream and command line on aarch64 devices. wget https://streams.videolan.org/ffmpeg/incoming/replay_intra_pred_16x16.h264 ./ffmpeg -cpuflags 0 -threads 1 -i replay_intra_pred_16x16.h264 -f framemd5 -y md5_ref ./ffmpeg -threads 1 -i replay_intra_pred_16x16.h264 -f framemd5 -y md5_neon Signed-off-by: Bin Peng >>From 10a5e0c71ca498b978c216d141750257541d60e0 Mon Sep 17 00:00:00 2001 From: Bin Peng Date: Fri, 24 Oct 2025 15:58:08 +0800 Subject: [PATCH] lavc/aarch64: Fix addp overflow in ff_pred16x16_plane_neon_10 The mismatch between neon and C functions can be reproduced using the following bitstream and command line on aarch64 devices. wget https://streams.videolan.org/ffmpeg/incoming/replay_intra_pred_16x16.h264 ./ffmpeg -cpuflags 0 -threads 1 -i replay_intra_pred_16x16.h264 -f framemd5 -y md5_ref ./ffmpeg -threads 1 -i replay_intra_pred_16x16.h264 -f framemd5 -y md5_neon Signed-off-by: Bin Peng --- libavcodec/aarch64/h264pred_neon.S | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/aarch64/h264pred_neon.S b/libavcodec/aarch64/h264pred_neon.S index d0999938ef..795d2ce540 100644 --- a/libavcodec/aarch64/h264pred_neon.S +++ b/libavcodec/aarch64/h264pred_neon.S @@ -489,10 +489,10 @@ function ff_pred16x16_plane_neon_10, export=1 mul v2.8h, v2.8h, v0.8h mul v3.8h, v3.8h, v0.8h addp v2.8h, v2.8h, v3.8h - addp v2.8h, v2.8h, v2.8h - addp v2.4h, v2.4h, v2.4h - sshll v3.4s, v2.4h, #2 - saddw v2.4s, v3.4s, v2.4h + saddlp v2.4s, v2.8h + addp v2.4s, v2.4s, v2.4s + shl v3.4s, v2.4s, #2 + add v2.4s, v3.4s, v2.4s rshrn v4.4h, v2.4s, #6 trn2 v5.4h, v4.4h, v4.4h add v2.4h, v4.4h, v5.4h @@ -506,14 +506,13 @@ function ff_pred16x16_plane_neon_10, export=1 sxtl v6.4s, v5.4h // c mov v0.h[0], wzr - mul v0.8h, v0.8h, v4.h[0] dup v16.4s, v2.s[0] dup v17.4s, v2.s[0] dup v2.8h, v4.h[0] // b dup v3.4s, v6.s[0] // c sshll v2.4s, v2.4h, #3 // b * 8 - saddw v16.4s, v16.4s, v0.4h - saddw2 v17.4s, v17.4s, v0.8h + smlal v16.4s, v0.4h, v4.h[0] + smlal2 v17.4s, v0.8h, v4.h[0] sub v3.4s, v3.4s, v2.4s mov w3, #16 -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org