From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 329224A27B for ; Tue, 21 Oct 2025 10:14:58 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'W64IvYTvFgRx2fOxsbd+UcsJB4URNh7qBBMoHcQ31Po=', expected b'2mKc1PZsS6VNomGkZAIm6/T9c8Dv58CfP2wz6fdC/hY=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1761041686; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=W64IvYTvFgRx2fOxsbd+UcsJB4URNh7qBBMoHcQ31Po=; b=tXVEOQPKxubKhQ3OwdJ41GI/L8UTvKGcVVba+dVB5SQeAxIGeXpaZXTSTOSjT0O8TCAuy vQk3Y0otYKJnVbMdLkHkDJgzQS4Yuwjktvm9kh8B13DuSV/v4mBUf84FyIE2O86N+Oo/hV2 M+uYq86PfqrGgOthu6Mf9sLUxfy0DYp3tKwsrH3DNa/VgVjzwsAj+TZZCySwX0VHwZlD91B s9fcEy9vcjYkAshFKz/ZkzBlfClZQ36BNtpidbCQ9+wJ19JqMxbQxYpGpzdWiD3QNhxEAwH 2hMicCaEbSoibbfOJruh5ePy1mePrFCnNBbgSpCO7PwlufclpP5zUTnHVbKA== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6D82568F4D0; Tue, 21 Oct 2025 13:14:46 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1761041683; b=MTC7+oEWFO6QEfvvM2icR0qzZzb9Y1xQ2uJKyK2lMfN2f/CYQbdLXFfrsiD4WBVIR+A7B a+b7+UYHwfZyi8RwxlwPoj/h50zz952cNtcQXfg9MyxaVO8zWkz/Cpz6h5qugsf+RlGO1bV 26afrZ7PiaHnA6m29gcxE4WE1bzTlqqX8rGJ7mTs6/Kn/65+XqvU/h1wdO897iX4E6OOHH0 WxQNJrJdX9G029klcsWJi2wojDpaQ15dlN8HDppUUrbEug+kiXlxhdK/fY+kPjjXKYRTjs2 xTRsQKDQ59G8GTsONdswMRqbQIA+Cme43Qd1YC9v2Q8ILImig9QK6zPo6BZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1761041683; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=jmSByZ0q7FBKVHBe5DSqwMx5jRYNVSA9ulBwVFzTUhE=; b=aodapELcuCcMtGkxqVM5iO12u0Mltkx/4IXZunTpICf0Q1+4V43kLI4e2ESqrIdaIquWR PnAOhAM9A2RIXHeUgAgXn2HdInh0n9xhlKSBanCXcQJYfEBwcrLWfmgxdK2/GMPSdPkzbju YgxV+Rs1zCWP71qei8LejOKBhtrIyXWbYYUmgroN8gVxcymKrLsrOvTfgeQahR1EEDdDqua vAc1BxpMXYu6UKOchuonttRqkgC3KU3QrC6i6ZuNNVdisP5olQxUkZZ6APGvA1J2W0hvwGZ 2EI/femsXGsL5Nx/8nBYIPmwLYuCj56TltMj5eCwLvzu25xvM3FnPQ706xcw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1761041673; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=2mKc1PZsS6VNomGkZAIm6/T9c8Dv58CfP2wz6fdC/hY=; b=Bc3b2qlbxp3libD+/y4TyRtezmrogwWS3+5w7YuLNIoEmrfAYxeLYexUGO+sI88FMzZwj ewUq7gD/sAkDtVTOlMNS2SUTk/IONlIwKl+N1hq06mApsYu8xrKSoF/oj7yHkE2299tZzKP Mnbom9fMJv+xqeAqDJO6eH598ttHylqdP+SIhMxh61wIiejTbdkUZuYNSOsDePzbOiEy3d1 /1ZXuGKLXH//NRihwUfaXLXBJwwrLbpPvsla8533PCWDFLugRdoa7h27UGi3Aqzz+AOzw4f ug03OBK2N2edR8NisD5Zhw/SlpbYq7vFlbs26gqrMCSBQrkmtoStwbVCZUhg== Received: from 547bf0a948a1 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 46D4268F183 for ; Tue, 21 Oct 2025 13:14:33 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Tue, 21 Oct 2025 10:14:32 -0000 Message-ID: <176104167373.25.10604662575085708468@7d278768979e> Message-ID-Hash: B24TA25CB6PM424XYBGKIAQGKP4OYUL6 X-Message-ID-Hash: B24TA25CB6PM424XYBGKIAQGKP4OYUL6 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/x86/mpegvideoencdsp_init: Fix left shift of negative number (PR #20733) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: mkver via ffmpeg-devel Cc: mkver Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20733 opened by mkver URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20733 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20733.patch Uncovered by UBSan when running the mpegvideoencdsp checkasm test. Will apply this tonight unless there are objections. >>From 05b8608c76e76b7d8b4ce5e86e0940244fbb737e Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Tue, 21 Oct 2025 12:11:55 +0200 Subject: [PATCH] avcodec/x86/mpegvideoencdsp_init: Fix left shift of negative number Uncovered by UBSan when running the mpegvideoencdsp checkasm test. Signed-off-by: Andreas Rheinhardt --- libavcodec/x86/mpegvideoencdsp_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/mpegvideoencdsp_init.c b/libavcodec/x86/mpegvideoencdsp_init.c index 3cd16fefbf..bf5b722016 100644 --- a/libavcodec/x86/mpegvideoencdsp_init.c +++ b/libavcodec/x86/mpegvideoencdsp_init.c @@ -42,7 +42,7 @@ static int try_8x8basis_ssse3(const int16_t rem[64], const int16_t weight[64], c x86_reg i=0; av_assert2(FFABS(scale) < MAX_ABS); - scale <<= 16 + SCALE_OFFSET - BASIS_SHIFT + RECON_SHIFT; + scale *= 1 << (16 + SCALE_OFFSET - BASIS_SHIFT + RECON_SHIFT); __asm__ volatile( "pxor %%xmm2, %%xmm2 \n\t" @@ -87,7 +87,7 @@ static void add_8x8basis_ssse3(int16_t rem[64], const int16_t basis[64], int sca x86_reg i=0; if (FFABS(scale) < 1024) { - scale <<= 16 + SCALE_OFFSET - BASIS_SHIFT + RECON_SHIFT; + scale *= 1 << (16 + SCALE_OFFSET - BASIS_SHIFT + RECON_SHIFT); __asm__ volatile( "movd %3, %%xmm2 \n\t" "punpcklwd %%xmm2, %%xmm2 \n\t" -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org