[FFmpeg-devel] [PATCH] ffmpeg: unbreak max_error_rate application (PR #20724)

[Gyan Doshi via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

PR #20724 opened by Gyan Doshi (GyanD)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20724
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20724.patch

The calculation of decode error rate neglected to cast
its operands to float, thus always leading to a value of 0.


>From 85d266c0ec970b2ccf3c1fd521941b1da225ad49 Mon Sep 17 00:00:00 2001
From: Gyan Doshi <ffmpeg@gyani.pro>
Date: Mon, 20 Oct 2025 13:09:15 +0530
Subject: [PATCH] ffmpeg: unbreak max_error_rate application

The calculation of decode error rate neglected to cast
its operands to float, thus always leading to a value of 0.
---
 fftools/ffmpeg_dec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fftools/ffmpeg_dec.c b/fftools/ffmpeg_dec.c
index 66c58c1c3c..2f25265997 100644
--- a/fftools/ffmpeg_dec.c
+++ b/fftools/ffmpeg_dec.c
@@ -1007,7 +1007,7 @@ static int decoder_thread(void *arg)
         ret = 0;
 
         err_rate = (dp->dec.frames_decoded || dp->dec.decode_errors) ?
-                   dp->dec.decode_errors / (dp->dec.frames_decoded + dp->dec.decode_errors) : 0.f;
+                   (float)dp->dec.decode_errors / (dp->dec.frames_decoded + dp->dec.decode_errors) : 0.f;
         if (err_rate > max_error_rate) {
             av_log(dp, AV_LOG_FATAL, "Decode error rate %g exceeds maximum %g\n",
                    err_rate, max_error_rate);
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org