From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 56FC845435 for ; Sun, 19 Oct 2025 21:57:42 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'4FivYeNoPsiV3FOVtiQqjMCNvadrN1kOM+Spb0J00N4=', expected b'oxDpusHB4KuxmoO9NsMZNpd3P6AXeqXnIVRg4P1+quY=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1760911054; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=4FivYeNoPsiV3FOVtiQqjMCNvadrN1kOM+Spb0J00N4=; b=Q3oqU1idC8NB0DHQGSbtg6Shn+vdwZuV2vzIVlcZTXb4MvEoE5LA7RJmbIsHFU22SO8+A /kmF4YNiuxK5r32uZl/iOtU5XEzRj3vilTY4VDxbc3PmIJL8XNuRpxiCXOkrOok5gWPUQOD UlVg3+jIarc0kZ3+qOVasp2g5eDa+7G0sKb+zXv5BxEyPSPS7XayiFmO1nVHt7S71xEQ6z3 vflxTY2UdJN+Wv4W2kZfXfO0Jap8wvNvKXATtqDpEklXmTtRx7ZNYFr+yO/vafwQUVll5X4 TYWIOhN0bN63+vvTx4Wb+Gb9Smj0+9CczNjzR5Pu9kWzoob5ZldKnBoyGsDA== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1FB5C68F48D; Mon, 20 Oct 2025 00:57:34 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1760911038; b=jt60vZmL/0VeI3bdra74DQDMllq3Sh9bWOcniW5nnmEvCPmT9cXs1RVevey7l/tyfOHwG aHCpW60iNVyI0vA1MySYv57JvxdmmCyL67EPzPmlEIN7j3c8oIDs6KFDDXZFdHPrT5DwWWY /0qm8ma0VPBA15nNQWs8+mmzxDGRnYXsqvOXgoIqDxUa4gyYdgHVh/qeqPy6SAkyCETWLYs rVIoDTOub8L/z1yz+Cil0rJoI7ZHrSrFGIvx0c1lGly7Rqp/Hb0z/HHbt3ypxxLrtcR+uJ4 mbtuM4pvoaEIox0u7Rryy8gZKUQ0xTo8rhIAcrEbeveKARAKxyg3F7VyMe1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1760911038; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=pmUa2kIVc03nINZuRUkLmVuT5aIPmu1aY0LxIRVe0C0=; b=sURZYbfdAsh/1bIEfhaFebeq1mWX9zeePW7+WVu194ot0VvZNkOdvYGAUFk3eK2mBceNF NzM5RdI8LDlbBDlWaQjbTlSbua8PI1I7KN2XPfmatiagy2N5rRqW2FMV2dAegydDMi5XFJg Jt2BPJxsfR6IemSo/N2YyZp/0Dgrlv4mXE5FfGvla9SPZz8qpZ2IKlAAamo+1qdrOINaAFg RYhry99/oxlACoDzMHWw/pjXYlJr1f0A8TEJnMT5ldWgsOn57trJFY7lyXAEEMn4U8P1hxn ygGN9COWLoerYihp4zJcmIeCjYVlzJ8APE2z4WD9CZEriOc9XwHE8o9THOcg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1760911032; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=oxDpusHB4KuxmoO9NsMZNpd3P6AXeqXnIVRg4P1+quY=; b=Bn94so8IOavLIh25kgX1a8rargEWqjs0vE+4Wvb7w6QAlb/w4WW0R+L8QbiwXVekKc1KT J2vXnJYwAeXJzN9y9bpTFSOpiqwgWrkk6Z03PhKPvv6t7DC0kSeTQC2598u1EbBKIOWsi9w ctCh04/0X9w+0azZCfoQF+NpK57oYZ7xFvxqIucjGGBJOotZO5IpxspbNTQau+tP6Hjapn+ Nu8T99naMTKPwZi6vQGuh1mc3KWIMopxK/hPnVCzL3/y9Ynyf7W8nMlXMhHzN+e3qzuSAPt VG2Fe6PhPoO+WAZnb/xZnHs1ew+igYcmkfggGduISeIjYCldDJwTvuz8v6Rw== Received: from 547bf0a948a1 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 103D068F22F for ; Mon, 20 Oct 2025 00:57:12 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Sun, 19 Oct 2025 21:57:11 -0000 Message-ID: <176091103219.62.12416663040804767276@bf907ddaa564> Message-ID-Hash: SBCBOYJSMUH2627R3AUUQPTY3CK7YCBC X-Message-ID-Hash: SBCBOYJSMUH2627R3AUUQPTY3CK7YCBC X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/av1dec: fix decoding with pix_fmt set (PR #20720) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: cgutman via ffmpeg-devel Cc: cgutman Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20720 opened by cgutman URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20720 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20720.patch 194414f introduced a regression by skipping the call to ff_get_format() if pix_fmt was already set by the user. In this scenario, critical hwaccel init code in ff_get_format() is never called, which causes ff_thread_get_buffer() to fail. Signed-off-by: Cameron Gutman >>From 9860d4b28cde307b892da817015623233a31d7b1 Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Sun, 19 Oct 2025 16:48:28 -0500 Subject: [PATCH] avcodec/av1dec: fix decoding with pix_fmt set 194414f introduced a regression by skipping the call to ff_get_format() if pix_fmt was already set by the user. In this scenario, critical hwaccel init code in ff_get_format() is never called, which causes ff_thread_get_buffer() to fail. Signed-off-by: Cameron Gutman --- libavcodec/av1dec.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index d4ceb5ef09..29e03e879d 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -656,11 +656,12 @@ static int get_pixel_format(AVCodecContext *avctx) *fmtp++ = pix_fmt; *fmtp = AV_PIX_FMT_NONE; - for (int i = 0; pix_fmts[i] != pix_fmt; i++) - if (pix_fmts[i] == avctx->pix_fmt) { - s->pix_fmt = pix_fmt; - return 1; - } + if (s->pix_fmt != AV_PIX_FMT_NONE) + for (int i = 0; pix_fmts[i] != pix_fmt; i++) + if (pix_fmts[i] == avctx->pix_fmt) { + s->pix_fmt = pix_fmt; + return 1; + } ret = ff_get_format(avctx, pix_fmts); -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org