From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id CB29040022 for ; Wed, 15 Oct 2025 19:48:53 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'ineJcYLFKQ9jD+bgP9gY7tltDFB5q1906UQQubE1ZvM=', expected b'HWdT2uZvFKKFX2QIQYskbzqxXqChFffAXnrvcu8k6l8=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1760557720; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=ineJcYLFKQ9jD+bgP9gY7tltDFB5q1906UQQubE1ZvM=; b=KKw8lIZzZlLn3V9W2sv4syO+FJhUeJceKQyugoG78mO5eIleShAnOMIFyk6dTdk74OncW fNFeRS/MWKM2OU9j1y5xqeATVEeonXjmKMzcNKbaRHdTYVtR39jRw37sud7Oc/PjQwIARJO VuSkyndVx6AQ5DVDdaRRzs91hpQpYon5LpQflWi1qHHuSXFbpE/z7GfXajFHIS1xRDvKeJx UKeKMdOZZHeztrGISTuh4Dt8bHGItz85475km65ZpGjzEQ1CX7Gj1GbrpIfpccOoDPJjGRY /LWm07IhvG5Mn23p0kKrOGiZDx+XmrvE0PqypoyIHSdtZF5AP/O2jxIuPxMw== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6D19068F3AA; Wed, 15 Oct 2025 22:48:40 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1760557717; b=qk7somhFImF8heFAwuDZaSlTUHkZUgJcglffCTQ5m5pdjeYoKnsxZNExsWeNxwxFP+4ub 497d5HzaIBSufNHnuUrWVja7h59j+GUPDkw/NXaRDijby1N9wh2kwH1lzZ5VWA5lLp8N1U8 Bui0fBILq05Ba3UOWQjKdlDe6/vlv6UlcK7z8ufaL0DL16HOhsMzCA2t4uEBPf3vdMSrJk5 GsoQtZPUeg3smaKhXqYYiP9iKvC6rEes1T41v/JCsjFgyLe37yosw/Ufrm/JY9dJLf2lR5L aLanR141Ieyo2UmJ1cJONTQd0UyE3SeWvJftbohXl/LFyy7I8St4zim3MDvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1760557717; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=R9g+zSa1SUJrpGq3w91NPIxibrIdXeTPgy6XaGC7bng=; b=eL6FFq7GomWlRqlCJPxk/Bnn/WqrlAHn1CgOQqrLV/Qi8JUJl3ec//Q5++zGqH5fn1Ujr ITWoK4op93804lDExBizj/u36ExSCkEbgigFzbMBMJZsiqfwQ35U4OKt8p07wugm0fsVwa0 xFTaGiUU5yJk0fF2FuOnrmSObps0SpUWNlpqsXEjKMUKDpL/xztsn4S561C3LidvrXAH/W9 URwO0CxO4ymopwx6U8m/EQ/8G0G1jHfxihxnW/lxN+y/EigOjq11afsGdAnaR83Hp2jB6Eo 3Flfh4oIZfffWAaLTJNVvy+wEH16tVTRbneubJvNE+vDhWV8oED7I2EixIbA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1760557711; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=HWdT2uZvFKKFX2QIQYskbzqxXqChFffAXnrvcu8k6l8=; b=K7qviE+98DQcW7GRdB5Lf0fE2bt6dcj2xo6hSYpwLPwGF9QYWMCwitrR+qnTylZ8hkn68 i4rL6uYKsiMvZUjAEmmo75XzTd0ciPjgOH0U71bmR1gjkQ4xEaQMBlHWSG3JH0iOxuc0wbl G/yb8wmrfIZsZeFrSoTtlENyVP8GU1w0D8Dw73DmpWSaUaLgThwmHzpYVJo4PD38JgO8FiH lT2dqUSiSLfBSSOg3uNYlckMTYr7voPcCRWGydvdcHOAqf7unYaKHfSfJIX8jBOmwKGfPqf E7eN0OFfHrJw3tg8P9p3ss0l/g0qdm78chHBU1gshLn080V38qXjqe881MTQ== Received: from be50bb5a3685 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 520E468F2FB for ; Wed, 15 Oct 2025 22:48:31 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 15 Oct 2025 19:48:30 -0000 Message-ID: <176055771143.25.10044101243981870768@bf907ddaa564> Message-ID-Hash: B7TVEBE2QM3VY23NE7EOVQ2N22PJVOUE X-Message-ID-Hash: B7TVEBE2QM3VY23NE7EOVQ2N22PJVOUE X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] abformat/tee: fixing the default options setting (PR #20710) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Artem Smorodin via ffmpeg-devel Cc: Artem Smorodin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20710 opened by Artem Smorodin (artem.smorodin.dacast) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20710 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20710.patch I found that the default value is not set for `onfail` option. I see that there is an attempt to set this value by default inside `parse_slave_failure_policy_option`. But look at the `CONSUME_OPTION` macro. If `av_dict_get` cannot find this option, then this function is not even called. I mean `if (en) { ` >>From 293a527ada263a9e42cbd0957c362e40b594f1e2 Mon Sep 17 00:00:00 2001 From: Artem Smmorodin Date: Wed, 15 Oct 2025 22:38:57 +0300 Subject: [PATCH] Fixing the default option setting --- libavformat/tee.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/libavformat/tee.c b/libavformat/tee.c index 0bac4fa202..d1dd4e424e 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -152,6 +152,11 @@ static void close_slaves(AVFormatContext *avf) av_freep(&tee->slaves); } +static void set_slave_defaults(TeeSlave *tee_slave) +{ + tee_slave->on_fail = DEFAULT_SLAVE_FAILURE_POLICY; +} + static int open_slave(AVFormatContext *avf, char *slave, TeeSlave *tee_slave) { int ret; @@ -167,6 +172,8 @@ static int open_slave(AVFormatContext *avf, char *slave, TeeSlave *tee_slave) if ((ret = ff_tee_parse_slave_options(avf, slave, &options, &filename)) < 0) return ret; + set_slave_defaults(tee_slave); + #define CONSUME_OPTION(option, field, action) do { \ AVDictionaryEntry *en = av_dict_get(options, option, NULL, 0); \ if (en) { \ -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org