From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 507DB435DA for ; Thu, 17 Nov 2022 02:46:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 39DEC68BA59; Thu, 17 Nov 2022 04:46:16 +0200 (EET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7603A68B862 for ; Thu, 17 Nov 2022 04:46:09 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668653174; x=1700189174; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=pTwUUJDaNlK5hIx+xRYMCcnd4PqC/UkzLEfX+5hGN48=; b=iC4iYoEruxCITKZWdW9e3xGe2HUDpdeFEII7j8ai2EvfwBrq2SWkX3no KvrX0P3Jx9q2mU6RMX7M/lh/MpGgksY/L+oKwYZBQUC5OzZXKM4p95CWv ptdNF0Kbh+TGP7JoWzkZ/B3joZMyIXVFzs/qnhY/Jgy1O6lF4ZzkMfXP3 qKD7R6jFMRRbCDUlpyeccT3d9MrMM839fNXrzBmX1AMABShfaTK3F53CF /xHmx9g84SNlWBrGiqKB7ZwB3UWWbr96sliH/fWJddEFNtNIrUE7TqAUw MnteHlmSX6TiPrVZgu2t6bUOncZFhgpUJayo8YKZ3xSEEkmoRefYuHFT8 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="377002492" X-IronPort-AV: E=Sophos;i="5.96,169,1665471600"; d="scan'208";a="377002492" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 18:46:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="641912624" X-IronPort-AV: E=Sophos;i="5.96,169,1665471600"; d="scan'208";a="641912624" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 16 Nov 2022 18:46:07 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 18:46:07 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 18:46:06 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 16 Nov 2022 18:46:06 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 16 Nov 2022 18:46:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8U3KPbWr7Yl1WssrxyshvgZvcLQd0eVESmN1GCWm6oJvOgFU0pLJo6cuM8/9+gHeJqJt+7rY6K1FswKMYi8agB3bYaYWHY58+1szx47SiUrAXAUD3Q049pVLEMUzclsiwnEzd8RbuyfzLhfDRLgfnOD1XtJA/f170gjyf4VytukW09A87nVuhfRbd/6oc9WaCi7RztjCsx56MPv7N2UfHzrG0HmIy1aHwxVvEc6m1tEC6w3SZehx977iGITBNZirsW5ZTOBwF/HKiuId+8M3fpVvH0QdwFqDkO8N79xY/t/xLml/K8qhN7GUVfIP8gEZNReQMwxC2gq2ZarOTzUaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pTwUUJDaNlK5hIx+xRYMCcnd4PqC/UkzLEfX+5hGN48=; b=RpHLHbQ8VIHQw2g7jhFPAEwwGxyOn0j7kVHadNvI7tmTRFj0MYw78tA/e6Mgvk7GOc6r3ItF0E3aSt0in+umgoR/2b75mV+MT3Sjc0aroZEBWoNvH1vEdjE4gvOImKQZ7yhZXJnsivbLdNming1NXNp6A30wzAU2qyd6RBSjs0PGb9i6pY62XPKER0P23qNiirg0BkGE1F7br35S+rPeS3cNScgigy56AQzwanHnSMUyj3Tkhuhe0wNGxJrUpBy8nCCDNoTdlTmUhJIzBU7ksGavap3rolMtFDJ49/n1AFGpi1sqQIlihG95K6ZFE4Ur3twnyY9KQ/eXrz7XLcZ9uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH0PR11MB5507.namprd11.prod.outlook.com (2603:10b6:610:d6::8) by CY5PR11MB6284.namprd11.prod.outlook.com (2603:10b6:930:20::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Thu, 17 Nov 2022 02:46:04 +0000 Received: from CH0PR11MB5507.namprd11.prod.outlook.com ([fe80::c187:80e2:f9b5:3b62]) by CH0PR11MB5507.namprd11.prod.outlook.com ([fe80::c187:80e2:f9b5:3b62%9]) with mapi id 15.20.5813.018; Thu, 17 Nov 2022 02:46:04 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Disable MFX_GOP_STRICT when encode adpative gop Thread-Index: AQHY+WEZr6IHmQDv3USAvpo9tx3jG65Caq8A Date: Thu, 17 Nov 2022 02:46:04 +0000 Message-ID: <175878c5f7b71f2d916593f1f5c3609f996f00ab.camel@intel.com> References: <20221116021338.502587-1-wenbin.chen@intel.com> In-Reply-To: <20221116021338.502587-1-wenbin.chen@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR11MB5507:EE_|CY5PR11MB6284:EE_ x-ms-office365-filtering-correlation-id: 313f55a1-1a04-419f-e6d3-08dac845ded4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MBosFmdzNzidMSKGmSHV2X/szRs2eYRka5ckHIkWIbfk0uGgFyVbVL46rLDNkodH687LsAGQnex3MHGNog9TMNdPm9cMwTpUKyQKuXnPoZlishy5yRtVMcRJgCXy0kwkP9J4LzFCkoMlQdtNtBy9q4bxrPP66nEr+T2D2+cYs+NtDm4i8QneqUqYs+NG3+8IG+OQIMhcw2Pnv935wTWOrzGMC4JpIO57yTiqSy9lSBsXpDqi5Gv/gZNKxUE83m5jJeriwkzJ5KokIGwG0KZWCm2JsxtbmC9TdSdRTjK46iQLQiKYXk0nYxBbg/890ayAsRFYvuuWh1Ly9I8+/jRTp6xYUosVfW5CnQ01J39c45Jzhr6dhGjbBDCRZcZJIW+UvKf9x4zhBZzLBeHsorzsk75hkJzTI5NQhm8j9eD9+zrOvEp9PmKfYZchQCNyT0MbL7v1RI/pfuFhaabr5Z1XO+bYuq+W+ssPwcYTL67hC1har3/A5U/rBTq2t12rAdn1f6m3r9NH6t6vIJ7KyVxqHnkQnIrPCaksZobvippnbORQBYn67zI5tbmvcij1XXk3PHN7O5tiUT7rRolQj3HUHEk65+YGs6+wE+IYaOPCN3cexFC9JYl7wCVMUGwjqOsEZEzAgSEDAlO/HkHn9jhcwgwystJAQQygrQVWRM9LkQvlgbvOS5nKiqy55/kOn41z4ENekOJ7tha7MCyxqr527GmkM18OZdJuAegO/JeV2OVr6UvoqLZrecb73dzdeGiz30RjGixhO/0rBMKHGgfIng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH0PR11MB5507.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(376002)(39860400002)(136003)(346002)(451199015)(8676002)(5660300002)(86362001)(64756008)(66446008)(76116006)(66476007)(2616005)(36756003)(71200400001)(83380400001)(66556008)(4001150100001)(8936002)(91956017)(66946007)(316002)(2906002)(6916009)(6486002)(82960400001)(38070700005)(478600001)(38100700002)(6512007)(186003)(122000001)(6506007)(41300700001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZXVsZUkrZkVqaXB3c0kvdDk0MzBsZzRrNnJMaHprMzFoUVFYRWtVZy9qSTF0?= =?utf-8?B?Z3V6RjNZbVp2NGNubFU5cHdZOVVNQ1NoM3FoblZjZGdqV1NMS2NUM0owbytm?= =?utf-8?B?a1dIdUdlMHk5elBNdzNxL3FyMlNMNC96N3pBbG1tY29SOVpCa3E4byt6eFhG?= =?utf-8?B?bHBDSjFXRytESjIyUnJFbnJJN2VYaDB4RDlCYnFOT1c4dmFXa3RYU2sxancx?= =?utf-8?B?amJWbFBsMXpUQ2tUN2JpSDh6ZGhyU2ZIY2sxcG9LS0h0V3l3bXZNWGJCczNn?= =?utf-8?B?ck1La0pUa3phM3hDdnlEMVh3Wm5JeVVpS0VpTVRpYmk2Z0FiSGNpb1ZISlNa?= =?utf-8?B?elRhUGM3UDRKNnhBWkdsQ0Z5ekw4S1IzWnM5WnU1TUdKTDdBcXd4bU1Gc3Bo?= =?utf-8?B?YmpRQzFQWStsS0dBRGlxc1NyRU1hamJKMURzL1pPY2hQMEVEN2lJRExrZ0lo?= =?utf-8?B?emhwOXV2ZHFJMWpoeVpOSHZuM01uT1Y1OEh2TU5XdWs0UTZUQVVqQWNNaHdO?= =?utf-8?B?OVYyRXk1WGR1RElRSVVhUDBXaXVpOHhXN2M0WXlPOWlUTk1hNjFQLzJoR0Fs?= =?utf-8?B?NldST1k3VTJDaDVMV3RLL3BTYTMybGFoUy8yVWZUc2NzKzBOcWZzQXBtS09H?= =?utf-8?B?VFZHdHNibVFGN0Y1RzgvMWhFbWgrSEZBeXUxSWpIb0JvMkVLS1ZVc0Y1dmM5?= =?utf-8?B?NXR3SkI4Q0xsTjBrSHBWU2s1Ni9XNTVPNnBDTWx4MWgzTmlnNDRnR25sVWdX?= =?utf-8?B?RDQwaU43VHdCeEZCbUZnQ3ZqeEN1OU1CYlUzYU0xYUtkRVh3emNkS29pcC95?= =?utf-8?B?QkNhcVlvdHp6QTdoc3VCang4V2tLVGpqNGsxTG54dGdmWEY2OXVPZkR5VEc3?= =?utf-8?B?OG5iUWxVZjlzL1dEQ0pOZE9hYXI1M1pBTURvUXdFdTNUUmd4TVNHdTNZSWUx?= =?utf-8?B?RXFtdUExTldRU1JRVHdtS3J3enlkUjhNSGcveHIvSm42MUZDdFBMQ1RTREJJ?= =?utf-8?B?RVNqQ1k4WkFYaXBSdmd3TjJiZ2JVV2lXdkJaVG9aU01VVGtidmlaU00zbUw2?= =?utf-8?B?dndnYnd3b0pOcjIrYTFIaVZna1FSWjFmL1NzM1c1a1FGNmk3VzdMNEJsNnhC?= =?utf-8?B?Rm40NnVaaGovOTQ1ekFoRTUxZ0dPWldOeEVBV28vZGVoVHpkOWt6REdjeWth?= =?utf-8?B?NElVY3dGdU5EYnA1cGlKREtmMlNGSGVia2VUUkkxMk0rSE9oZXhzV3BNTnpM?= =?utf-8?B?SElOZStScFZqM1U3U3V3anZoWXdNUkttWjNoV3RkMjEwakorZnJBTjQ4WG5J?= =?utf-8?B?RklnUWFHaUl6cDFvaFR0cHM2blJGRHpTbnNNRmJTbnRHZHRVaWtVSnBoYnZx?= =?utf-8?B?bHJTTmtPbTIxbVVPNHRuRk1uOVY3WktTSEYya0FTR2VCckhjdnJjZS9JbEVK?= =?utf-8?B?RVhPNVFBUUFhMmR0RVNhWkNJNEg5KzFuUDFscTZaYzA4ODlSSzJETkpmVTZy?= =?utf-8?B?amJCUThLL0tycktOam1VVWxEZGNPZjFUYmNOK05RNGVIdjhveVJ5bVZhNVpp?= =?utf-8?B?dDJzQnQwV3BVRVBKcEpKV0JEMk4wVWtpdmFXTlpvUGNVYkxaZHN4bnBnaUM5?= =?utf-8?B?NkZZc2Z1NzVaMkVYMDhyZmxLVUdxWEZHQUlUalFpbFJnKzF1bVJCWjYzY1F3?= =?utf-8?B?eUROSzJlVjJzK0pmZWJPMGs5ZHRubGtCL3Uyd2pidUF4NUJnU1lLOGsxOHVQ?= =?utf-8?B?N2ZPb21Yc2pPa3A5d1N2dUZPSWNwZjZQay9hNGRvTWQ0eFd6V0xJeC9QZ2Zn?= =?utf-8?B?UTcvZW9zSmxIa3BJWkR1RmlyQStKTW83VzcrWnkxVjhNMU9TZHYzbHNFeVA4?= =?utf-8?B?UjllMTJnQnhsVEV3WkpFaHRWZ1l6VmdBUzl1d3AyNzZFbmZJT2tRSXUxcW9Q?= =?utf-8?B?RlJRWUp0QllBL3hDRkppOTVtMVFmMUpDUUZ1dlZ4dUpxOWpLRGt6OUdsR2lw?= =?utf-8?B?VHhlWGdHVVNURm15UDh0bDUzQWZZRUtGZ2RrTTNUZG85L2t4SENEc0Q1SGJt?= =?utf-8?B?WEd3b3h0OENqQVc5QTNtN2RqcVZQUHdoOUVnTEkyMFhsbGFwR0RJUm04QWlE?= =?utf-8?B?K1F3ZWIwcUsxN3ZUS3I0QzVmSGpXVDNza2o0NStFYWs0S1M2U3VhdzVaL3hi?= =?utf-8?B?Rmc9PQ==?= Content-ID: <01C4979F8F6DE646B99D2E98A899FE6C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5507.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 313f55a1-1a04-419f-e6d3-08dac845ded4 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 02:46:04.2514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W3p/lIl6SXbB9y4ioE2u9YMCwKskPGLf5V4MLg50xh5qrq0ji/h/V5o9uQBeLFOlpTbcRuhfe0ydEVyLd8UfJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6284 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Disable MFX_GOP_STRICT when encode adpative gop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-11-16 at 10:13 +0800, wenbin.chen-at-intel.com@ffmpeg.org wrote: > From: Wenbin Chen > > b_strategy, p_strategy, adaptive_i and adaptive_b cannot work with > MFX_GOP_STRICT, so disable MFX_GOP_STRICT when these features are used. > > Signed-off-by: Wenbin Chen > --- > libavcodec/qsvenc.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c > index d5e9f2d420..6777a6fb5f 100644 > --- a/libavcodec/qsvenc.c > +++ b/libavcodec/qsvenc.c > @@ -644,6 +644,13 @@ static int check_enc_param(AVCodecContext *avctx, > QSVEncContext *q) > return 1; > } > > +static int is_adaptive_gop(QSVEncContext *q) { > + if (q->adaptive_b > 0 || q->adaptive_i > 0 || > + q->b_strategy > 0 || q->p_strategy > 0) > + return 1; > + return 0; > +} > + > static int init_video_param_jpeg(AVCodecContext *avctx, QSVEncContext *q) > { > enum AVPixelFormat sw_format = avctx->pix_fmt == AV_PIX_FMT_QSV ? > @@ -755,7 +762,8 @@ static int init_video_param(AVCodecContext *avctx, > QSVEncContext *q) > q->old_gop_size = avctx->gop_size; > q->param.mfx.GopRefDist = FFMAX(-1, avctx->max_b_frames) + 1; > q->param.mfx.GopOptFlag = avctx->flags & AV_CODEC_FLAG_CLOSED_GOP > ? > - MFX_GOP_CLOSED : MFX_GOP_STRICT; > + MFX_GOP_CLOSED : is_adaptive_gop(q) ? > + 0 : MFX_GOP_STRICT; > q->param.mfx.IdrInterval = q->idr_interval; > q->param.mfx.NumSlice = avctx->slices; > q->param.mfx.NumRefFrame = FFMAX(0, avctx->refs); LGTM, will apply -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".