[FFmpeg-devel] [PATCH] avcodec/x86/apv_dsp: Don't export arrays unnecessarily (PR #20588)

[mkver via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

PR #20588 opened by mkver
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20588
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20588.patch

The const here is unnecessary, because everything inside
SECTION_RODATA is automatically const and using it exports
these objects from the object file because const is a macro
in x86inc.asm.


>From 4d79b5a9f4ec821161f4f5e0a0f8090d6e33820a Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Wed, 24 Sep 2025 00:10:08 +0200
Subject: [PATCH] avcodec/x86/apv_dsp: Don't export arrays unnecessarily

The const here is unnecessary, because everything inside
SECTION_RODATA is automatically const and using it exports
these objects from the object file because const is a macro
in x86inc.asm.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavcodec/x86/apv_dsp.asm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavcodec/x86/apv_dsp.asm b/libavcodec/x86/apv_dsp.asm
index 60e0f03e16..e2f30fff13 100644
--- a/libavcodec/x86/apv_dsp.asm
+++ b/libavcodec/x86/apv_dsp.asm
@@ -23,7 +23,7 @@
 SECTION_RODATA 32
 
 ; Full matrix for row transform.
-const tmatrix_row
+tmatrix_row:
     dw  64,  89,  84,  75,  64,  50,  35,  18
     dw  64, -18, -84,  50,  64, -75, -35,  89
     dw  64,  75,  35, -18, -64, -89, -84, -50
@@ -34,10 +34,10 @@ const tmatrix_row
     dw  64, -89,  84, -75,  64, -50,  35, -18
 
 ; Constant pairs for broadcast in column transform.
-const tmatrix_col_even
+tmatrix_col_even:
     dw  64,  64,  64, -64
     dw  84,  35,  35, -84
-const tmatrix_col_odd
+tmatrix_col_odd:
     dw  89,  75,  50,  18
     dw  75, -18, -89, -50
     dw  50, -89,  18,  75
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org