* [FFmpeg-devel] [PATCH] avformat/flacdec: fix self assign warning (PR #20569)
@ 2025-09-21 16:46 Zhao Zhili via ffmpeg-devel
0 siblings, 0 replies; only message in thread
From: Zhao Zhili via ffmpeg-devel @ 2025-09-21 16:46 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
PR #20569 opened by Zhao Zhili (quink)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20569
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20569.patch
>From 161f9ab8166dc673b226f790a23113a15c6c23a1 Mon Sep 17 00:00:00 2001
From: Zhao Zhili <zhilizhao@tencent.com>
Date: Mon, 22 Sep 2025 00:42:02 +0800
Subject: [PATCH] avformat/flacdec: fix self assign warning
---
libavformat/flacdec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavformat/flacdec.c b/libavformat/flacdec.c
index 347b66d6d7..0ad500be44 100644
--- a/libavformat/flacdec.c
+++ b/libavformat/flacdec.c
@@ -102,9 +102,9 @@ static int flac_read_header(AVFormatContext *s)
return AVERROR(ENOMEM);
}
ret = ffio_read_size(s->pb, buffer, metadata_size);
- if (ret < 0) {
- RETURN_ERROR(ret);
- }
+ if (ret < 0)
+ goto fail;
+
break;
/* skip metadata block for unsupported types */
default:
--
2.49.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-09-21 16:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-21 16:46 [FFmpeg-devel] [PATCH] avformat/flacdec: fix self assign warning (PR #20569) Zhao Zhili via ffmpeg-devel
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git