[FFmpeg-devel] [PATCH] avformat/dhav: Fix off by length of read element error (PR #20559)

[michaelni via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

PR #20559 opened by michaelni
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20559
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20559.patch

Fixes: out of array read
Fixes: BIGSLEEP-445383648
Fixes: crash_input_1/2/3.dhav

Found-by: Google Big Sleep
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>


>From e66d02f3c566e42984ad6862bdcbe2a6796ec2a1 Mon Sep 17 00:00:00 2001
From: Michael Niedermayer <michael@niedermayer.cc>
Date: Sat, 20 Sep 2025 01:25:51 +0200
Subject: [PATCH] avformat/dhav: Fix off by length of read element error

Fixes: out of array read
Fixes: BIGSLEEP-445383648
Fixes: crash_input_1/2/3.dhav

Found-by: Google Big Sleep
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/dhav.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/dhav.c b/libavformat/dhav.c
index 21c9c530d6..105a987aa3 100644
--- a/libavformat/dhav.c
+++ b/libavformat/dhav.c
@@ -279,7 +279,7 @@ static int64_t get_duration(AVFormatContext *s)
         }
     }
 
-    if (pos < buffer_pos || pos + 16 > buffer_pos + buffer_size)
+    if (pos < buffer_pos || pos + 20 > buffer_pos + buffer_size)
         goto fail;
 
     date = AV_RL32(buffer + (pos - buffer_pos) + 16);
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org