From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 0C55B49E87 for ; Fri, 19 Sep 2025 15:55:57 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'tIUdfOMaq8m4u7Sr57Awmfxs22ptyv4XuiP73zPmA9Y=', expected b'Fip5TUVsdOC7MQh/x09gGL00LSxY6x5834a6jyEpPok=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1758297345; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=tIUdfOMaq8m4u7Sr57Awmfxs22ptyv4XuiP73zPmA9Y=; b=AZP/rJDLIhf1qVMzgRuSK/tq9ctqkNOkBgtWhRPkal5yW13DxIcCBUxmdv/DUp2JDfCLu nnFKWzUquhX/WuS9Cu0mw4rKE9POj6XMGZFd/Jn0nz4BV1ZZNat6NcvBolSUinUiaLuWsrk QNtDFl8V+DovY+Z7EbyVtewyxzlBbI3Kkw8CS6sM1VgamYBC/p7cJJ6ZjHmueXBYoGv9+sT DWPRPi/MnXuevqZazQBwhaeCyb1tWxrIGiDW1oh+LPPbPwdbhrkvD4Ep6NjfTiJdQsBp/+y +git2GEjID26n48maa8Cgv2kiSvdPbwwdxN3+wl98RtMWiupcYRHJVuGzOxA== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7996868EB48; Fri, 19 Sep 2025 18:55:45 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1758297343; b=KjcvoKUxumD5rXB277LbDMHnev2EOFhVSRzld2K7023YCMtXA16zeBzmh6G5xxPUSXmMA 9XG0IylUgKkP4Sf7rjimDPRTbnkffSmPnw7i2G9bPIzR0MgEuCLpiiNbb8LxM7QOf9RbnFj BVyu/ko05EdBBkMv59MceAfZ4ZjZPoAB7YGSBzG2dZrgg1gzI2oOIUWbaPYUaisBE0KGr2U sh5cAMIJYH8Dj5D/G8YDZEujcoG2x3v/nIa3YC9bsftG392+a2riWC4yzV7kPQq01ui3ywj akM/zll1Qvg8RF4ctx7AVCMc2brsMNx6eSV4BLVC46kddqsDxChJF0M4iuGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1758297343; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=FcgLyIKSv+PsVosEfcj+1kCVwCQYeA41nKGXTDm3y0E=; b=ofoySKcvMO25orKXUA49s40IwMIIdmTENB3q9wRMI66EEQHVyPvJPi5+1x40XFYiXFfAg IwI/NgbkcWzSvc1wnpe76uGAhbST1B+ckx+X5ZDCGj/rMNcwtKsVVuZrn8ozIe6FrQVO+OS IiOD6Ir1yE/sWBvnmsN5QjYw3pmifc3PO4o80BlqHMW9GyGFI0wFYBPWfaiChs84vw6iZ8z qYmXFhUMPuFPrBNEcDQfJAZeRRw2OyKW1H3MRQNyaeiOWoz2giqfbi4ohyD4RO2kUay3FIx Pr0SW1S+gqeMni0rLxJWS+Z7YeaT2GFOfE67uXmwbxXBmGbaHlXouxFDIFAA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1758297334; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=Fip5TUVsdOC7MQh/x09gGL00LSxY6x5834a6jyEpPok=; b=ZLivjen7D4VXsSb8ZsSxIKTbhzv16+4i03kqDd5BlhqAqM54Tq11B/gBQMZHincRoiXML D+TUyGe6TRc4OTfi2fI3haZOu1Ki5KSEK/Tqz0weYb6h5qx2rRX2O2VmUZiJwVSLUBp5ooW O0qJsz0QdZ3Fs64lHhYt6uc26xKu1EQew7bY7nQ/4YvMOVyb73wkuK5vxO/QEVXXfdvAI6j kfmM/kTqoF3wqwcDuE074G7dJVh9ruxQYgETXnjP9PZJHI9X64zHcB8aztrtZg0w/S80L7X 9sYpXmsePwTRnPBeMT4BhMDZca0ZViAvtw3h8a3P5D1o4yaHwrJf+mtu548A== Received: from ed19c606a818 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1DF0F68EB36 for ; Fri, 19 Sep 2025 18:55:34 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 19 Sep 2025 15:55:33 -0000 Message-ID: <175829733426.25.3665524427903177912@463a07221176> Message-ID-Hash: I4IKVIOVN7DEVJZNIFC7YYO3XZCV75WU X-Message-ID-Hash: I4IKVIOVN7DEVJZNIFC7YYO3XZCV75WU X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] deprecate support for libnpp (PR #20554) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Timo Rothenpieler via ffmpeg-devel Cc: Timo Rothenpieler Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20554 opened by Timo Rothenpieler (BtbN) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20554 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20554.patch libnpp is a closed source proprietary library, and for most of its functionality, proper open source functionality via CUDA kernel based filters already exists, or can relatively easily be implemented. The latest version of libnpp broke API compatibility. So instead of putting in effort to track support for multiple API versions, let's just deprecate support for it. >>From 3908072fe84458ed146e71beb5310c4fc93644e4 Mon Sep 17 00:00:00 2001 From: Timo Rothenpieler Date: Fri, 19 Sep 2025 17:35:29 +0200 Subject: [PATCH] configure: deprecate support for libnpp --- configure | 8 ++++++-- libavfilter/version_major.h | 1 + libavfilter/vf_scale_npp.c | 2 ++ libavfilter/vf_sharpen_npp.c | 2 ++ libavfilter/vf_transpose_npp.c | 2 ++ 5 files changed, 13 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 8def62a5d9..32d114a533 100755 --- a/configure +++ b/configure @@ -7172,9 +7172,13 @@ enabled libmodplug && require_pkg_config libmodplug libmodplug libmodplug enabled libmp3lame && require "libmp3lame >= 3.98.3" lame/lame.h lame_set_VBR_quality -lmp3lame $libm_extralibs enabled libmysofa && { check_pkg_config libmysofa libmysofa mysofa.h mysofa_neighborhood_init_withstepdefine || require libmysofa mysofa.h mysofa_neighborhood_init_withstepdefine -lmysofa $zlib_extralibs; } -enabled libnpp && { check_lib libnpp npp.h nppGetLibVersion -lnppig -lnppicc -lnppc -lnppidei -lnppif || +enabled libnpp && { test_cpp_condition "$(cd "$source_path"; pwd)/libavfilter/version_major.h" FF_API_LIBNPP_SUPPORT || + die "ERROR: libnpp support is removed in this version"; } && + { check_lib libnpp npp.h nppGetLibVersion -lnppig -lnppicc -lnppc -lnppidei -lnppif || check_lib libnpp npp.h nppGetLibVersion -lnppi -lnppif -lnppc -lnppidei || - die "ERROR: libnpp not found"; } + die "ERROR: libnpp not found"; } && + { check_func_headers "nppi.h" nppiYCbCr420_8u_P2P3R $libnpp_extralibs || + die "ERROR: libnpp support is deprecated, version 13.0 and up are not supported"; } enabled libopencore_amrnb && require libopencore_amrnb opencore-amrnb/interf_dec.h Decoder_Interface_init -lopencore-amrnb enabled libopencore_amrwb && require libopencore_amrwb opencore-amrwb/dec_if.h D_IF_init -lopencore-amrwb enabled libopencv && { check_headers opencv2/core/core_c.h && diff --git a/libavfilter/version_major.h b/libavfilter/version_major.h index af6f59832f..539d5caa3d 100644 --- a/libavfilter/version_major.h +++ b/libavfilter/version_major.h @@ -37,5 +37,6 @@ #define FF_API_BUFFERSINK_OPTS (LIBAVFILTER_VERSION_MAJOR < 12) #define FF_API_CONTEXT_PUBLIC (LIBAVFILTER_VERSION_MAJOR < 12) +#define FF_API_LIBNPP_SUPPORT (LIBAVFILTER_VERSION_MAJOR < 12) #endif /* AVFILTER_VERSION_MAJOR_H */ diff --git a/libavfilter/vf_scale_npp.c b/libavfilter/vf_scale_npp.c index 1b1b7b9fc9..0529db3a29 100644 --- a/libavfilter/vf_scale_npp.c +++ b/libavfilter/vf_scale_npp.c @@ -281,6 +281,8 @@ static av_cold int nppscale_init(AVFilterContext* ctx) NPPScaleContext* scale = ctx->priv; int i, ret; + av_log(ctx, AV_LOG_WARNING, "The libnpp based filters are deprecated.\n"); + if (!strcmp(scale->format_str, "same")) { scale->format = AV_PIX_FMT_NONE; } else { diff --git a/libavfilter/vf_sharpen_npp.c b/libavfilter/vf_sharpen_npp.c index c7769f5837..3ec74f8c0c 100644 --- a/libavfilter/vf_sharpen_npp.c +++ b/libavfilter/vf_sharpen_npp.c @@ -53,6 +53,8 @@ static int nppsharpen_init(AVFilterContext* ctx) { NPPSharpenContext* s = ctx->priv; + av_log(ctx, AV_LOG_WARNING, "The libnpp based filters are deprecated.\n"); + s->own_frame = av_frame_alloc(); if (!s->own_frame) goto fail; diff --git a/libavfilter/vf_transpose_npp.c b/libavfilter/vf_transpose_npp.c index e781d7c58b..2315b1043a 100644 --- a/libavfilter/vf_transpose_npp.c +++ b/libavfilter/vf_transpose_npp.c @@ -85,6 +85,8 @@ static int npptranspose_init(AVFilterContext *ctx) NPPTransposeContext *s = ctx->priv; int i; + av_log(ctx, AV_LOG_WARNING, "The libnpp based filters are deprecated.\n"); + for (i = 0; i < FF_ARRAY_ELEMS(s->stages); i++) { s->stages[i].frame = av_frame_alloc(); if (!s->stages[i].frame) -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org