[FFmpeg-devel] [PATCH] Fix ObjC issues after C/C++ flags split (PR #20524)

[FFmpeg-devel] [PATCH] Fix ObjC issues after C/C++ flags split (PR #20524)

[Timo Rothenpieler via ffmpeg-devel]

PR #20524 opened by Timo Rothenpieler (BtbN)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20524
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20524.patch


>From f85da32e3a841742fda6e869afa6ce21a84e8550 Mon Sep 17 00:00:00 2001
From: Timo Rothenpieler <timo@rothenpieler.org>
Date: Mon, 15 Sep 2025 14:17:49 +0200
Subject: [PATCH 1/2] configure: make --extra-objcflags show the right default
 flags

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 23a958e38d..82d1a9d3ea 100755
--- a/configure
+++ b/configure
@@ -419,7 +419,7 @@ Toolchain options:
   --host-os=OS             compiler host OS [$target_os]
   --extra-cflags=ECFLAGS   add ECFLAGS to CFLAGS [$CFLAGS]
   --extra-cxxflags=ECFLAGS add ECFLAGS to CXXFLAGS [$CXXFLAGS]
-  --extra-objcflags=FLAGS  add FLAGS to OBJCFLAGS [$CFLAGS]
+  --extra-objcflags=FLAGS  add FLAGS to OBJCFLAGS [$OBJCFLAGS]
   --extra-ldflags=ELDFLAGS add ELDFLAGS to LDFLAGS [$LDFLAGS]
   --extra-ldexeflags=ELDFLAGS add ELDFLAGS to LDEXEFLAGS [$LDEXEFLAGS]
   --extra-ldsoflags=ELDFLAGS add ELDFLAGS to LDSOFLAGS [$LDSOFLAGS]
-- 
2.49.1


>From 189d0b83b20bd701bf7f8e171d3bb8e9c6077dd7 Mon Sep 17 00:00:00 2001
From: Timo Rothenpieler <timo@rothenpieler.org>
Date: Mon, 15 Sep 2025 14:30:16 +0200
Subject: [PATCH 2/2] configure: pass CFLAGS to ObjC tests again

It was mistakenly removed in 0ce413af9cc8040095a6b714600d6a8dceaca514.

This matches how the Makefiles actually compile ObjC code, and
unlike C++, this seems to actually be benign and various existing
setups rely on that behaviour.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 82d1a9d3ea..3d51749618 100755
--- a/configure
+++ b/configure
@@ -1092,7 +1092,7 @@ test_objcc(){
     log test_objcc "$@"
     cat > $TMPM
     log_file $TMPM
-    test_cmd $objcc -Werror=missing-prototypes $CPPFLAGS $OBJCFLAGS "$@" $OBJCC_C $(cc_o $TMPO) $TMPM
+    test_cmd $objcc -Werror=missing-prototypes $CPPFLAGS $CFLAGS $OBJCFLAGS "$@" $OBJCC_C $(cc_o $TMPO) $TMPM
 }
 
 test_nvcc(){
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org