Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avcodec/rkmppdec: Don't fill the decoder in low-delay mode (PR #20518)
@ 2025-09-14 18:23 cgutman via ffmpeg-devel
  0 siblings, 0 replies; only message in thread
From: cgutman via ffmpeg-devel @ 2025-09-14 18:23 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: cgutman

PR #20518 opened by cgutman
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20518
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20518.patch

For low delay usecases, we should not trade latency for throughput. This addresses my comment in https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20511#issuecomment-6821


>From 1c4dbb424307a0f411e24e6fa980010340e0b614 Mon Sep 17 00:00:00 2001
From: Cameron Gutman <aicommander@gmail.com>
Date: Wed, 3 Sep 2025 20:35:21 -0500
Subject: [PATCH] avcodec/rkmppdec: Don't fill the decoder in low-delay mode

For low delay usecases, we should not trade latency for throughput.

Signed-off-by: Cameron Gutman <aicommander@gmail.com>
---
 libavcodec/rkmppdec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/rkmppdec.c b/libavcodec/rkmppdec.c
index a6bc565776..a5c1397be5 100644
--- a/libavcodec/rkmppdec.c
+++ b/libavcodec/rkmppdec.c
@@ -518,8 +518,8 @@ static int rkmpp_receive_frame(AVCodecContext *avctx, AVFrame *frame)
             }
         }
 
-        // make sure we keep decoder full
-        if (freeslots > 1 && !decoder->eos_reached)
+        // make sure we keep decoder full unless in low-delay mode
+        if (freeslots > 1 && !decoder->eos_reached && !(avctx->flags & AV_CODEC_FLAG_LOW_DELAY))
             return AVERROR(EAGAIN);
     }
 
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-09-14 18:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-14 18:23 [FFmpeg-devel] [PATCH] avcodec/rkmppdec: Don't fill the decoder in low-delay mode (PR #20518) cgutman via ffmpeg-devel

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git