From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3541F43CF0 for ; Fri, 12 Sep 2025 06:30:16 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'tOsTZCuBevdq35iT+vvrxe6GOJVzPZ1C9/5h4IOieuU=', expected b'nxRrRcyxM3K8C3EWDlYdphOtA9B64MbVUuibzWPRIxs=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1757658602; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=tOsTZCuBevdq35iT+vvrxe6GOJVzPZ1C9/5h4IOieuU=; b=BSWvqCgUuvflRGUYesQ+VYuq9fYo3qiWXeLXg5L2PC846HCapyqwLSmCTn4B780D5kvh+ L1fCDBiAnMDS+yMVA4MX6bjNPAak72tQRWiu22kF/7tzI+Y44UzwCM2EbiVoOJz5GbIhLEV JA/vwsaL23Ml4JWRXZvyxHPU++6xiGOlWoH0gI1VaYVlB7KQXVi4RqIAdHg9oXrBUWx9Uaw h0KeuiSrE+RgdTmVAEAYLq90iIusLMkOsar29Zn5yGDpPL8LqpbBD6um4pLvJ8myXUzluxg KEKA6y+PdZpeC4RwxZDG6raHNWdnyHsIxW2vOC/HntlMnnBvgizDpBRJhcQg== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4903F68E8A9; Fri, 12 Sep 2025 09:30:02 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1757658598; b=FKGy/BKqpwzrud5RJvzX410KC41rThOISleTJtYiTdlyBbM9iqdl81clAlLPMWq8kVT3w 2dJhU7KfAWPViT7W9yKFL2pYt2RYKDoIvXsiKVwd4hcUdsLL26KVSMhFi738JRhea0PdwZy 5U1+w01u6EZd/gVEKCgTYXl+SVlCJYwY2+knx0fLUXt5YOn0H6sB8lLHF8cigPghvWd3yGM n/l/8ENw885IpMCDE3PpsStesqpYYWyIgKGdF/aFSyLv3bMCmUOApOg6dGcCX5e/kD5eXu6 yhUiss5G2fq0MNLSLMOckTlfKQMiYjNOp2i53BxLiJDNOj211MjjUdhGU4IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1757658598; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=Ucgkk4TA4dSQvCDvZ41JF5XIZ3ouodixhfn4zL77DIg=; b=IlWZ2WkdFgjdMfeO1IFoVw+ABXmFe0jgWVk0oCuUUwzoxU/d3CJ4ZdnQ/zUu3abaHujRo HmZ3IBWgUXMLvcnMrkDtL2ak+oG9lw3PnHBobtiQYfl3kCgvOT0fPAILqI2ktqTzPGRrzw2 tdsdrTOJaN/oXaHKkUu34aRCh+n6Mu0LAzG2dmHnD+TEbnZHs6e7YMSbwAT+zrWaNz2QPHU 3qeaJYE48Fi5GxHK2z47gPqkyI+ICaDmxlhO0l/NDYj9pxS4JTitvl/XCc6emX6fU/+/0s8 TtTp4C4Gj/RHx7WwJOfMgSMP6heXGa9F0SX0cFmlur9f5dKmRp36Atki5LMg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1757658580; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=nxRrRcyxM3K8C3EWDlYdphOtA9B64MbVUuibzWPRIxs=; b=BeUGGKw/VFibWb5hiu7ba0gS5WZ6x5ZW/qkcExK05lYZdEAiqkpgTGRLpaATnwzkxwPR+ o9OQOFbegoOXdzSIZLyeJ34MJ61BVpl6YseujUY04CKAH2d1ZYNLPR4c+bBoz7NQyhb4YN4 l8RBbyHWQuV063xkXR6L3B4bua9aut9rCwuZWNbZnqaPksownDIPeNzYg079j1StDmSAKAh jpko/JLBOqwKvl79Ok/JH3nQRp6HpDbRRuJR7xa9gz9oik+SHsNrOMDAaraFeXuZalACxZ8 qnKjLQOKAFTbXPliDlGrJNUTJ22AjpY6euiU8agfTVLrjrn4Gf7FMBGEXd6Q== Received: from 3f9d35a0eedc (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4465D68E8B4 for ; Fri, 12 Sep 2025 09:29:40 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Fri, 12 Sep 2025 06:29:39 -0000 Message-ID: <175765858081.25.6869214606982893135@463a07221176> Message-ID-Hash: 4T5YK7JI3HDHOT5ZWVJOTQPFPIWF7UUT X-Message-ID-Hash: 4T5YK7JI3HDHOT5ZWVJOTQPFPIWF7UUT X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] fftools/cmdutils: Rename file_read to ff_file_read to avoid symbol conflict (PR #20500) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: caifan via ffmpeg-devel Cc: caifan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20500 opened by caifan URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20500 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20500.patch The function name 'file_read' is too generic and may conflict with other functions in external code or libraries. Prefixing it with 'ff_' aligns with FFmpeg's naming convention and improves namespace isolation. Signed-off-by: caifan3 >>From 26131ffb5546cfbbe528f4286bc347b35b218e7a Mon Sep 17 00:00:00 2001 From: caifan3 Date: Fri, 12 Sep 2025 14:23:53 +0800 Subject: [PATCH] fftools/cmdutils: Rename file_read to ff_file_read to avoid symbol conflict The function name 'file_read' is too generic and may conflict with other functions in external code or libraries. Prefixing it with 'ff_' aligns with FFmpeg's naming convention and improves namespace isolation. Signed-off-by: caifan3 --- fftools/cmdutils.c | 4 ++-- fftools/cmdutils.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index dc093b0bd3..818bb40438 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -263,7 +263,7 @@ static int write_option(void *optctx, const OptionDef *po, const char *opt, return AVERROR(EINVAL); } - arg_allocated = file_read(arg); + arg_allocated = ff_file_read(arg); if (!arg_allocated) { av_log(NULL, AV_LOG_FATAL, "Error reading the value for option '%s' from file: %s\n", @@ -1498,7 +1498,7 @@ double get_rotation(const int32_t *displaymatrix) } /* read file contents into a string */ -char *file_read(const char *filename) +char *ff_file_read(const char *filename) { AVIOContext *pb = NULL; int ret = avio_open(&pb, filename, AVIO_FLAG_READ); diff --git a/fftools/cmdutils.h b/fftools/cmdutils.h index ad020f893a..e780999c77 100644 --- a/fftools/cmdutils.h +++ b/fftools/cmdutils.h @@ -535,7 +535,7 @@ void *allocate_array_elem(void *array, size_t elem_size, int *nb_elems); double get_rotation(const int32_t *displaymatrix); /* read file contents into a string */ -char *file_read(const char *filename); +char *ff_file_read(const char *filename); /* Remove keys in dictionary b from dictionary a */ void remove_avoptions(AVDictionary **a, AVDictionary *b); -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org