[FFmpeg-devel] [PATCH] avcodec/tiffenc: support writing ICC profiles (PR #20493)

[FFmpeg-devel] [PATCH] avcodec/tiffenc: support writing ICC profiles (PR #20493)

[jianhuaw via ffmpeg-devel]

PR #20493 opened by jianhuaw
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20493
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20493.patch

The tiff reads the icc profile to the side data but doesn't write the icc profile from side data to the TIFF_ICC_PROFILE.

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>


>From 1754d0f56d2e7ff2ec62b77c80850bc14385bfa8 Mon Sep 17 00:00:00 2001
From: Wu Jianhua <toqsxw@outlook.com>
Date: Thu, 11 Sep 2025 22:12:08 +0800
Subject: [PATCH] avcodec/tiffenc: support writing ICC profiles

Signed-off-by: Wu Jianhua <toqsxw@outlook.com>
---
 libavcodec/tiffenc.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/libavcodec/tiffenc.c b/libavcodec/tiffenc.c
index 9a5291c257..917ff9ac1d 100644
--- a/libavcodec/tiffenc.c
+++ b/libavcodec/tiffenc.c
@@ -250,6 +250,7 @@ static int encode_frame(AVCodecContext *avctx, AVPacket *pkt,
     const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(avctx->pix_fmt);
     TiffEncoderContext *s = avctx->priv_data;
     const AVFrame *const p = pict;
+    AVFrameSideData *side_data;
     int i;
     uint8_t *ptr;
     uint8_t *offset;
@@ -504,6 +505,11 @@ static int encode_frame(AVCodecContext *avctx, AVPacket *pkt,
             ADD_ENTRY1(s, TIFF_YCBCR_POSITIONING, AV_TIFF_SHORT, 2);
         ADD_ENTRY(s, TIFF_REFERENCE_BW,      AV_TIFF_RATIONAL, 6, refbw);
     }
+
+    side_data = av_frame_get_side_data(pict, AV_FRAME_DATA_ICC_PROFILE);
+    if (side_data)
+        ADD_ENTRY(s, TIFF_ICC_PROFILE, AV_TIFF_STRING, side_data->size, side_data->data);
+
     // write offset to dir
     bytestream_put_le32(&offset, ptr - pkt->data);
 
@@ -575,7 +581,7 @@ const FFCodec ff_tiff_encoder = {
     .p.type         = AVMEDIA_TYPE_VIDEO,
     .p.id           = AV_CODEC_ID_TIFF,
     .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_FRAME_THREADS |
-                      AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE,
+                      AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE | FF_CODEC_CAP_ICC_PROFILES,
     .priv_data_size = sizeof(TiffEncoderContext),
     .init           = encode_init,
     .close          = encode_close,
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org