From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 322C94C6BB for ; Wed, 10 Sep 2025 12:38:38 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'KydfsQzOZ4iED+FTC6bakmWYQW7rfGRn5kxUhrw6/XE=', expected b'TcoOVq7zJ+vYNvU8NQnS0bZIYiQZO4GOxQDAKKGT5Dc=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1757507914; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=KydfsQzOZ4iED+FTC6bakmWYQW7rfGRn5kxUhrw6/XE=; b=QIBBo7jjOzBTR1BbGs/OcJzKUxi9Atsjq3dO9+i/PuGLiax74SMQw/+oO+PMw+iTqjSm7 nlXU9yCNTLTDzk0sq1C2kSuhGbnirvk6P7VQvjrpVx6tQx53CjttedXjgHiS0zS0hULPzAN 1EI3W18MLzVdGncZ+LlGGCg3JxO5r2qxieBd3hCfw5UD+vPL15Xmf7YDGPGXtr17C7jG2uj 537nBlJq0rOP1E0YRneWPaSX8o/+u38234p3CONta59emxK1vaK/nYX5A072Rxz3TBCxJ9t Iw8U7AiRD1rrPRJxMXmYDHaqbf0Q2nbiPF4aTWxRQsTRtxKdGCHJBN0IHN0A== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 95C4D68E7B7; Wed, 10 Sep 2025 15:38:34 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1757507914; b=MpvswDsctQ2jwYg93QNJzcT2SvF32WoO7xFweaFseEkEie5jqMvnPBryYCcykdhrpboM5 //AG6538knxR7s9QJKixZ89zTm73aq/TzEL8VUMFV8iTotau+kEvyFAZq4YEqp3Og7Z5+qc hCUnCjfZQFyS8JoifYwFURfSuhJuEzHpcUg9urtDaAH4k60kt1Gxlm5o5d9drTGPeySBZHw XXx668TrBQt7G9bIKfnTVZdyHfYNG+BSCW2GNe6NOsSYieTpXiMNHBN4GNrwNKFtHf1Je0Q dGyNejPsrjWMk3j7gB0RQnbBr673r3SqbabdpwWjhmgQxvqw0W8rvNl2WBTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1757507914; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=cXXJE5hBeBfvneKxJ4i86XJ+GMJRiEy6oVxHxY5WBv8=; b=UtpF6FJwv7VTkVrPhRbI7KdqtEfHfIbHVW9BpRWlq8Frq+UCj/MHNxejtRCT4fFdnZyQs pv33LBxRCFSBV4EvB4z+AkEDbIqYeQWkPi+9Y67VI1PZdbhB2XJjsCqNnDp7//oddQG947i RDHtV0shN4NX6hz+S7uts7Q1v0EQkIU2v5ey/sCwYc6jutFOkyYnzSA9WrB010RwruEhkjn uLNUwlv+7Tfu8srQl9DNjiK9DrKEnJOmm2M7uH1TWy2Hmp1cTyG+vn0C2tm2XkVJVgPdcjR WqrngpyIGiVR0uwHy7BQy61QyE+q++MUkpAqe8C9Z8TpVdbKHHe8k2dpiJWA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1757507906; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=TcoOVq7zJ+vYNvU8NQnS0bZIYiQZO4GOxQDAKKGT5Dc=; b=atozf1dMsr2CTuA5rCOcpWxhxR9eQZyzXwgJTc4/eRgb9NO2ceJG+c1Kgxo3XOqjRuYJe fnIOcKVEDlA7qcUuCFoLpTN3QxBKPkOapZOeDxcvqEMIB0ekFXAY0AVJP/9Ga39eStC43OY mYRdfIiUjHOtc68M9pFYRzmqNYDpx6N/iXQMNjecEjPaZuFllEjIIeeJ4VtY8mcTPTrSxoh YwSdrCKa+WwQeX9YVwfSaRrqMx7l1CbeSdT9Zde/25ho6GshYsVuIhDLkfEXGZn4In6d4oW 2xqCZGzVW3jWTD1/9Pw2NDIhJXEQ70pC3mrasLFGkH2VquAHettxcYRleKYw== Received: from 3f9d35a0eedc (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 227CC68E7A9 for ; Wed, 10 Sep 2025 15:38:26 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 10 Sep 2025 12:38:25 -0000 Message-ID: <175750790626.25.4657912400265564989@463a07221176> Message-ID-Hash: 74ESG523YQIPDWKLB5KP7DY3TUCA3CY7 X-Message-ID-Hash: 74ESG523YQIPDWKLB5KP7DY3TUCA3CY7 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: ensure bitrate is set in low_delay mode (PR #20488) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Zhao Zhili via ffmpeg-devel Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20488 opened by Zhao Zhili (quink) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20488 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20488.patch VideoToolbox doesn't support automatic bitrate in low delay mode. Check bitrate and show error message so user knows what's going wrong. >>From c1dc2e2b7cc8df8a40b616793d1204be0e71103c Mon Sep 17 00:00:00 2001 From: Zhao Zhili Date: Wed, 10 Sep 2025 20:29:47 +0800 Subject: [PATCH] avcodec/videotoolboxenc: ensure bitrate is set in low_delay mode VideoToolbox doesn't support automatic bitrate in low delay mode. Check bitrate and show error message so user knows what's going wrong. --- libavcodec/videotoolboxenc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index f0d3a15897..729072c0b9 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -1711,6 +1711,12 @@ static int vtenc_configure_encoder(AVCodecContext *avctx) // low-latency mode: eliminate frame reordering, follow a one-in-one-out encoding mode if ((avctx->flags & AV_CODEC_FLAG_LOW_DELAY) && ((avctx->codec_id == AV_CODEC_ID_H264) || (TARGET_CPU_ARM64 && avctx->codec_id == AV_CODEC_ID_HEVC))) { + if (!avctx->bit_rate) { + av_log(avctx, AV_LOG_ERROR, "Doesn't support automatic bitrate in low_delay mode, " + "please specify bitrate explicitly\n"); + status = AVERROR(EINVAL); + goto init_cleanup; + } CFDictionarySetValue(enc_info, compat_keys.kVTVideoEncoderSpecification_EnableLowLatencyRateControl, kCFBooleanTrue); -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org