From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7BE344C567 for ; Mon, 8 Sep 2025 18:10:35 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'QPiPBIfZE9iAnyuZ1FnkYJzVbtJUIIu1hCbfkt1YsHw=', expected b'3aD5Q8x3y1RWGipsFUpHwATvWCd0E4A1FmYSb05Ua98=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1757355022; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=QPiPBIfZE9iAnyuZ1FnkYJzVbtJUIIu1hCbfkt1YsHw=; b=ldR7h7vrWbQy1Ur7YL0DNm+3m+jx9IanuVYKs4GDFh3uZ247KUSOj39QnFDVgr40PK42K YCcwTrBCI3qGeZzvScocMcmIFl2cWGUc8gU8LdwJCJsc28fqJ6qzxQzGbUpQj/WtJg3SueF HBRwipyMIKomn+WI6oHmVHgxFmJxSTIa7bwYiOkbiDvlSdSOu84p9GAIhbDKiZ1bWP9TfFG I7tmUV4lPTGyFbc3xK3uuFHTvcbCics5K21fvSV9poB7fjgnCJk2Xn4TqRPvX0YNefUp4yv qA6uyzSUq/lhDlkMwSTHDGZ2qqPIglqTaOX7FJUJunvElZiO2SjSjn+drapg== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 767FD68E780; Mon, 8 Sep 2025 21:10:22 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1757355021; b=WmC2izE1iZmlR3ilTBh1peUZvUUT/z+UCmzgrzrxOT7ryvHXL4I1JTENEgLE87iYLK7pR cghyt4DjUfZkR+2UKAtRjb+GqOYUXwr3q1Jz2lds7Bo9eaV4Dbc8b+y5fuo6Jjn+cRfqSOz mJu1RsyIVyaqTcMTfgCJgJHqswZLD5Q+VdV2mxLdbLUg3qATs6JVaZTcNK9eMcD5yW0MfYE qkuxRLz7qOJW7cfS7Te2N/Y+rSgY/dYVhUpsPaE1vLLR2X8CWJvYDMjY7sYGookjnlYeroR hABR6eYhVM1eoA/E+Nb1u5DjVqXBUqkIkSzdMLkeY6OIlIb2srYdpL7K1n2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1757355021; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=eSdLoCvm6b9Q3/P9JP1g8VLoJ+9hyRwqcQt3l7ejojo=; b=k/ZLTKAzG9n6MTLjxWVhFSycW7gp3i0OAiSnJP3XC2VygM7uSr1lbYS7H6Xd4Bzlht7SP +21gG3rofxKEat+py66Lt121UWCMHjwO5itrgOvfCjzjhQMcJbEW20OL8I/g7oMuiYKMr8C 674DDSIqjkGQJQ9pAcShhBOVPHlSD2JFBIFBPX/xaWmL9Xeapx2HNl5U3O0a0cJemRvTfv1 /rdent9m6i2wQL5BZ+AYVC7YeHidXa/U8WSSdf0MYTBEI6tzt37m/veb9ZTzv5c1GoH5P6G w1/iOUC2oNDmfTJGzv86z3AMtQt7lfDytg80WqWhIePHRdAuNrJIFJXaDeFg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1757355012; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=3aD5Q8x3y1RWGipsFUpHwATvWCd0E4A1FmYSb05Ua98=; b=V3O8IZqPOLFo5I/n3CuGZrRx4DaTP3Csp43R1X/qeKDVGCGYogA6unQWB98vRVRB5ddHp +LxvctwTFhmkclybhVU2st8AyyUese8VCIoLw/amW4IoeDOhnzpnHUMdEL2sulyMhH9VkPg 1eTDAdUI+nGpm5OycHX+f+KNVHv2QI7MR/g8tWz0uJjd7wvB1bK9CieWIi2iKOpQSsfMCIW vjeyKoG6raTJciUqR4YFrlee11BbgSSi6b5cErHDxCUGDiHq4ZfBGorjWeNrncAVJX3Z4Hd wPVB+EY5ZHVz30rgAQ0Bja8OTrrfTIwB1F+fIwNje3YYlOhfOX2HB1izOSfw== Received: from 3f9d35a0eedc (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 3FCDF68D5F6 for ; Mon, 8 Sep 2025 21:10:12 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Mon, 08 Sep 2025 18:10:11 -0000 Message-ID: <175735501247.25.7559213113986495289@463a07221176> Message-ID-Hash: ZNISRM6HNFGWX7KQGMWYIH7NZJZSNJ4L X-Message-ID-Hash: ZNISRM6HNFGWX7KQGMWYIH7NZJZSNJ4L X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avfilter/buffersink: add missing checks for alphamodes (PR #20469) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: James Almer via ffmpeg-devel Cc: James Almer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20469 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20469 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20469.patch >>From b186d5443afc5eda3c478c61eb8a29fc3821a898 Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 8 Sep 2025 15:07:20 -0300 Subject: [PATCH 1/2] avfilter/buffersink: add missing checks for alphamodes Signed-off-by: James Almer --- libavfilter/buffersink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index f636d3728f..c2d1efa78c 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -181,7 +181,7 @@ static av_cold int common_init(AVFilterContext *ctx) if (ctx->input_pads[0].type == AVMEDIA_TYPE_VIDEO) { if ((buf->pixel_fmts_size || buf->color_spaces_size || buf->color_ranges_size || buf->alpha_modes_size) && - (buf->nb_pixel_formats || buf->nb_colorspaces || buf->nb_colorranges)) { + (buf->nb_pixel_formats || buf->nb_colorspaces || buf->nb_colorranges || buf->nb_alphamodes)) { av_log(ctx, AV_LOG_ERROR, "Cannot combine old and new format lists\n"); return AVERROR(EINVAL); } @@ -400,7 +400,7 @@ static int vsink_query_formats(const AVFilterContext *ctx, int ret; #if FF_API_BUFFERSINK_OPTS - if (buf->nb_pixel_formats || buf->nb_colorspaces || buf->nb_colorranges) { + if (buf->nb_pixel_formats || buf->nb_colorspaces || buf->nb_colorranges || buf->nb_alphamodes) { #endif if (buf->nb_pixel_formats) { ret = ff_set_common_formats_from_list2(ctx, cfg_in, cfg_out, buf->pixel_formats); -- 2.49.1 >>From 5e2876349253560a4a3207eda365523c2e4843b0 Mon Sep 17 00:00:00 2001 From: James Almer Date: Mon, 8 Sep 2025 15:08:49 -0300 Subject: [PATCH 2/2] fftools/ffplay: set the alphamodes buffersink array option instead of the binary one And add the missing goto fail. This should ensure the alpha mode is set and remove bogus warnings printed by ffplay. Signed-off-by: James Almer --- fftools/ffplay.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 05eadb69a6..dc2627521e 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1938,9 +1938,10 @@ static int configure_video_filters(AVFilterGraph *graph, VideoState *is, const c AV_OPT_TYPE_INT, sdl_supported_color_spaces)) < 0) goto fail; - if ((ret = av_opt_set_array(filt_out, "alpha_modes", AV_OPT_SEARCH_CHILDREN, + if ((ret = av_opt_set_array(filt_out, "alphamodes", AV_OPT_SEARCH_CHILDREN, 0, FF_ARRAY_ELEMS(sdl_supported_alpha_modes), AV_OPT_TYPE_INT, sdl_supported_alpha_modes)) < 0) + goto fail; ret = avfilter_init_dict(filt_out, NULL); if (ret < 0) -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org