[FFmpeg-devel] [PATCH] libavformat/rtsp.c:fix warning:‘%s’ directive output may be truncated (PR #20443)

[FFmpeg-devel] [PATCH] libavformat/rtsp.c:fix warning:‘%s’ directive output may be truncated (PR #20443)

[caifan via ffmpeg-devel]

PR #20443 opened by caifan
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20443
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20443.patch

libavformat/rtsp.c: In function ‘ff_rtsp_make_setup_request’:warning: ‘%s’ directive output may be truncated writing up to 4095 bytes into a region of size 4085 [-Wformat-truncation=]
note: ‘__builtin___snprintf_chk’ output between 14 and 4109 bytes into a destination of size 4096

Signed-off-by: caifan3 <caifan3@xiaomi.com>


From a012b3b086113e1a2a6e2ad10de985199d4d8df0 Mon Sep 17 00:00:00 2001
From: caifan3 <caifan3@xiaomi.com>
Date: Fri, 5 Sep 2025 16:19:20 +0800
Subject: [PATCH] =?UTF-8?q?libavformat/rtsp.c:fix=20warning:=E2=80=98%s?=
 =?UTF-8?q?=E2=80=99=20directive=20output=20may=20be=20truncated?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

libavformat/rtsp.c: In function ‘ff_rtsp_make_setup_request’:warning: ‘%s’ directive output may be truncated writing up to 4095 bytes into a region of size 4085 [-Wformat-truncation=]
note: ‘__builtin___snprintf_chk’ output between 14 and 4109 bytes into a destination of size 4096

Signed-off-by: caifan3 <caifan3@xiaomi.com>
---
 libavformat/rtsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 10355b89b8..507fbcd03d 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1518,7 +1518,7 @@ int ff_rtsp_make_setup_request(AVFormatContext *s, const char *host, int port,
     }
 
     for (j = rt->rtp_port_min + port_off, i = 0; i < rt->nb_rtsp_streams; ++i) {
-        char transport[MAX_URL_SIZE];
+        char transport[MAX_URL_SIZE - 13];
 
         /*
          * WMS serves all UDP data over a single connection, the RTX, which
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org