From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5A4CC4C2E0 for ; Thu, 4 Sep 2025 01:41:38 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'LFZ2Nlm0b0VkCyfuBo0Ty4yKV2WrJNNajmfZPLnaf3g=', expected b'OvNu2KX4qCx0Ndjy9uCtmtGvJUc9o5Awk066r+aHXUQ=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756950038; h=mime-version : to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=LFZ2Nlm0b0VkCyfuBo0Ty4yKV2WrJNNajmfZPLnaf3g=; b=GCDK+bqfEgRNzgyGz+gWV/+oR8dJlzyDi2L+PfkMIbfSNQMiGZ6s8cgEEjPnFCT0LG1wC YXcAWcr86ce/URIrhKfTAkBXapj/++MtLW4tsBajVEbE6E9mpFnHTm12zQM88pzHRmyyoVc 0OyNIBo0qQIV3qVZJcZXF/A6ea5bCkWdu5mE9P7deHefmP6emwIfAdtVkODKUUZ5hnKKXVk 6kyiNP+To6i38l0Geo6wPHPfA5wJRTchiwxWvMexgcza6IHDqlu8h8u2yA5vHbj0OJmCoMU ACZI0N5s7n/qyPB0T8WBo62xJj+0QzNHsm+u5WVO51eRPJAKfBDpc1sPvrdg== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EC18268E7BD; Thu, 4 Sep 2025 04:40:38 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1756950024; b=PKMvZ9x+pLAr8KzWKsq6M2KW5zRkrQ7CPdTVuNpnzpyYkE8ct8sX5LhkWPQl4JORFQwQl mSfLnSRyeNY86u1XXqv9WhiBEb+JTbDiglreEBIkVrvxFV7jWSp77Fw2DslhdB0DVHn5xjX YQ00EApk/Zjfx626g8ZO+MdIbsgBqwF44uAe04Br0zza3ulArXkQQOeEOIkK/RrqZKeOFdt cHQCsUozg5EadmEx9GOBBgPoOek2bKkmvmD32dblFlgAtuSNGbqR/RNt0a69f42x8kZdGJV LiHBjN0GAyGKd77gU9Lu1ISRJb0YfsLcUbhD9CNASoSgb6E1oaQGOGaghP+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1756950024; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=DUBaAGd8rn/HOhDRPwFcrBlhXZR6J3aF68en2/Vmaqg=; b=HYOAtxXNLIBhYh9NnLSQ+CrbXyOdgX1YOGWf4H/T2atJjnYhF7Rc9oYgT9/nm4BDd+N5k xYxDa3Oo+BSqjxFz4cL0hIfpJFqbDfqs3ceLeXXP86usxJhqhFdR6CCPVu4Kgrzcq1UUybN 0AjlGr4LwQdBCy4CZRlYOrS3JoqaXD9H2+V0j3dgqH3ufBAhQ6JwN8MBtYUiWkQnuJ4fwGG cpIcmhTmz9eVkWIXW6M1YQous7iYNsDS+cgHCz+4gpTfO/THoCMNf2U2R/uyK6Booz6Zj5d jPBylkEpf0jAnWUf21sAZhw1YYb4pJwA12dbG1ns0P+u+aCPsIQOHG6pDeVQ== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756950013; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : from; bh=OvNu2KX4qCx0Ndjy9uCtmtGvJUc9o5Awk066r+aHXUQ=; b=gvK6OUKk9/r5IHM8NFBAwAuKHkxP+mhWDZEAkhJCNb3zioA3Ex14pNiqF5sJ895yAseXb NJdOKcihmzKUY9UOqfB8HztwFQtNSGC3SpxX8dVFgqPDpk7YM0bEdHEdQ/WzfCjoa5hvw+g CInoWmUHLT88VAVZKNKloSxBrv6UsYa5vJdY+tjx8oxwzGBbOByEgj8NUVbkBiAliLeFI+u rfZtrsLd9M1p4WHsKLepObEzRb8s3WaUWepigRilpm9hk2Q0MD0f6voiRniC0t3vL6qe1q9 cI4uAQ7mMgJ3QGB1JqdRQJQSILyHO/IlHQiTxxiTYej4NvbuJ1uNE3Bb/RgQ== Received: from 5d8f51c41678 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A2BDF68E74D for ; Thu, 4 Sep 2025 04:40:13 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Message-ID: <175695001384.25.13092728973945520461@463a07221176> Message-ID-Hash: XZPGMCGFPORMHC7D2CXNMIY5AGXCMENS X-Message-ID-Hash: XZPGMCGFPORMHC7D2CXNMIY5AGXCMENS X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/vaapi_encode: skip AVBR if HRD parameters are set (PR #20424) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: cgutman via ffmpeg-devel Cc: cgutman Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20424 opened by cgutman URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20424 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20424.patch AVBR does not use `VAEncMiscParameterTypeHRD` (see [line 1212](https://code.ffmpeg.org/FFmpeg/FFmpeg/src/commit/858aa6176b5320e8f648461194a80cfda766de5a/libavcodec/vaapi_encode.c#L1212)), so attempting to set `rc_buffer_size and bit_rate together will cause the `rc_buffer_size` to be ignored if the VAAPI driver supports AVBR. We should prefer regular VBR for that case. >>From 56b2e59e8da1d316a430c7ec0deeb55c7ea3c86a Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Tue, 1 Apr 2025 23:11:20 -0500 Subject: [PATCH] avcodec/vaapi_encode: skip AVBR if HRD parameters are set AVBR does not use VAEncMiscParameterTypeHRD, so attempting to set rc_buffer_size and bit_rate together will cause the rc_buffer_size to be ignored if the VAAPI driver supports AVBR. We should prefer regular VBR for that case. Signed-off-by: Cameron Gutman --- libavcodec/vaapi_encode.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 8960e6b20a..8bd0701caf 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -1338,7 +1338,10 @@ static av_cold int vaapi_encode_init_rate_control(AVCodecContext *avctx) TRY_RC_MODE(RC_MODE_CBR, 0); if (avctx->bit_rate > 0) { - TRY_RC_MODE(RC_MODE_AVBR, 0); + // AVBR does not enforce RC buffer constraints + if (!avctx->rc_buffer_size && !avctx->rc_initial_buffer_occupancy) + TRY_RC_MODE(RC_MODE_AVBR, 0); + TRY_RC_MODE(RC_MODE_VBR, 0); TRY_RC_MODE(RC_MODE_CBR, 0); } else { -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org