* [FFmpeg-devel] [PATCH] avformat/aviobuf: Don't pretend to support avio_context_free(NULL) (PR #20416)
@ 2025-09-03 14:27 mkver via ffmpeg-devel
0 siblings, 0 replies; only message in thread
From: mkver via ffmpeg-devel @ 2025-09-03 14:27 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: mkver
PR #20416 opened by mkver
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20416
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20416.patch
It makes no sense to ever call it that way given that
avio_context_free() accepts a pointer to a pointer to an AVIOContext.
Other double-pointer-free functions like av_freep() also do it
that way (and therefore avio_context_free(NULL) still crashes
even with 870cfed2317e311a71bc14773332486a162f059c).
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>From cd21fa41c70bdc03660e0566649e9cf2bd7441b7 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Wed, 3 Sep 2025 15:51:51 +0200
Subject: [PATCH] avformat/aviobuf: Don't pretend to support
avio_context_free(NULL)
It makes no sense to ever call it that way given that
avio_context_free() accepts a pointer to a pointer to an AVIOContext.
Other double-pointer-free functions like av_freep() also do it
that way (and therefore avio_context_free(NULL) still crashes
even with 870cfed2317e311a71bc14773332486a162f059c).
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavformat/aviobuf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c
index 2e65f50006..6a6ec36e28 100644
--- a/libavformat/aviobuf.c
+++ b/libavformat/aviobuf.c
@@ -125,8 +125,8 @@ AVIOContext *avio_alloc_context(
void avio_context_free(AVIOContext **ps)
{
- if (ps && *ps) {
- AVIOContext *s = *ps;
+ AVIOContext *s = *ps;
+ if (s) {
av_freep(&s->protocol_whitelist);
av_freep(&s->protocol_blacklist);
}
--
2.49.1
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-09-03 14:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-03 14:27 [FFmpeg-devel] [PATCH] avformat/aviobuf: Don't pretend to support avio_context_free(NULL) (PR #20416) mkver via ffmpeg-devel
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git