From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DE3C44C236 for ; Wed, 3 Sep 2025 14:27:53 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'2znzaRZS+Ryd6gUxSmqF1Jpuio2i4l2W6XMwA2b6LSA=', expected b'fAxVs7UxTTJ3q2cQ4QUkJenCvTwlIdbuMNQJpeAV4vc=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756909659; h=mime-version : to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=2znzaRZS+Ryd6gUxSmqF1Jpuio2i4l2W6XMwA2b6LSA=; b=JCrfecgAmI821FJ6i2Tl4R+PLp+v6Y8qCj5/G/RFazNRD4nK/IzS+f24zIws6cdM2FzKY OTYNX7r4Sy9zEhyh0stE3GP2Hvl23PobzmBimyFjrs2SbDPm9GpodGB46SC89CjwmUoAGpq bc+0CknCSwyT3FrMjGsqHNJrrBi03TO8tPDvS8sllJ9XRNY6qQS+0H+09vImxyQb84UDXeY elDAD+xl023eSlG6WRKiwk15Jlh0UuOFRfiqSoRuw3rU2rWPAeOb4aCXLUqgAAyi+QAaV1A tWhxcDL/PQpfJfMQJHSzd73+jExzEaX/W2jxD6TQINWBcL9SCVXl912atBeA== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id DF38868E7BB; Wed, 3 Sep 2025 17:27:39 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1756909646; b=GKja/18waofko3AnrwJBBTCdp5MMOZiJP6e29HCL2uBynkkLMRjTJrLqnBiN1mtP+Z81x QlI/WUWffU4O9NdDzll+IjnpwgS88b+q4FHrXYlb6JTBc891FLkPEvtwnVz0khOkJ2cJ2l2 QhVPY9+fgjU/KR2ikRhXjoUeTnn5EMMKfbkW+8arGCG7YbeCod9eSTSyUdnDlpJOVBOUuNm Q0SEvGAjum+ziFZgRHvM2eJ8mJzhdmllRLO90q5/En41NGgCOjNCrI+6obAaCMw/QwdyVQn byYW3JOlx4VzAMKmsnQtgmrp0RVhxN6Gj/7ZCUcLxyfekomUJMKOEPCCTAzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1756909646; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=8tdRHM15EayoDA9FvMn7KKxq5YWDTmVZrWgznv9Tl4U=; b=ThDO98ExeX9EQNI421S4q4jqfH7sdrcqv8tBG2bdwQ7oQBQV9dt4vO97klOYHQFR03vER CvGkQSvL1nwbLBisrv0AnerPHGlin6dgHn79TzXEk3nzpENDwebV3tFuM1AlIEZDwcmc8lw Q33klxhyEaHOheDOtxzQa9RFi80KgcWjRuq3R3yNLCtKt/qL+tMsmD78qp4euoOL3ST8GEG MKXJvVsg0MxSxgxCKu20IXHrOVECR9ZQNpL+LibBwMi0GC1zbk1S1ISvaGm6JpijXLngysm XroZ4eKSzXbZHtuukMUJyhn9FawRv7TDF9s5OZhFOIt0UOlOvjC3nUfOO67A== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756909637; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : from; bh=fAxVs7UxTTJ3q2cQ4QUkJenCvTwlIdbuMNQJpeAV4vc=; b=39qW7Fg9BMQAMrkS3PJpr10kFNuDR7FGZet1Ulaumxd4+a7DZBBKYEO8yvyMlAclC6tZJ SI7bOk0+1dhWWgga2mHke0d2PC9nllNUgicS7OWp7Fo1txXjVJbStQHm9jgGobKcmrscAfI 4/w+OAm5CBxnTYafXsWM9EZoZjAGHtcIi9LSOkzOqOeq0Wlosf9T/9dvejwA8+qVEYAAAZg A0998HATR0V8HC0i+Kvta7GrRYVCu5M3XduEKVny6CcOPlWe1r6VO+J/NCpoydmem+UsIUe AjS5bFGw23CZaFnsamI0GBfHC1qbJpXHUZ9OvYJmMRjxtst2B2p1vI36K5oQ== Received: from 5d8f51c41678 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 10B5B68CFF6 for ; Wed, 3 Sep 2025 17:27:17 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Message-ID: <175690963721.25.6977611353239740809@463a07221176> Message-ID-Hash: E5DS4WQR2F7JG7TQTI4JUC7BVEIIG6ZU X-Message-ID-Hash: E5DS4WQR2F7JG7TQTI4JUC7BVEIIG6ZU X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avformat/aviobuf: Don't pretend to support avio_context_free(NULL) (PR #20416) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: mkver via ffmpeg-devel Cc: mkver Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20416 opened by mkver URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20416 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20416.patch It makes no sense to ever call it that way given that avio_context_free() accepts a pointer to a pointer to an AVIOContext. Other double-pointer-free functions like av_freep() also do it that way (and therefore avio_context_free(NULL) still crashes even with 870cfed2317e311a71bc14773332486a162f059c). Signed-off-by: Andreas Rheinhardt >>From cd21fa41c70bdc03660e0566649e9cf2bd7441b7 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 3 Sep 2025 15:51:51 +0200 Subject: [PATCH] avformat/aviobuf: Don't pretend to support avio_context_free(NULL) It makes no sense to ever call it that way given that avio_context_free() accepts a pointer to a pointer to an AVIOContext. Other double-pointer-free functions like av_freep() also do it that way (and therefore avio_context_free(NULL) still crashes even with 870cfed2317e311a71bc14773332486a162f059c). Signed-off-by: Andreas Rheinhardt --- libavformat/aviobuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 2e65f50006..6a6ec36e28 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -125,8 +125,8 @@ AVIOContext *avio_alloc_context( void avio_context_free(AVIOContext **ps) { - if (ps && *ps) { - AVIOContext *s = *ps; + AVIOContext *s = *ps; + if (s) { av_freep(&s->protocol_whitelist); av_freep(&s->protocol_blacklist); } -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org