From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DD3B34C070 for ; Tue, 2 Sep 2025 10:13:46 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'X4bpmdP7Bm94/fNn7fMJeVeYYVVilUxveKiqvqptJ7E=', expected b'fK+zNVu53DSIo+qr5TLUjMtM7pmox2EdAORizXHDaQw=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756808014; h=mime-version : to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=X4bpmdP7Bm94/fNn7fMJeVeYYVVilUxveKiqvqptJ7E=; b=t+PE7eEc7brBt1kgXVq3BaxUCeZ7Rcjo2cNYBZ4r3yjhG3SbPVmEAiKFw/ukFREz4Px26 jx4S79dljscRjqMjyPfMq/PfTyqo/xntggeiFwpaBJ/vZeaIfrR46F/nghlGyIT92LayHHT GwuW69uKzsvdkKDhyIjjFSb1qcJqqV3+SbrXBN/Ew0KRfwqd/dv3BlBJ5Ii3+2T22nW6bmW aJcSD682tEEfj6bLEyhubO9pqYeQ/fEspBFqr5zYB0R+zQZSNm38KfsZwBt6Eb1JMyBs39d vrEqFoRZfQIa8wtl8tGQvE3mLK+dOAtX0zPQZuwpnOj9zdn8tYeFYr2GUxFA== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 59EF968E7A9; Tue, 2 Sep 2025 13:13:34 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1756808004; b=XEFXNYhE7iGLD/9wXMcTy2g1a4Vimzvk9mtqBJ4bUq3VjzCT2IPRDTFECZa0aFHH2vG0x RXtMZUG8ZOvO6nUdXBPyiKDSQ91GGKjl1TKmOPKGxL1qT2TZkVo5I+bpxO76Ic2vxWj0hIK nP3trCm3C1wEJIwmR3oOYD20ie1SjNPI9btNU3nbwA3kqEeZ7F0KP1C2uoagLqIKtD6rGb5 B9qihvKHSyo+Dg2LkKznZXMmUd/z/JIMjEZxk9uTEPV7OpuEnO63oiCHnGlTRJnL/15qCFH YMhjKA/t5BsN8n1ivo930ZfM0fcU9auY4Edl0y1YhRl5RT3ySvkC4bHAkhRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1756808004; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=rjsyL3M0yntArPZRARyEp8UsdXjF3VnCd8y49Z6Pch4=; b=W3722Bz1JtHSpe9+rvvclU2ScGFkaSKxtcpiEOoPFVPmZn+gTE/Qx2/V4lcwwa5+pZKfx R5eWWWGN76LL9iDywsDPKkf6+aiXkPfU3VQsT210jWbsKgMCAxixOUucyJGXsxXkmzEN7YE g9EABDCgg7W55xv2B0swV1+wsWF69vRNy9Zjf4vR09ti8K2kDScPXMoYOx/BnJOyb73O176 or2pMiaBPd+qh0Kf+kpHBrKQ6+nf9dkDMdinEF6xPiSjeptO2zq8wVHA1IGjnhbEaSFv/qT 5XLJyzFUzRow0791b1/YgpmQNsXRC/KfmYnvkGGeoZDuK9SS7wvxEagnbKXg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756807995; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : from; bh=fK+zNVu53DSIo+qr5TLUjMtM7pmox2EdAORizXHDaQw=; b=CtApv1rA7AAhl5Z+mUmWm1PlsGP/n2AkPpRdur1ilPKOADbO/D5RJtEr2/R6jMklvsdny hLQqS985O85OjT9e4IDS8f0/cYY59EKdM8M3B39hJtKFCdVFr7XY2Cr6i3iWhPgX4XHMJLW muptWyBOH7qlFg68axiUI+HMFiFfHR5owXhfvXe9jf7sVGdhUjON3nBrXaYUTOPrls/MlSo LLoG/m+1oq/6DQEUtO2xgjw7zvycovh5xgAUO3GASQQWVOUTlJX60BoDSFLg4I2+aHMwTeH lKrv7jX2waCeNYsLL4WDKfq85eTolrbPn/idynMPW5fM8SvnG8EB77KSy3vg== Received: from 5d8f51c41678 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0F2AB68E72F for ; Tue, 2 Sep 2025 13:13:15 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Message-ID: <175680799520.25.8047854148915595196@463a07221176> Message-ID-Hash: 745YQWMWEEU6AXEDYJJK3QHCJ4R6WQAU X-Message-ID-Hash: 745YQWMWEEU6AXEDYJJK3QHCJ4R6WQAU X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] doc/examples/vaapi_encode: fix invalid check on fwrite (PR #20396) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Zhao Zhili via ffmpeg-devel Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20396 opened by Zhao Zhili (quink) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20396 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20396.patch Firstly, the order of the parameters to fwrite was incorrect, which make fwrite always return 1 or 0. Secondly, enc_pkt->size is 0 after av_packet_unref, which makes the check invalid again. Fix regression from 3e4bfff2. Co-Authored-by: Jin Bo Signed-off-by: Zhao Zhili >>From 5147580520ad627ffbae692119c4e92a7c489c76 Mon Sep 17 00:00:00 2001 From: Zhao Zhili Date: Tue, 2 Sep 2025 18:04:11 +0800 Subject: [PATCH] doc/examples/vaapi_encode: fix invalid check on fwrite Firstly, the order of the parameters to fwrite was incorrect, which make fwrite always return 1 or 0. Secondly, enc_pkt->size is 0 after av_packet_unref, which makes the check invalid again. Fix regression from 3e4bfff2. Co-Authored-by: Jin Bo Signed-off-by: Zhao Zhili --- doc/examples/vaapi_encode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/examples/vaapi_encode.c b/doc/examples/vaapi_encode.c index ff3ebb1e2b..3d718c4c4f 100644 --- a/doc/examples/vaapi_encode.c +++ b/doc/examples/vaapi_encode.c @@ -86,9 +86,10 @@ static int encode_write(AVCodecContext *avctx, AVFrame *frame, FILE *fout) break; enc_pkt->stream_index = 0; - ret = fwrite(enc_pkt->data, enc_pkt->size, 1, fout); + int size = enc_pkt->size; + ret = fwrite(enc_pkt->data, 1, size, fout); av_packet_unref(enc_pkt); - if (ret != enc_pkt->size) { + if (ret != size) { ret = AVERROR(errno); break; } -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org