From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 556F74BB74 for ; Sun, 31 Aug 2025 14:22:02 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'1kf8xsfCnVBbFTkef18zJoN+1uWMRX3X1fbVI2JekRI=', expected b'1J0sKmGQjlTbkUrEVXQ7gp6l+RiPppYKagkaTweAkhs=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756650108; h=mime-version : to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=1kf8xsfCnVBbFTkef18zJoN+1uWMRX3X1fbVI2JekRI=; b=Kb0wFk/1AlNrOHq0CTY/nw5fxj8TYNU8RplqWJ78CZ7hNCQEqbPDpQinnS6aAf4hd64su hVhnJG3rIxETd4QGeM2w/RcxBC0OJGNlJFmkjGi3O3NaxlEozz5BanpbsjPYt9f7MaU3WU7 oIUX01jzyrhJ/JH6aGbGvtM5RuZJ9qwk/nHqTD6NSWJ27osXobe5ZCZQU3VsmvOj/wARZZq kiPOrmpNL2Rc3kFOBKW+BHYlVWlfjDCPl1zAe92vTd3VT6VT1Ebfv5IyXkkxBc/6miqhGJ+ jmRGZJTq6TET2hVXDoqT3DXYD7wQH2HnoskbpKQLELRBsVCXC0mcMF5fuGjA== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id E3FFB68E749; Sun, 31 Aug 2025 17:21:48 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1756650099; b=KPeBCVivClcGnSYsOGrQrkomMcdyYBNAmODBHL7VRUY9pfC3pBXHsWyuqfRuyHWDlpjb5 LFS59aQ7od0NyiUTndzrtO9GAQsk7UPgX45O0zJsD4dYXgjOtl0yp5hQwTZtHLWJN8i/4D7 E6PumLsLKTGBVu5nyJO1mGmZdjeVbGBalv5cO/pgsQbHoSm+I96R+u88zxQxWpXZUL7Jpyn oGvmwS8DdbbjA8ubQ5QBKzMUMWwsTnfYeabS/bKAy4J5bzG/uYf/vuu50jNqwgnUzJl1kpv 95+WhcZgtLeLOOigluljVp+28VdjyGFyNFIfSX2Ov/JLb8k6JQMFq61lrrgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1756650099; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=RL8cnoxESSjrouZfiqty/WO9joXRv6rMPr1V0YJUJ9k=; b=K5fmfA2NyeqO04QxnVauqp/bCQcrcPM/K5DpYYwwURi0t2705b9df6PTjtidXtrpAnIul N3j0Sqm7aOUXItqCujHAcXFUnXA7S05AE6amCK2WPBHZZ9WhVPni0Dl4LOKezZZUEkO5EMm GEVZqUKJKh94yQIJWed9gn+JGO01yTQ01ipJ+jF+gCmEWpe7KhgOUWROdaiAkmEJLq0T6R2 3dx/lG43XCR6kiRxikFiVxnwjg7l2Ci6zrUs4+mvacl6S+XZw6e6T42nUZDLA+Pe8jw22VR ZgcC07E8RkXvT3uPxJItespi4+dSA0bUzSmqX8ITBzycDJXQqYO3Vglep5jA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756650090; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : from; bh=1J0sKmGQjlTbkUrEVXQ7gp6l+RiPppYKagkaTweAkhs=; b=GA+VvQ1aZ5RUO2HYtxpRz6KqK1+xTXOYNt86AywyclAbODrX8tE56bhCPu7u2XXpcp+cR vxYLrvkAbLRd6DOE+R5pClF9MgI4pWqFGkAWhV5RrVGF0/OBdy4iHWGjQBq/MkU2E9SJPWK hRfceUOkXSOuEE/eR7XFKMfhPAqNoWCVxkkoDONvtnZNSY3DiuwnSp3itPTu8s6wr6TA63U wIG2yL8wT0IlnTT9BBPOTG3Io6IMqg8qtcN8us9IotmchtZAGQPH1OmMnNTIth+JQ0Um2wW ZCH1FbmE09GXdSCFVY12/KHt+XwLISQIFY+4nZV3LrFgBr5WmhiRF+RpU6/w== Received: from 5d8f51c41678 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 538506801DC for ; Sun, 31 Aug 2025 17:21:30 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Message-ID: <175665009049.25.4580015152723516445@463a07221176> Message-ID-Hash: PUHKUHHTJH2WIPVUO42XP7VSO63GWV42 X-Message-ID-Hash: PUHKUHHTJH2WIPVUO42XP7VSO63GWV42 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avfilter/vf_frei0r: fix time not being passed in seconds (PR #20379) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: breunigs via ffmpeg-devel Cc: breunigs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20379 opened by breunigs URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20379 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20379.patch The frei0r API expects the time in seconds, but was given it in milliseconds. The bug might exist since 41f1d3a (~14 years ago), but plugins depending on the time are unwatchable without this patch. For example: ffmpeg -filter_complex "testsrc2=d=5,frei0r=distort0r" out.mp4 >>From 08c6099b30b22e4d016c782b01ecd080f05818df Mon Sep 17 00:00:00 2001 From: Stefan Breunig Date: Sun, 6 Jul 2025 08:35:11 +0200 Subject: [PATCH] avfilter/vf_frei0r: fix time not being passed in seconds The frei0r API expects the time in seconds, but was given it in milliseconds. The bug might exist since 41f1d3a (~14 years ago), but plugins depending on the time are unwatchable without this patch. For example: ffmpeg -filter_complex "testsrc2=d=5,frei0r=distort0r" out.mp4 Signed-off-by: Stefan Breunig --- Changelog | 1 + libavfilter/vf_frei0r.c | 2 +- tests/fate/filter-video.mak | 5 +++++ tests/ref/fate/filter-frei0r-filter | 10 ++++++++++ 4 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/filter-frei0r-filter diff --git a/Changelog b/Changelog index 96d616991d..2f36caf2b7 100644 --- a/Changelog +++ b/Changelog @@ -4,6 +4,7 @@ releases are sorted from youngest to oldest. version : - ffprobe -codec option - EXIF Metadata Parsing +- vf_frei0r: properly pass time to filters in seconds version 8.0: diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c index 1284e27310..50d81d220f 100644 --- a/libavfilter/vf_frei0r.c +++ b/libavfilter/vf_frei0r.c @@ -379,7 +379,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) in = in2; } - s->update(s->instance, in->pts * av_q2d(inlink->time_base) * 1000, + s->update(s->instance, in->pts * av_q2d(inlink->time_base), (const uint32_t *)in->data[0], (uint32_t *)out->data[0]); diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak index 2b41574df2..0b430fed16 100644 --- a/tests/fate/filter-video.mak +++ b/tests/fate/filter-video.mak @@ -705,6 +705,11 @@ $(FATE_FILTER_VSYNTH-yes): SRC = $(TARGET_PATH)/tests/vsynth1/%02d.pgm FATE_FFMPEG += $(FATE_FILTER_VSYNTH-yes) +FATE_FILTER_FREI0R-$(call ALLYES, TESTSRC2_FILTER FREI0R_FILTER) = fate-filter-frei0r-filter +fate-filter-frei0r-filter: SRC = testsrc2=r=1:d=5 +fate-filter-frei0r-filter: CMD = framecrc -lavfi "$(SRC),frei0r=enable=gte(n\,3):filter_name=distort0r" +FATE_FFMPEG += $(FATE_FILTER_FREI0R-yes) + # # Metadata tests # diff --git a/tests/ref/fate/filter-frei0r-filter b/tests/ref/fate/filter-frei0r-filter new file mode 100644 index 0000000000..4b1588785d --- /dev/null +++ b/tests/ref/fate/filter-frei0r-filter @@ -0,0 +1,10 @@ +#tb 0: 1/1 +#media_type 0: video +#codec_id 0: rawvideo +#dimensions 0: 320x240 +#sar 0: 1/1 +0, 0, 0, 1, 307200, 0x30630897 +0, 1, 1, 1, 307200, 0xd08784dd +0, 2, 2, 1, 307200, 0xe94387a0 +0, 3, 3, 1, 307200, 0x5df7a70e +0, 4, 4, 1, 307200, 0x9c203210 -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org