From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 39EF24BE0F for ; Fri, 29 Aug 2025 09:05:48 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'UlkVai3G0vnRxo8a6p/lV8l4admqKwebBRpRbNn7smU=', expected b'lUbYtpRfiCG6zfGi+XCQUam4w/jwFJ1G1fL6fFe4vdg=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756458280; h=mime-version : to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=UlkVai3G0vnRxo8a6p/lV8l4admqKwebBRpRbNn7smU=; b=NJqaMdNI4PzTEeLb1nRrwmT6/O7oCcf1/uRjurBLfLDDwUrzjfdvzkkcGfK/qCnxLKccL CO3FBwXi/Es9pvk3VcsAiqp/jRDa86yu8nYdp5KPPPNWrzHyu9qyfC4ag08PI/Onrh0xLia 0Lt/DrFKv78EwwPhN3CypeEOkYNfse1i3L1lo8SDo6x9BcFfofOnvE2MTG0j+bsD7QxCsSH c96Y9m8zqRVJhqHmvruLQRtPm0DHcSzE8C1eIrKZKctuLehRxZ+fdGrWnazoIxpZhdUD+r3 nam1cdIJZbZnVUDX4TbM24UssOJhCEo0ZN14XbdcxjdPJcIOkpnB4ZLDwdaA== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 589D868C698; Fri, 29 Aug 2025 12:04:40 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1756458265; b=hI4ViptfFgp81m9DOBF8bkLzdr6aoH15KWDELNavTTfp20MMpMB7ELGuQljWiQnk6XQ+O KQmNV5JYaINaydXTJvfbKdlWaSshjkI40NUYfwdEspBROgZRYME0crcGBszgCVXHcvj3drl fuPkoxWQLE+1Z3v32IjYx6WWHEfIKXlwnPZ5esjTlUhD0L6pHploreZJnbqMBA2n77eUU7P aVpx0ohTC62aoUENjf8bPA1RQztj7S5IoUll5kQLTOBkYTkN1gqGuFTFUij+VG3o7Fy82hn R9xvA50JaFel+zF8fIOzr+SO9c8Vn1NwwHEZjIYLjw57ZQXhtTQfR923KEmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1756458265; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=mPxLI/JTMarIXa96L2kZUNApJK7OK0oFb53QPjwzdR8=; b=rfOoHLBYvP8lfOwKcqguHNfFPB1X4SpTIHqwoCA5daWokzjHRs39p9wUlu5qRWITvhE99 7NBPyCUs/RuZUbLXY1s0O8NVxeG0tj+3Nq24+CR7QoocP2WwWRfJ8xelpeHuCU4Fvkf1HXi MEYuOck02DJOh9AwLcdcUkC7+JYn/Fvyi7b4GC/uTpQJJbPMk/BFqfbQ5WTzZEXlxGSE3/a kcAXP2puAQhOWYU2AoyU0464QArHTbtTYwFAmChJjaRI5UOAMoaDzqn4FwY7esPjaHOLgH8 VNu3PSwY9Cg1vkITokSH48k7VXOpD9pHH5/NdyJhn3QwRzAKDPY8pux5qMwg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756458253; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : from; bh=lUbYtpRfiCG6zfGi+XCQUam4w/jwFJ1G1fL6fFe4vdg=; b=b6aeBA+kheRmMfLtXUv4QIMpUyf1XzzLTYHh/CeLQKl+Ph6t1493AJxamgwMIJgV0G1Ll TwCm8ZFwEeFAJJ8ig8bPBVLbN9tL3/1J28SHL/s+ZkHVicuaY6qm/u6ujYxenLnnQHa+l5R R4vh6Q7ObIuoBeiTovPl5aZTDm8yHRE349cslCKlbVYUJbF6RleHQecMeMbz4ptsqs7B++M Viz2XpHNuLKlLwp9oEup8AEuoAyh8IGjS36ytGK7dWm+x+UhMIgn25pmynNev72qKQssQ78 lNqu7cyqPcFom+G7lo+qDQMSoOWtYpoJiHWR7iesxjdOXtwapUuhuZtdZBQw== Received: from 5d8f51c41678 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5742868C698 for ; Fri, 29 Aug 2025 12:04:13 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Message-ID: <175645825368.25.5286796109693880533@463a07221176> Message-ID-Hash: VPTOWRASORJTVHKDQXL5KG4WQD6YFFSA X-Message-ID-Hash: VPTOWRASORJTVHKDQXL5KG4WQD6YFFSA X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] cbs_vp9: Always update loop filter and segmentation from current frame (PR #20367) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: nowrep via ffmpeg-devel Cc: nowrep Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20367 opened by nowrep URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20367 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20367.patch Fixes decoding vp90-2-09-aq2, vp90-2-15-segkey_adpq, vp90-2-15-segkey and vp90-2-22-svc_1280x720_1 with Vulkan hwaccel. Fixes: 26a2a76346 ("cbs_vp9: Fix VP9 passthrough") >>From 810afefb2e404bb3fa5c6f5d7c28e6c05c4928c1 Mon Sep 17 00:00:00 2001 From: David Rosca Date: Fri, 29 Aug 2025 10:58:00 +0200 Subject: [PATCH] cbs_vp9: Always update loop filter and segmentation from current frame Fixes decoding vp90-2-09-aq2, vp90-2-15-segkey_adpq, vp90-2-15-segkey and vp90-2-22-svc_1280x720_1 with Vulkan hwaccel. Fixes: 26a2a76346 ("cbs_vp9: Fix VP9 passthrough") --- libavcodec/cbs_vp9_syntax_template.c | 56 ++++++++++++++-------------- 1 file changed, 27 insertions(+), 29 deletions(-) diff --git a/libavcodec/cbs_vp9_syntax_template.c b/libavcodec/cbs_vp9_syntax_template.c index 9d01debb6d..0669cbed0c 100644 --- a/libavcodec/cbs_vp9_syntax_template.c +++ b/libavcodec/cbs_vp9_syntax_template.c @@ -392,39 +392,37 @@ static int FUNC(uncompressed_header)(CodedBitstreamContext *ctx, RWContext *rw, memset(vp9->feature_enabled, 0, sizeof(vp9->feature_enabled)); memset(vp9->feature_value, 0, sizeof(vp9->feature_value)); memset(vp9->feature_sign, 0, sizeof(vp9->feature_sign)); + } - } else { - // Modify previous state based on updates in this frame. - - if (current->loop_filter_delta_update) { - for (i = 0; i < 4; i++) { - if (current->update_ref_delta[i]) - vp9->loop_filter_ref_deltas[i] = - current->loop_filter_ref_deltas[i]; - } - for (i = 0; i < 2; i++) { - if (current->update_mode_delta[i]) - vp9->loop_filter_mode_deltas[i] = - current->loop_filter_mode_deltas[i]; - } + // Modify previous state based on updates in this frame. + if (current->loop_filter_delta_update) { + for (i = 0; i < 4; i++) { + if (current->update_ref_delta[i]) + vp9->loop_filter_ref_deltas[i] = + current->loop_filter_ref_deltas[i]; } + for (i = 0; i < 2; i++) { + if (current->update_mode_delta[i]) + vp9->loop_filter_mode_deltas[i] = + current->loop_filter_mode_deltas[i]; + } + } - if (current->segmentation_update_data) { - memcpy(vp9->feature_enabled, current->feature_enabled, - sizeof(vp9->feature_enabled)); - memcpy(vp9->feature_value, current->feature_value, - sizeof(vp9->feature_value)); - memcpy(vp9->feature_sign, current->feature_sign, - sizeof(vp9->feature_sign)); + if (current->segmentation_update_data) { + memcpy(vp9->feature_enabled, current->feature_enabled, + sizeof(vp9->feature_enabled)); + memcpy(vp9->feature_value, current->feature_value, + sizeof(vp9->feature_value)); + memcpy(vp9->feature_sign, current->feature_sign, + sizeof(vp9->feature_sign)); - if (current->segmentation_update_map) { - memcpy(vp9->segmentation_tree_probs, - current->segmentation_tree_probs, - sizeof(vp9->segmentation_tree_probs)); - memcpy(vp9->segmentation_pred_prob, - current->segmentation_pred_prob, - sizeof(vp9->segmentation_pred_prob)); - } + if (current->segmentation_update_map) { + memcpy(vp9->segmentation_tree_probs, + current->segmentation_tree_probs, + sizeof(vp9->segmentation_tree_probs)); + memcpy(vp9->segmentation_pred_prob, + current->segmentation_pred_prob, + sizeof(vp9->segmentation_pred_prob)); } } -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org