From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 50C414BC2B for ; Tue, 26 Aug 2025 11:51:42 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'IG7b7rGtJowmUXNO7L51V+LSjyEblM2MHbxE46EU7TU=', expected b'Qto8twRKN5xaIS5grO55Xh/vlQZIjgzS6/y3xhmtsSs=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756209092; h=mime-version : to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=IG7b7rGtJowmUXNO7L51V+LSjyEblM2MHbxE46EU7TU=; b=FMqbpRrUwnhhTxHt9mdZ0eNb1hJf6YTunzhrilkt+Onkp69yGj56LgODpDlcg159L9qBl AecXrpeUf7ZtbfAK/M8tP4BX7+TxuCbEc4PDHC8qEDfBPeQA4q4sPH63bdTMPdQxdlESkQi w7ESBvvOMr2Br/k1KLRMlrkFO0/9nohh1SwtdMbmDr3qrLIlU4W31PHd3/ki6s9f5B3ZYzs Xble75vbXHS8RaQ5rCKO4M84VGEnnpaiSvLqC/bKbUmzK8LT2QBKSEn/IefNdnU4hvHzbTV Hq6vv34nW6+M/lELW9cvqxvsQKdY829l35h9m27sjt1uV7y/R/XKP/nsx2+w== Received: from [172.18.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6E6F068E734; Tue, 26 Aug 2025 14:51:32 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1756209076; b=PTU3FFYuMvUaAUmNaR/uXNGoxHXaVHH96gMODpbJJUMoMSXArIL3/Jo0kZ1WNAEWiCFqt o6B6pC8JV7i/mRrVaGQWbRvn+FiuipM2kaDu0dLZFCaqtOWaLjWDB9589uHXJ1ctCrLN0QM kVV7GR3S+mF7jky1ldpbozYCyUPyLMI0gDUlf6Y164qitpFHAYm7la6HB20LPTOCK5UxkH8 KV5s27hGmz+imw7V4mEkeo+xaxDrPFsx6lI91qOGyeaNLW0wSgcm/+X0PoMP9HsAaAkrATm 4x+iFRWEk4aYQOV77il9zpM0MeyjOw+fZSy9fE69ikXEv6ovmdEEUmGQbmSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1756209076; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=MaF1vfy1qGhbEKeZ3pDLfaJ2cLTJTeWmGSiDV36nOBE=; b=ngxiEn6jveIfFJDpaU5UBcRkALpya79K3qzs91QR6RcsHs0b0K3anxo5OTbIrMdqyHLXK Nqg4Bwl8Ksd/OimwVbbIksJOV/wUSMLsqa59wFtwGYB/2HOkRI3OBvYXqWsR6C+xtDnsUh3 Y1d4A1TBwQQptFZdFVA1ZUBAtYN7WaRDx3kggMcJslLXnl8cYyrMtYZuK4H6spLtiYzfLMx /7IQXL7LMBLUs/AwWn3tue+8de7D4s1VWd9KLhT1cv84DN+zHUdbx4GG0/0a2GdOhQ+xjNk xj7RsrVSGaJV7BHOiflQy9lhq+ZKHGrXuWcOK0El68k88Y/iUnPYxw+TpBgw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1756209066; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : from; bh=Qto8twRKN5xaIS5grO55Xh/vlQZIjgzS6/y3xhmtsSs=; b=a+R01kdNtdNwC+hzrq7aYU2xkEh80qMaz86H0NI3FQJv4qSC3oHyr33VcvWNroA6PthFY aNFvVB+d1VxV90AV9m/24rhLqKgWhv+5TdsACP77QIsSTZTFoQhCRATygTkjBcasf2I88qF SBJeKvF5jsL5qltU2xzx/nZBrDWUwx/XunehCi7HHrGS+751cEDUdt96oREKMv1AJgbuVlM XzL4tejaunpFn12SCxEr61UQYBfQt4MwndzHhc6Wfcukvyf+RmWwXdb5sIX1dBM6SJJVM/B /SyHICkes5QSMjxf14Rbxkij78hpgec5u6QmUVI1HrMmr6kIurcVstyB6y3A== Received: from 0f4167fb2350 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 967E668D4A1 for ; Tue, 26 Aug 2025 14:51:06 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Message-ID: <175620906675.34.711573430835667956@5a0384606a8e> Message-ID-Hash: VYFMBP47Y4PFA7QTDQFXX7CFJCD7OIFU X-Message-ID-Hash: VYFMBP47Y4PFA7QTDQFXX7CFJCD7OIFU X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/pcm: add macros to optionally exclude some PCM codecs (PR #20344) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: yibofang via ffmpeg-devel Cc: yibofang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20344 opened by yibofang URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20344 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20344.patch Add build-time macros to control compilation of pcm_alaw, pcm_mulaw, and pcm_vidc encoders/decoders. In many embedded configurations these formats are not required, and disabling them could reduce the binary size about 50 KB. Motivation: - Reduce binary size for embedded or constrained builds Binary size impact (Ubuntu 22.04, x86_64, from `size` output): - text: 28288028 -> 28286684 (-1344 bytes) - data: 1186080 -> 1184864 (-1216 bytes) - bss: 23520112 -> 23470928 (-49184 bytes) - dec: 52994220 -> 52942476 (-51744 bytes, ~50 KB total) This makes inclusion of these PCM codecs configurable rather than always compiled in, providing flexibility for size-sensitive builds. Signed-off-by: YiboFang >>From 212777ce6ca546791ffc619689a135ccab8dedd1 Mon Sep 17 00:00:00 2001 From: YiboFang Date: Tue, 26 Aug 2025 15:54:33 +0800 Subject: [PATCH] avcodec/pcm: add macros to optionally exclude some PCM codecs Add build-time macros to control compilation of pcm_alaw, pcm_mulaw, and pcm_vidc encoders/decoders. In many embedded configurations these formats are not required, and disabling them could reduce the binary size about 50 KB. Motivation: - Reduce binary size for embedded or constrained builds Binary size impact (Ubuntu 22.04, x86_64, from `size` output): - text: 28288028 -> 28286684 (-1344 bytes) - data: 1186080 -> 1184864 (-1216 bytes) - bss: 23520112 -> 23470928 (-49184 bytes) - dec: 52994220 -> 52942476 (-51744 bytes, ~50 KB total) This makes inclusion of these PCM codecs configurable rather than always compiled in, providing flexibility for size-sensitive builds. Signed-off-by: YiboFang --- libavcodec/pcm.c | 28 ++++++++++++++++++++++++++++ libavcodec/pcm_tablegen.h | 22 ++++++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index 68b1945194..bc74e2b0d3 100644 --- a/libavcodec/pcm.c +++ b/libavcodec/pcm.c @@ -50,9 +50,15 @@ static av_cold int pcm_encode_init(AVCodecContext *avctx) ff_thread_once(&init_static_once, pcm_ ## name ## _tableinit); \ } \ break +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER INIT_ONCE(ALAW, alaw); +#endif +#if CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER INIT_ONCE(MULAW, ulaw); +#endif +#if CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER INIT_ONCE(VIDC, vidc); +#endif default: break; } @@ -216,24 +222,30 @@ static int pcm_encode_frame(AVCodecContext *avctx, AVPacket *avpkt, bytestream_put_buffer(&dst, src, n * sample_size); } break; +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER case AV_CODEC_ID_PCM_ALAW: for (; n > 0; n--) { v = *samples++; *dst++ = linear_to_alaw[(v + 32768) >> 2]; } break; +#endif +#if CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER case AV_CODEC_ID_PCM_MULAW: for (; n > 0; n--) { v = *samples++; *dst++ = linear_to_ulaw[(v + 32768) >> 2]; } break; +#endif +#if CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER case AV_CODEC_ID_PCM_VIDC: for (; n > 0; n--) { v = *samples++; *dst++ = linear_to_vidc[(v + 32768) >> 2]; } break; +#endif default: return -1; } @@ -329,18 +341,24 @@ static av_cold av_unused int pcm_lut_decode_init(AVCodecContext *avctx) switch (avctx->codec_id) { default: av_unreachable("pcm_lut_decode_init() only used with alaw, mulaw and vidc"); +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER case AV_CODEC_ID_PCM_ALAW: for (int i = 0; i < 256; i++) s->table[i] = alaw2linear(i); break; +#endif +#if CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER case AV_CODEC_ID_PCM_MULAW: for (int i = 0; i < 256; i++) s->table[i] = ulaw2linear(i); break; +#endif +#if CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER case AV_CODEC_ID_PCM_VIDC: for (int i = 0; i < 256; i++) s->table[i] = vidc2linear(i); break; +#endif } avctx->sample_fmt = AV_SAMPLE_FMT_S16; @@ -547,6 +565,9 @@ static int pcm_decode_frame(AVCodecContext *avctx, AVFrame *frame, bytestream_get_buffer(&src, samples, n * sample_size); } break; +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER || \ + CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER || \ + CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER case AV_CODEC_ID_PCM_ALAW: case AV_CODEC_ID_PCM_MULAW: case AV_CODEC_ID_PCM_VIDC: { @@ -557,6 +578,7 @@ static int pcm_decode_frame(AVCodecContext *avctx, AVFrame *frame, *samples_16++ = lut[*src++]; break; } +#endif case AV_CODEC_ID_PCM_LXF: { int i; @@ -657,7 +679,9 @@ const FFCodec ff_ ## name_ ## _decoder = { \ * to the table in pcm_decode_init() as well. */ // AV_CODEC_ID_* pcm_* name // AV_SAMPLE_FMT_* long name DecodeContext decode init func +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER PCM_CODEC_EXT(ALAW, S16, alaw, "PCM A-law / G.711 A-law", PCMLUTDecode, pcm_lut_decode_init); +#endif PCM_DEC_EXT (F16LE, FLT, f16le, "PCM 16.8 floating point little-endian", PCMScaleDecode, pcm_scale_decode_init); PCM_DEC_EXT (F24LE, FLT, f24le, "PCM 24.0 floating point little-endian", PCMScaleDecode, pcm_scale_decode_init); PCM_CODEC (F32BE, FLT, f32be, "PCM 32-bit floating point big-endian"); @@ -665,7 +689,9 @@ PCM_CODEC (F32LE, FLT, f32le, "PCM 32-bit floating point little PCM_CODEC (F64BE, DBL, f64be, "PCM 64-bit floating point big-endian"); PCM_CODEC (F64LE, DBL, f64le, "PCM 64-bit floating point little-endian"); PCM_DECODER (LXF, S32P,lxf, "PCM signed 20-bit little-endian planar"); +#if CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER PCM_CODEC_EXT(MULAW, S16, mulaw, "PCM mu-law / G.711 mu-law", PCMLUTDecode, pcm_lut_decode_init); +#endif PCM_CODEC (S8, U8, s8, "PCM signed 8-bit"); PCM_CODEC (S8_PLANAR, U8P, s8_planar, "PCM signed 8-bit planar"); PCM_CODEC (S16BE, S16, s16be, "PCM signed 16-bit big-endian"); @@ -688,5 +714,7 @@ PCM_CODEC (U32BE, S32, u32be, "PCM unsigned 32-bit big-endian") PCM_CODEC (U32LE, S32, u32le, "PCM unsigned 32-bit little-endian"); PCM_CODEC (S64BE, S64, s64be, "PCM signed 64-bit big-endian"); PCM_CODEC (S64LE, S64, s64le, "PCM signed 64-bit little-endian"); +#if CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER PCM_CODEC_EXT(VIDC, S16, vidc, "PCM Archimedes VIDC", PCMLUTDecode, pcm_lut_decode_init); +#endif PCM_DECODER (SGA, U8, sga, "PCM SGA"); diff --git a/libavcodec/pcm_tablegen.h b/libavcodec/pcm_tablegen.h index 7274c3cd17..590ba59814 100644 --- a/libavcodec/pcm_tablegen.h +++ b/libavcodec/pcm_tablegen.h @@ -42,6 +42,7 @@ #define VIDC_SEG_SHIFT (5) #define VIDC_SEG_MASK (0xE0) +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER /* alaw2linear() - Convert an A-law value to 16-bit linear PCM */ static av_cold int alaw2linear(unsigned char a_val) { @@ -57,7 +58,9 @@ static av_cold int alaw2linear(unsigned char a_val) return (a_val & SIGN_BIT) ? t : -t; } +#endif +#if CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER static av_cold int ulaw2linear(unsigned char u_val) { int t; @@ -74,7 +77,9 @@ static av_cold int ulaw2linear(unsigned char u_val) return (u_val & SIGN_BIT) ? (BIAS - t) : (t - BIAS); } +#endif +#if CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER static av_cold int vidc2linear(unsigned char u_val) { int t; @@ -88,6 +93,7 @@ static av_cold int vidc2linear(unsigned char u_val) return (u_val & VIDC_SIGN_BIT) ? (BIAS - t) : (t - BIAS); } +#endif #if CONFIG_HARDCODED_TABLES #define pcm_alaw_tableinit() @@ -96,10 +102,19 @@ static av_cold int vidc2linear(unsigned char u_val) #include "libavcodec/pcm_tables.h" #else /* 16384 entries per table */ +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER static uint8_t linear_to_alaw[16384]; +#endif +#if CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER static uint8_t linear_to_ulaw[16384]; +#endif +#if CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER static uint8_t linear_to_vidc[16384]; +#endif +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER || \ + CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER || \ + CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER static av_cold void build_xlaw_table(uint8_t *linear_to_xlaw, int (*xlaw2linear)(unsigned char), int mask) @@ -123,21 +138,28 @@ static av_cold void build_xlaw_table(uint8_t *linear_to_xlaw, } linear_to_xlaw[0] = linear_to_xlaw[1]; } +#endif +#if CONFIG_PCM_ALAW_DECODER || CONFIG_PCM_ALAW_ENCODER static void pcm_alaw_tableinit(void) { build_xlaw_table(linear_to_alaw, alaw2linear, 0xd5); } +#endif +#if CONFIG_PCM_MULAW_DECODER || CONFIG_PCM_MULAW_ENCODER static void pcm_ulaw_tableinit(void) { build_xlaw_table(linear_to_ulaw, ulaw2linear, 0xff); } +#endif +#if CONFIG_PCM_VIDC_DECODER || CONFIG_PCM_VIDC_ENCODER static void pcm_vidc_tableinit(void) { build_xlaw_table(linear_to_vidc, vidc2linear, 0xff); } +#endif #endif /* CONFIG_HARDCODED_TABLES */ #endif /* AVCODEC_PCM_TABLEGEN_H */ -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org