Re: [FFmpeg-devel] [PATCH] lavc/vp8dsp: R-V V vp8_luma_dc_wht - Rémi Denis-Courmont

From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc/vp8dsp: R-V V vp8_luma_dc_wht
Date: Sun, 26 May 2024 10:30:06 +0300
Message-ID: <1753133.x3mBmG8NUe@basile.remlab.net> (raw)
In-Reply-To: <20240526072902.10274-1-remi@remlab.net>

Le sunnuntaina 26. toukokuuta 2024, 10.29.02 EEST Rémi Denis-Courmont a écrit 
:
> diff --git a/libavcodec/riscv/vp8dsp_init.c b/libavcodec/riscv/vp8dsp_init.c
> index 2413fbf449..d48fe08560 100644
> --- a/libavcodec/riscv/vp8dsp_init.c
> +++ b/libavcodec/riscv/vp8dsp_init.c
> @@ -26,6 +26,7 @@
>  #include "libavcodec/vp8dsp.h"
>  #include "vp8dsp.h"
> 
> +void ff_vp8_luma_dc_wht_rvv(int16_t block[4][4][16], int16_t dc[16]);
>  void ff_vp8_idct_dc_add_rvv(uint8_t *dst, int16_t block[16], ptrdiff_t
> stride); void ff_vp8_idct_dc_add4y_rvv(uint8_t *dst, int16_t block[4][16],
> ptrdiff_t stride); void ff_vp8_idct_dc_add4uv_rvv(uint8_t *dst, int16_t
> block[4][16], ptrdiff_t stride); @@ -110,6 +111,7 @@ av_cold void
> ff_vp8dsp_init_riscv(VP8DSPContext *c) int flags = av_get_cpu_flags();
> 
>      if (flags & AV_CPU_FLAG_RVV_I32 && ff_rv_vlen_least(128)) {
> +        c->vp8_luma_dc_wht = ff_vp8_luma_dc_wht_rvv;

Missing XLEN check.

>          c->vp8_idct_dc_add = ff_vp8_idct_dc_add_rvv;
>          c->vp8_idct_dc_add4y = ff_vp8_idct_dc_add4y_rvv;
>          if (flags & AV_CPU_FLAG_RVB_ADDR) {

-- 
Rémi Denis-Courmont
http://www.remlab.net/

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".