From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 5DC6543262
	for <ffmpegdev@gitmailbox.com>; Thu, 26 May 2022 06:34:16 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 70DAD68B5A3;
	Thu, 26 May 2022 09:34:13 +0300 (EEST)
Received: from tytanium.xyz (82-64-195-121.subs.proxad.net [82.64.195.121])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0D84C68B4B4
 for <ffmpeg-devel@ffmpeg.org>; Thu, 26 May 2022 09:34:07 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tytanium.xyz;
 s=mail; t=1653546846; h=from:from:sender:reply-to:subject:subject:date:date:
 message-id:message-id:to:to:cc:mime-version:mime-version:
 content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=OKt5IcrrSryIZJQ7FgA9hu6ifKUL/CAxdP6juIyDyDo=;
 b=k1ytrclhMctMz0PVqGjaIXLixwoH7b/JQtBQ8CU/lzSFgLxqz9Jld5nHVNZJG8TeKeODN2
 bcDmbJ5ZFsjmWuVIGGDjSsHT7JdXUVGf1ZoWMTDJNyrsMxfkUXy9D9SKLRp0SYgLBwPz5u
 38+B0L4ac7yFykLStvOfNKvEIQKfC+Q=
MIME-Version: 1.0
Date: Thu, 26 May 2022 06:34:05 +0000
From: "Trystan Mata" <trystan.mata@tytanium.xyz>
Message-ID: <17399883fa96d941104794f058d60e43@tytanium.xyz>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <69c2ee3d-eec6-89f5-fa18-253b9314c9e@martin.st>
References: <69c2ee3d-eec6-89f5-fa18-253b9314c9e@martin.st>
 <09de2d36-147f-a02d-987c-6fc34cdf110a@tytanium.xyz>
Subject: [FFmpeg-devel] [PATCH v6] avcodec/mfenc: Dynamically load MFPlat.DLL
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/17399883fa96d941104794f058d60e43@tytanium.xyz/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

> In testing of it, I noted that you still need to link against -lmfuuid
> when building with MSVC (but in mingw, those UUIDs are defined inline in
> headers I think).

Ah, I just used used mingw for my testing, sorry.

> Additionally, I realized I do prefer to keep using plain LoadLibraryA
> and FreeLibrary instead of using the wrapper, as this file is all quite
> Windows specific code; using the direct Windows APIs makes it clearer
> what's going on.

I'm not used at all to the Windows APIs, 

> Finally, I removed the extra "" in the GetProcAddress call - I don't
> remember if you ever responded to why that was there.

I didn't see the "Why the extra "" here?", it was the first time that I
did a macro with conversion to text. I just thought that at least a ""
was required to text convert with #.

> As the patch seemed fine otherwise, I went ahead and pushed it. Thanks!

Thank for your reviews !

// Trystan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".