From: "Trystan Mata" <trystan.mata@tytanium.xyz>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v6] avcodec/mfenc: Dynamically load MFPlat.DLL
Date: Thu, 26 May 2022 06:34:05 +0000
Message-ID: <17399883fa96d941104794f058d60e43@tytanium.xyz> (raw)
In-Reply-To: <69c2ee3d-eec6-89f5-fa18-253b9314c9e@martin.st>
> In testing of it, I noted that you still need to link against -lmfuuid
> when building with MSVC (but in mingw, those UUIDs are defined inline in
> headers I think).
Ah, I just used used mingw for my testing, sorry.
> Additionally, I realized I do prefer to keep using plain LoadLibraryA
> and FreeLibrary instead of using the wrapper, as this file is all quite
> Windows specific code; using the direct Windows APIs makes it clearer
> what's going on.
I'm not used at all to the Windows APIs,
> Finally, I removed the extra "" in the GetProcAddress call - I don't
> remember if you ever responded to why that was there.
I didn't see the "Why the extra "" here?", it was the first time that I
did a macro with conversion to text. I just thought that at least a ""
was required to text convert with #.
> As the patch seemed fine otherwise, I went ahead and pushed it. Thanks!
Thank for your reviews !
// Trystan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-05-26 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 10:54 Trystan Mata
2022-05-25 20:51 ` Martin Storsjö
2022-05-25 21:16 ` Timo Rothenpieler
2022-05-25 21:34 ` Martin Storsjö
2022-05-26 6:34 ` Trystan Mata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17399883fa96d941104794f058d60e43@tytanium.xyz \
--to=trystan.mata@tytanium.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git