From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C8EAB4CB06 for ; Wed, 14 Aug 2024 11:59:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DEDEA68D6C8; Wed, 14 Aug 2024 14:59:48 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DE86D68D6C8 for ; Wed, 14 Aug 2024 14:59:41 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=j3LiMAfy; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 866A8240DB7 for ; Wed, 14 Aug 2024 13:59:41 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id GzQ4oZrwlANr for ; Wed, 14 Aug 2024 13:59:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1723636780; bh=BFTR6Okv/4seoXjGHmee3/U/B0KBZzuMdqB/c3//xNY=; h=Subject:From:To:In-Reply-To:References:Date:From; b=j3LiMAfy9Wa0sf8kFns+wN0OrJPy8Ytw3LSAyiBVNHoXzn6JADhB5mqJYbvgdA9TN EErLUz5mCQpnyp9a9fRM85CyLt5Mv6kaLkpSICQcPrkoddZ40TOn5ia3S+16hgoxlT Wna2x8kLihKOtaJBcXAx2IyfAENOKvr/h2K0bzXnhw1VwfBY+TRe+S4hrc3ln89yov JedR9MuAQ/rFrCWJRNh1YnCjUKkuKtI+1SSbGQG+dFGqs2FumL8Jp3ZdXwS5k62/Mn 7ZukC0u0iGVs8JgOtmTIOiQtImqWRAGIeqX9xSqfnvze21GUKglj3VYPoi5I/0TvFk d7c7Y0gdE699g== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id DB12A240695 for ; Wed, 14 Aug 2024 13:59:40 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id B9FD91601B9; Wed, 14 Aug 2024 13:59:40 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 14 Aug 2024 13:59:40 +0200 Message-ID: <172363678073.21344.17032067424798643528@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: remove useless error check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marvin Scholz (2024-08-13 20:06:42) > When ret is checked here, it was never assigned anything, making this > check useless, as highlighted by Coverity. > > It seems to be a copy paste mistake given that opt_match_per_stream_str > does not return an error code that could be checked and the previous > value assigned to ret is already checked above. So just remove this > check. > > Fixes: CID1616292 > --- > fftools/ffmpeg_mux_init.c | 2 -- > 1 file changed, 2 deletions(-) LGTM Thanks, -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".