From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0AF084CAE4 for ; Wed, 14 Aug 2024 11:45:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6578768DA4F; Wed, 14 Aug 2024 14:45:22 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CC67F68DA05 for ; Wed, 14 Aug 2024 14:45:14 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=Pj83Ev8k; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3F85A240DB7 for ; Wed, 14 Aug 2024 13:45:14 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id kU1EwNh0IDKB for ; Wed, 14 Aug 2024 13:45:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1723635913; bh=j+AkoxMYzJRmexGhqVdCweOfRMX0BSNSNiPfjBoLqds=; h=Subject:From:To:In-Reply-To:References:Date:From; b=Pj83Ev8kJrKduXAK779QtTT8uCvbZPA0hGCQY0v77eS8SntT/MYlYhV4kbzz9Vc5B IpcPHDQ6TRYukUczQIZMbSA815sRCMPaK3rXX/bpeRjEoVsTPQXSrTye8Mz57N5YTr YmUsLZPzwKsSLogjuy3QNERK+i2EBNEr7BJdAwkVU8HHmrvuNOZZUAyChWkqSBL+MA IpBGt1taDr2AbzE3mQoTyPmxHfScjl0ML0N0+Q8UsR0Bb+51lqvlj3yeX6I251RVOx qkQjISu2SDW14yKlvDnXckzcxacHxxbWq31wOIUMTAcXDDW82UXrdeeYF4RkVfyNH2 EulP4NKl8MwCg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 7E959240695 for ; Wed, 14 Aug 2024 13:45:13 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 6913A1601B9; Wed, 14 Aug 2024 13:45:13 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <172249913303.21344.17598597604771690214@lain.khirnov.net> <20240801213625.90394-1-joshua.allmann@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 14 Aug 2024 13:45:13 +0200 Message-ID: <172363591340.21344.2828049948991828308@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Josh Allmann (2024-08-13 18:57:59) > On Wed, 7 Aug 2024 at 09:13, Josh Allmann wrote: > > > > On Thu, 1 Aug 2024 at 14:37, Josh Allmann wrote: > > > > > > Encoders may emit a buffering period SEI without a corresponding > > > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. > > > > > > During Annex B conversion, this may result in the SPS/PPS being > > > inserted *after* the buffering period SEI but before the IDR NAL. > > > > > > Since the buffering period SEI references the SPS, the SPS/PPS > > > needs to come first. > > > --- > > > libavcodec/bsf/h264_mp4toannexb.c | 15 +++++++++++++++ > > > tests/ref/fate/h264-bsf-mp4toannexb | 2 +- > > > tests/ref/fate/h264_mp4toannexb_ticket2991 | 18 +++++++++--------- > > > tests/ref/fate/segment-mp4-to-ts | 12 ++++++------ > > > 4 files changed, 31 insertions(+), 16 deletions(-) > > > > > > > Ping for (re-)review on this patch which addresses comments from [1] > > > > Explanation for the FATE changes here [2] - it turns out that several > > of the FATE samples exhibit the same behavior that this patch fixes, > > so it is a net improvement > > > > [1] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-August/331958.html > > [2] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-July/330912.html > > > > Gentle ping for re-review. pushed -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".