From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E2CF4B262 for ; Thu, 1 Aug 2024 08:59:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B86FD68D8EA; Thu, 1 Aug 2024 11:59:09 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DBC9968D412 for ; Thu, 1 Aug 2024 11:59:02 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=IwGm/z1D; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 6F61B240DB7 for ; Thu, 1 Aug 2024 10:59:02 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id BTkT4W74b76W for ; Thu, 1 Aug 2024 10:59:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1722502741; bh=80KjFytVHi9mVOrmh/RoRckqr79RnKXOsyZ+VTcRwT8=; h=Subject:From:To:In-Reply-To:References:Date:From; b=IwGm/z1DQLX4o+YwZqom/Ut2HJH1b8Mt6JxKPch2K1DlMem3Vtqb/EoRE+GpHIfh2 wbOYB27g/LPk5TCcgWRyrWtQrq71m4sVPWVBWxpo+YRI13a3xKH3FtpbJed6FrnpUD 1kd1Qe0ssHC5obFrQkmab6blmhMaXEFnHieDrO71JNsbSgMyxkFGe0c3jr6rCDslqN ev/BPAHR8UafVNRSJ1KmA+9FxGgPJBegGpDqahRCwDE79cokz0f/HTL5sxpIR7qgTR bXUC71jDDF29+AhEmKHxtIqCHBMC9syUPOtasq3yqw06tQje/k/f+teD5rORSv/gXJ S/Ad/sw3r83rg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id C3346240695 for ; Thu, 1 Aug 2024 10:59:01 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 989961601B9; Thu, 1 Aug 2024 10:59:01 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240801021410.5061-1-jamrial@gmail.com> References: <20240801021410.5061-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 01 Aug 2024 10:59:01 +0200 Message-ID: <172250274159.21344.614194252437021946@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: ensure the IAMF track is the first X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-08-01 04:14:09) > Fixes crashes when muxing video tracks alongside IAMF ones. > > Signed-off-by: James Almer > --- > libavformat/movenc.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index ae49582a1a..87ec368d52 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -7536,6 +7536,7 @@ static int mov_init_iamf_track(AVFormatContext *s) > if (!track->iamf) > return AVERROR(ENOMEM); > > + track->first_iamf_idx = INT_MAX; > for (int i = 0; i < s->nb_stream_groups; i++) { > const AVStreamGroup *stg = s->stream_groups[i]; > switch(stg->type) { > @@ -7558,6 +7559,11 @@ static int mov_init_iamf_track(AVFormatContext *s) > return ret; > } > > + if (track->first_iamf_idx != 0) { > + av_log(s, AV_LOG_ERROR, "The IMAF track must be the first track\n"); Why? And is this documented anywhere? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".