From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A7F9249B16 for ; Thu, 1 Aug 2024 07:41:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E1A3068D79D; Thu, 1 Aug 2024 10:41:35 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 234DE68D115 for ; Thu, 1 Aug 2024 10:41:29 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=VnzEb84w; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 8BA42240DB7; Thu, 1 Aug 2024 09:41:28 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 8Ls0KsjKTGMt; Thu, 1 Aug 2024 09:41:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1722498087; bh=1CmxdKtXeIjCBvV8vUvpvwUpsoO2SF1CHBQaqpM4H+0=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=VnzEb84wMfqr8inptzgb00tNEcaKGtzFvxpUyCxSUCn8pZRYmtQQ7GnrGubW2agyu iA/BEazCxoL0cUAW8pzwfIOybgSAOzyobAiUzc148shvEqiKvzA2s6s+UxcyP+pIng 05iukjrzK0YaPQOQqL2t3rpRZp8N2WJ8JmkNe0wg0pkP016zyy27248zuyFoMfrzV7 UqRvENEATyonZV/5Z1cuMMiKwkreHHuNFpELaOa21UF8RBlpcZIQTeyJ+n+osoaTWc l4thVJx6+1+vpcfvmerhiEwFTVxnhch0mjthYAfvj+3JkpALARVjLvSifhiEQlDTx3 TMjGVWD+vHR+g== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BF206240695; Thu, 1 Aug 2024 09:41:27 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 12CA11601B9; Thu, 1 Aug 2024 09:41:16 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240730180333.9082-1-j@n-garcia.com> References: <20240730180333.9082-1-j@n-garcia.com> Mail-Followup-To: FFmpeg development discussions and patches , Jan Garcia Date: Thu, 01 Aug 2024 09:41:16 +0200 Message-ID: <172249807603.21344.7426181722356383819@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: show video stats in progress output without filters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jan Garcia Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Jan Garcia via ffmpeg-devel (2024-07-30 20:03:33) > Since ffmpeg 6.1 video stats are accidentally hidden from progress output > if no filters are used. IIUC this applies only to streamcopy, not transcoding with no user-specified filters. > This patch re-enables video stats (like frames=) in the progress output. > --- > Changelog | 1 + > fftools/ffmpeg.c | 8 +++++--- > 2 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Changelog b/Changelog > index 571b27ad98..2c2cbf9179 100644 > --- a/Changelog > +++ b/Changelog > @@ -5,6 +5,7 @@ version : > - Raw Captions with Time (RCWT) closed caption demuxer > - LC3/LC3plus decoding/encoding using external library liblc3 > - ffmpeg CLI filtergraph chaining > +- ffmpeg CLI again shows video stats in progress output We generally do not mention bugfixes in the changelog, otherwise it'd be too long and unreadable. > - LC3/LC3plus demuxer and muxer > - pad_vaapi, drawbox_vaapi filters > - vf_scale supports secondary ref input and framesync options > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index 3aa2e12780..420ba3c6e4 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -587,7 +587,7 @@ static void print_report(int is_last_report, int64_t timer_start, int64_t cur_ti > av_bprintf(&buf_script, "stream_%d_%d_q=%.1f\n", > ost->file->index, ost->index, q); > } > - if (!vid && ost->type == AVMEDIA_TYPE_VIDEO && ost->filter) { > + if (!vid && ost->type == AVMEDIA_TYPE_VIDEO) { > float fps; > uint64_t frame_number = atomic_load(&ost->packets_written); > > @@ -601,8 +601,10 @@ static void print_report(int is_last_report, int64_t timer_start, int64_t cur_ti > if (is_last_report) > av_bprintf(&buf, "L"); > > - nb_frames_dup = atomic_load(&ost->filter->nb_frames_dup); > - nb_frames_drop = atomic_load(&ost->filter->nb_frames_drop); > + if (ost->filter) { > + nb_frames_dup = atomic_load(&ost->filter->nb_frames_dup); > + nb_frames_drop = atomic_load(&ost->filter->nb_frames_drop); > + } Change itself looks ok. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".