From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 220994AE9B for ; Fri, 26 Jul 2024 07:47:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 947B468D671; Fri, 26 Jul 2024 10:47:18 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 626A568C17D for ; Fri, 26 Jul 2024 10:47:12 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=rzL2HDQm; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id D5C87240DB7; Fri, 26 Jul 2024 09:47:11 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 7yQKGRnnqEml; Fri, 26 Jul 2024 09:47:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1721980030; bh=XTAxLnMwM98WD0rACvRJ+LAFSk2bMPgsY8JbIh4ja44=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=rzL2HDQmOqJD1PWAOn5/lzeExIGxATMY1322kZ36BtXsWWWdqM0X5OPCDMbQeU9i2 N3FnRnXbCjmbqedm0F6TifJZ20RCwhdWNxBWcHTzitivTywbRD4UTTEzrut/otEAhx 6x2zQiEWkKP33zkm8cvqU4S/KOPpxzKBFpVdnq41mfMwZwdzdKoq3cogYCj2Tru8A1 q12EYecQAjY+lvxgplSa9iFsBkkD8i/iuOlC+hweUZveHVIx6P0N2gX+6hvSD6624V crQ4BDEqA0gd9Kdd+U5Tl38m7+Yc5g2ar4eBnaOBn2gBUsJzxOSOfVd9JZcH6GDkDg CFszbYdK1gpLg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id DD2FD240695; Fri, 26 Jul 2024 09:47:10 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id C8ECC1601B9; Fri, 26 Jul 2024 09:47:10 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240726064216.893951-1-dev@lynne.ee> References: <20240726064216.893951-1-dev@lynne.ee> Mail-Followup-To: FFmpeg development discussions and patches , Lynne Date: Fri, 26 Jul 2024 09:47:10 +0200 Message-ID: <172198003078.21344.2362190110390447941@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavu/tx: stop using av_log(NULL, ) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lynne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne via ffmpeg-devel (2024-07-26 08:42:11) > Its not feasible to add an AVClass in the main context, as > it would waste space, as the main context is recursive, and > every bit of assembly would need to be changed. > > While its true that on paper av_log has access to the main > context, that functionality is not used as no options are > available for setting. No options will be exposed either, > and it makes no sense. > > mpv has recently started warning if a NULL AVClass is used > as an FFmpeg bug. While I don't fully agree nor disagree with > this, this is a simple patch which fixes the issue. No, it just hides the issue for the time being. I am against this patch, just add a proper AVClass. AVTXContext is entirely opaque, so it should definitely be feasible. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".