From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B78114C29B for ; Tue, 23 Jul 2024 21:02:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0693F68D60B; Wed, 24 Jul 2024 00:02:56 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B3DB168BD43 for ; Wed, 24 Jul 2024 00:02:48 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=alDx5jQI; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 6E8A6240DB7 for ; Tue, 23 Jul 2024 23:02:48 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id SGydMdZMLdkg for ; Tue, 23 Jul 2024 23:02:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1721768563; bh=nPjfxzxaSWZVvsYz2TWKqee0hXTtOCzTMFROAX7QA1o=; h=Subject:From:To:In-Reply-To:References:Date:From; b=alDx5jQIAWF3qNLMLNuds0sUWhAcp77yLESzT4R2MtPYDiEysvw0joFjTDJhzF1xJ ygN00GBZWqOsPm7/iFc+NuPPAYRP3TbVxz5U4KiVK9xf+bXmwE7UK8fefNLsSIwwNB PGvsvrujjaAniuAWK75TheOT2ZpOw3tAOpYjCY0H7VvUdNGnARnMMseoAqqMgx6bL2 3M2KlwWXr9qbcocEdOWf+fEeIoE1TkxiuXGtXCBegcKJUsPPO9EoXY16cKm1DQZWAt bPrNOM20DrDxfmORPG/01SuTp9pKIdOsCAVkCvIjure3dJXm4NjcmyzyycTrXVSKIh ZgmxspVq2ZGIg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id CFBB6240695 for ; Tue, 23 Jul 2024 23:02:43 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id BAE101601B9; Tue, 23 Jul 2024 23:02:43 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240723201419.GD4991@pb2> References: <20240717205156.GT4991@pb2> <20240722094322.28916-1-anton@khirnov.net> <20240722094322.28916-2-anton@khirnov.net> <20240722211404.GU4991@pb2> <172171757878.21847.669877092691675989@lain.khirnov.net> <20240723201419.GD4991@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 23 Jul 2024 23:02:43 +0200 Message-ID: <172176856373.21847.15363929320562502876@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2024-07-23 22:14:19) > On Tue, Jul 23, 2024 at 08:52:58AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-07-22 23:14:04) > > > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > > > There is no reason to delay it and this is a more natural place for > > > > this code. > > > > > > There is a reason. > > > By doing it later the surrounding pixels are available and one could > > > compute motion vectors from these surroundings and use all kinds of stuff > > > from motion compensation and optical flow and all that. > > > > > > someone, i dont remember exactly who, (maybe you remember?) > > > said something about premature optimization is the root of all evil. > > > Here that actually applies. Moving the code up thwarts write better > > > error concealment. (and frankly we already have most of that EC code > > > it would just need a cleanup to free it from the 16x16 limitation) > > > > This is not an optimization though. > > > > But okay, I am dropping both original patch 28 and these 3 new patches. > > Are you ok with the rest of the series? > > The series looked mostly ok, is there somewhere i can take a quick look > at the current set ? I just pushed it to branch 'receive_frame' in my tree. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".