From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BCF5548A27 for ; Tue, 23 Jul 2024 06:53:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 525C768D562; Tue, 23 Jul 2024 09:53:13 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4234F68D28D for ; Tue, 23 Jul 2024 09:53:06 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=Nj+4daGk; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A2520240DB7 for ; Tue, 23 Jul 2024 08:53:05 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id nzmucpj1cdhw for ; Tue, 23 Jul 2024 08:53:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1721717585; bh=8H5OP2SRBRqs9F0ywbnGR96hYIhCGpmSLGemzAm60Ik=; h=Subject:From:To:In-Reply-To:References:Date:From; b=Nj+4daGklS0qw5JF63lM4OXrDtc1znrtiP6/+J7Mzgje1+C0rmR+dEmhGgNkGlLop 0KODUsc9yhKqCb9l4BTfDo3i5hVy91cUUt85AzbbsLc2R/QzLvpyUuT+YJNua0X6My NgidbgfEZ1U0IYNliRpDJAtb60W2lWMi5jQskd9c9+X1WRsdAdaLUaxEVuC8fYW1rb 5/T+N9KO8PE/S5EhM2u7kcHuLu3wJNAZDXUzoMNtWGeQAqTFfN/CItZLh3iop7+aOk nNqsXEE0KFzXN77UoqyQgUOJkrt0ny4NDFoVimcc3bpW7Rh6pXlTZ2q3pUHGMKxJRh MdFnrAPHezQOg== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id F01D9240695 for ; Tue, 23 Jul 2024 08:53:04 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id C89E01601B9; Tue, 23 Jul 2024 08:52:58 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240722211404.GU4991@pb2> References: <20240717205156.GT4991@pb2> <20240722094322.28916-1-anton@khirnov.net> <20240722094322.28916-2-anton@khirnov.net> <20240722211404.GU4991@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 23 Jul 2024 08:52:58 +0200 Message-ID: <172171757878.21847.669877092691675989@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/3] lavc/ffv1: move damage handling code to decode_slice() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2024-07-22 23:14:04) > On Mon, Jul 22, 2024 at 11:43:21AM +0200, Anton Khirnov wrote: > > There is no reason to delay it and this is a more natural place for > > this code. > > There is a reason. > By doing it later the surrounding pixels are available and one could > compute motion vectors from these surroundings and use all kinds of stuff > from motion compensation and optical flow and all that. > > someone, i dont remember exactly who, (maybe you remember?) > said something about premature optimization is the root of all evil. > Here that actually applies. Moving the code up thwarts write better > error concealment. (and frankly we already have most of that EC code > it would just need a cleanup to free it from the 16x16 limitation) This is not an optimization though. But okay, I am dropping both original patch 28 and these 3 new patches. Are you ok with the rest of the series? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".