From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 30752420A1 for ; Sat, 20 Jul 2024 06:11:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 81DDD68D85C; Sat, 20 Jul 2024 09:11:20 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 456D168D6C3 for ; Sat, 20 Jul 2024 09:11:14 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=TCA1X5IF; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 43C01240DB7 for ; Sat, 20 Jul 2024 08:11:13 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id HeTNzuoQRK4r for ; Sat, 20 Jul 2024 08:11:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1721455868; bh=LGuvAuxlr3hpgtDwuYEWbfvqpjOVZToT4z543Hq0xes=; h=Subject:From:To:In-Reply-To:References:Date:From; b=TCA1X5IFj6zdxIxZeRlSEPwQX9CItrah2kL6JIspVEtCPWMLEUjLzrNVJedqTJCz/ OdtUimsNQKQ4zjY5FqjBq/rjwKlq8rGCfrSFt6KljAAPnU/UrEVm75lZVGaZdCiyMd U8VistWQO7StX6iQ8ianzuK0GFINlt09a3zqDzQdZBgIG65DdSj5G1+PS0tuemzd22 oXeKnErddeKzv7jajrH97OWRN4690msc7g6Ro3cMFmC4LXs11zO9RsYC5Mv0HYdXNq htrU3MQgix9NlSyuz8NHlSvJl0oxvO51te2iV57MEPqSSZswUJEDIQGVRgZJT/ny4P y3YXk//7ibprQ== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 8B742240695 for ; Sat, 20 Jul 2024 08:11:08 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 607201601B9; Sat, 20 Jul 2024 08:11:02 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240720000828.GK4991@pb2> References: <20240715144825.3652038-1-michael@niedermayer.cc> <172119856184.21847.8183623909028998274@lain.khirnov.net> <20240720000828.GK4991@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 20 Jul 2024 08:11:02 +0200 Message-ID: <172145586236.21847.12842344042206656670@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2024-07-20 02:08:28) > On Wed, Jul 17, 2024 at 08:42:41AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-07-15 16:48:25) > [...] > > > @@ -3155,8 +3156,11 @@ static int decode_slice(HEVCContext *s, const H2645NAL *nal, GetBitContext *gb) > > > int ret; > > > > > > ret = hls_slice_header(&s->sh, s, gb); > > > - if (ret < 0) > > > + if (ret < 0) { > > > + //The code is not capable to rewind from an error, the state now is inconsistant so we cannot use it on depandant slices > > ^ ^ > > e e > > Also I'd drop everything before the comma, why mention rewinding that is > > not implemented and may not be a good idea anyway. > > It seems we disagree on some things. > A failing function should not corrupt the state. We also dont do that > in other cases like SPS/PPS. > This is also unexpected, so it should be documented. In my view, the root problem is not that the state is corrupted, but that the independent slice segment is missing. No rewinding you can do will conjure it out of nowhere, and it's not at all clear to me that using some random previous slice segment's data is the right thing to do. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".