From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 264724BECF for ; Thu, 18 Jul 2024 10:07:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E7EEB68D9F0; Thu, 18 Jul 2024 13:07:13 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7047668D7B9 for ; Thu, 18 Jul 2024 13:07:06 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=gk1T46Wi; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id DC069240DB8 for ; Thu, 18 Jul 2024 12:07:05 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id 0S0z0PACpt6u for ; Thu, 18 Jul 2024 12:07:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1721297225; bh=DjGrXX1yrmyAW5x8R03uPxY35Z9Ti6pLb27uzpiBSHQ=; h=Subject:From:To:In-Reply-To:References:Date:From; b=gk1T46WiPb8DVsRqlkKia4m46YLMOUuBkx2odJz/0z3+z/aXJI3RSvKT2VjEHrOzI 7upF8DqkBltQYP49lRgj3FAyxSRMngj4rTkgQikYHRjIsUG/a/TrDRVONkW/JiYC26 hNQgBJfyPvtYiHh/yuHWW1mWSDOkl0z8zfhzIe3ifkT5+nnw+TdIkXmZjQOSSHEwGz f8Z6Ugme35F+VN1y22tdn94hKQ3x7OI43YA66Ud/ODkRx97PqSogo/Uw5FrpSkKdQR LK6BRlW8pETfYVh3RoPho4JZjNt2cYdCxEywyDzk7xv9A8O/IGuXuWMw0Ge3JXcwkR m0lb8p+Ekw5jA== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 02469240DB7 for ; Thu, 18 Jul 2024 12:07:05 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id D6FBE1601B9; Thu, 18 Jul 2024 12:07:04 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240718020330.5295-1-jamrial@gmail.com> References: <20240718015856.5276-1-jamrial@gmail.com> <20240718020330.5295-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 18 Jul 2024 12:07:04 +0200 Message-ID: <172129722483.21847.12904852158891368017@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_demux: don't insert the crop filter if frame cropping side data defines no cropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2024-07-18 04:03:30) > Signed-off-by: James Almer > --- > fftools/ffmpeg_demux.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c > index 528e02149f..6f7d78c896 100644 > --- a/fftools/ffmpeg_demux.c > +++ b/fftools/ffmpeg_demux.c > @@ -1014,7 +1014,8 @@ int ist_filter_add(InputStream *ist, InputFilter *ifilter, int is_simple, > opts->crop_bottom = AV_RL32(sd->data + 4); > opts->crop_left = AV_RL32(sd->data + 8); > opts->crop_right = AV_RL32(sd->data + 12); > - if (ds->apply_cropping && ds->apply_cropping != CROP_CODEC) > + if (ds->apply_cropping && ds->apply_cropping != CROP_CODEC && > + (opts->crop_top | opts->crop_bottom | opts->crop_left | opts->crop_right)) Looks ok -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".