From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2C45449716 for ; Thu, 18 Jul 2024 08:20:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B22F68D9C1; Thu, 18 Jul 2024 11:20:17 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DFD568D85D for ; Thu, 18 Jul 2024 11:20:11 +0300 (EEST) Authentication-Results: mail0.khirnov.net; dkim=pass (2048-bit key; unprotected) header.d=khirnov.net header.i=@khirnov.net header.a=rsa-sha256 header.s=mail header.b=meIQssyO; dkim-atps=neutral Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 9CF68240DB8 for ; Thu, 18 Jul 2024 10:20:10 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavis, port 10024) with ESMTP id Djpg4d3ORAFs for ; Thu, 18 Jul 2024 10:20:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=khirnov.net; s=mail; t=1721290810; bh=xqx1I3LUBzvqMHsGjiJrRDYk2/8GVbqft1vryvRIvi8=; h=Subject:From:To:In-Reply-To:References:Date:From; b=meIQssyOd+I7z9V6Wp6ceedDalytKa/+kFk3aMi2t7+3bVmD/ZKIPlligB1EGTgGu TxnRnu/vicAFvVewo0/1IWYbB7ctcR0wcriWQw5OGanItGPXUycoK6AymvGziwSVRM vCQ1TU5Fkt+YKB3eDlPEDXKQOrhw8AAsPwSdJil+CDeWsnnE6vZS0OytWkc/Dj4a1e HtSeApnz4GsyVXnTkcpDLhBuEn4zPqyjbe2kvN8+Q2QwM3Y+hIn37jbGmbNjdC/zOE KFdmdPz6tljh2keXp0Avh/IcJqLWhPjwZkOMAqxSk2a2gWXnZ2zCIYFnSEFGhl89+E Z3et4V8WzW9ew== Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 19A39240DB7 for ; Thu, 18 Jul 2024 10:20:10 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id ED3BC1601B9; Thu, 18 Jul 2024 10:20:09 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20240717223238.GW4991@pb2> References: <20240716171155.31838-1-anton@khirnov.net> <20240716171155.31838-13-anton@khirnov.net> <20240717223238.GW4991@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 18 Jul 2024 10:20:09 +0200 Message-ID: <172129080994.21847.15080640617406361149@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 13/39] lavc/ffv1: drop redundant PlaneContext.quant_table X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2024-07-18 00:32:38) > the data for each decoder task should be together and not scattered around > more than needed, reducing cache efficiency > > putting all this extra code in the inner per pixel loop is not ok > especially not for the sake of avoiding a memcpy of a few hundread bytes multiple levels of loops outside A nice theory, but in practice this patchset makes single-threaded decoding about 4% faster overall, on a 1920x1080 10bit sample. That's just the ffv1 parts (up to patch 28), full set also improves frame threading performance as follows: threads improvement --------------------------- 2 52% (yes really) 4 16% 8 12% -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".